From patchwork Fri Apr 5 07:36:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nithin Dabilpuram X-Patchwork-Id: 52320 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A307B1B467; Fri, 5 Apr 2019 09:36:42 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 53E481B466 for ; Fri, 5 Apr 2019 09:36:40 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x357Ufd0029673; Fri, 5 Apr 2019 00:36:39 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=Hxb1tKnHvwCArcD0n90SvQqqg+m0UhD0d7f61wiJbWo=; b=ELnWwJb32/QmBtKybG5HV0glEsx9jqQGS6uRCKsMUpG7s/tjUnhfDLG5Kp8GIqxTfdpQ dajRHwRFEZqRcQu2LNHl656vHgdNOAWgYet49ln5ZMpl3m4wStIojOP1KkO+RiExGJum j+Z3GTIMEw6AtpaOUnv1M34OK0QIywRSmsPDm39WGIglf6HqQQiJBb/zp6W/j7l68AoV eHtDz5broitntR2hTPebPcyCrlBtOwkinkGnfDwVQsqG16o9sdjsiF9SFQb7G/FqMHol iWjIvXFAgcHS6AzxcWSVEslAqKyGk1IofqfkqwIPSkv/vhj2HQpxTLxTt9eUDs1x+Ceu OA== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 2rnmxek3pa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 05 Apr 2019 00:36:39 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 5 Apr 2019 00:36:28 -0700 Received: from NAM03-BY2-obe.outbound.protection.outlook.com (104.47.42.50) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Fri, 5 Apr 2019 00:36:28 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hxb1tKnHvwCArcD0n90SvQqqg+m0UhD0d7f61wiJbWo=; b=ZBjjsF7GNLv63AVeTuBa39ySUCQLnG3YWbvgUXjXbbvy0EKRpSoeqacZqX0AGXbspDyxLRwFgmiRge6X0yV2B+YpapqMS0nyHmkShAqvV4taFadPQK4tnt5THmjx2E1sGGo3u9x3V01RkKrklXmpN/pxel4xqcLvahMgnZeYCUI= Received: from DM6PR18MB2427.namprd18.prod.outlook.com (20.179.104.21) by DM6PR18MB2827.namprd18.prod.outlook.com (20.179.51.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.20; Fri, 5 Apr 2019 07:36:24 +0000 Received: from DM6PR18MB2427.namprd18.prod.outlook.com ([fe80::6830:4485:aa22:8862]) by DM6PR18MB2427.namprd18.prod.outlook.com ([fe80::6830:4485:aa22:8862%6]) with mapi id 15.20.1750.017; Fri, 5 Apr 2019 07:36:24 +0000 From: Nithin Kumar Dabilpuram To: Wenzhuo Lu , Jingjing Wu , Bernard Iremonger CC: "dev@dpdk.org" , Ferruh Yigit , Nithin Kumar Dabilpuram , "shahafs@mellanox.com" Thread-Topic: [PATCH v3 2/2] app/testpmd: fix Tx QinQ set Thread-Index: AQHU64JFxylyMLxpNUyV0Zp8NJOnQQ== Date: Fri, 5 Apr 2019 07:36:24 +0000 Message-ID: <20190405073558.9930-2-ndabilpuram@marvell.com> References: <20190219064840.12046-1-ndabilpuram@marvell.com> <20190405073558.9930-1-ndabilpuram@marvell.com> In-Reply-To: <20190405073558.9930-1-ndabilpuram@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BM1PR01CA0165.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:68::35) To DM6PR18MB2427.namprd18.prod.outlook.com (2603:10b6:5:180::21) x-mailer: git-send-email 2.8.4 x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 563423d9-e622-464c-f1be-08d6b999677e x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(2017052603328)(7193020); SRVR:DM6PR18MB2827; x-ms-traffictypediagnostic: DM6PR18MB2827: x-microsoft-antispam-prvs: x-forefront-prvs: 0998671D02 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(136003)(376002)(39860400002)(396003)(346002)(199004)(189003)(50226002)(256004)(6116002)(14444005)(76176011)(71200400001)(4744005)(81166006)(52116002)(97736004)(2616005)(3846002)(1076003)(106356001)(36756003)(6436002)(478600001)(68736007)(476003)(66066001)(486006)(71190400001)(11346002)(105586002)(2906002)(6512007)(5660300002)(6486002)(8936002)(386003)(102836004)(55236004)(86362001)(8676002)(4326008)(25786009)(6506007)(26005)(99286004)(53936002)(7736002)(54906003)(446003)(305945005)(110136005)(81156014)(316002)(14454004)(186003); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR18MB2827; H:DM6PR18MB2427.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: Zjf/BCJA/l6a4ou+PeB06u12NV5/Fl6PdGMWBpOb8vABJkS38R31N1VCLI3DgFkdw8ZxgxX2uzSvpTsrWYYnJ9NPH5f47sdKdPGKHjA7uH38Z9VUGxdCPYPnPl44cdAGOWgIBukSVsOsweW6AKTWTLrh6Jj974QZxfC+pKQG1weStt+XrdJODoIZYyhH+pM3QVJJU/eDjvd9jXpgV/fb/AXbISxxoXOX/berJeSRcv9/2q8AWFfp69NWRuuGoQpz5oMhkpTtW9+EOCVsei3qPkl4bUfICrgCULTdWEuNxxOjESCW53DB03IzAYFXi+9tZgZyqBfCKMLyApbSnSq8TgndpNPfuZa8KueI3QQwtEd/o9Dg2jP935F1E3KS43qqQHMReMjwZIi6kwtUkp8MJsCijJAjK+zUnH6+VQVL6m4= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 563423d9-e622-464c-f1be-08d6b999677e X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Apr 2019 07:36:24.2575 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB2827 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-05_05:, , signatures=0 Subject: [dpdk-dev] [PATCH v3 2/2] app/testpmd: fix Tx QinQ set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Enable DEV_TX_OFFLOAD_VLAN_INSERT also along with DEV_TX_OFFLOAD_VLAN_QINQ in tx_qinq_set() as it takes both vlan id's as arguments. Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API") Cc: shahafs@mellanox.com Signed-off-by: Nithin Dabilpuram --- v3: * Rename headline v2: * Split change into two seperate patches as suggested. app/test-pmd/config.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 010e26d..f9cb129 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -3006,7 +3006,8 @@ tx_qinq_set(portid_t port_id, uint16_t vlan_id, uint16_t vlan_id_outer) } tx_vlan_reset(port_id); - ports[port_id].dev_conf.txmode.offloads |= DEV_TX_OFFLOAD_QINQ_INSERT; + ports[port_id].dev_conf.txmode.offloads |= (DEV_TX_OFFLOAD_VLAN_INSERT | + DEV_TX_OFFLOAD_QINQ_INSERT); ports[port_id].tx_vlan_id = vlan_id; ports[port_id].tx_vlan_id_outer = vlan_id_outer; }