| Message ID | 20200306120652.30080-1-ktraynor@redhat.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Ferruh Yigit |
| Headers | show |
| Series | [v2,1/2] net/hinic: fix snprintf length | expand |
| Context | Check | Description |
|---|---|---|
| ci/Intel-compilation | success | Compilation OK |
| ci/iol-mellanox-Performance | success | Performance Testing PASS |
| ci/iol-testing | success | Testing PASS |
| ci/iol-intel-Performance | success | Performance Testing PASS |
| ci/checkpatch | success | coding style OK |
On 3/6/2020 12:06 PM, Kevin Traynor wrote: > Correct length and remove unnecessary brackets. > > Fixes: d9ce1917941c ("net/hinic/base: add hardware operation") > Cc: stable@dpdk.org > > Signed-off-by: Kevin Traynor <ktraynor@redhat.com> > > --- > v2: fix typo in commit msg > For series, Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> Series applied to dpdk-next-net/master, thanks.
diff --git a/drivers/net/hinic/base/hinic_pmd_hwdev.c b/drivers/net/hinic/base/hinic_pmd_hwdev.c index 8b16897ad..b6c821a2a 100644 --- a/drivers/net/hinic/base/hinic_pmd_hwdev.c +++ b/drivers/net/hinic/base/hinic_pmd_hwdev.c @@ -1391,5 +1391,5 @@ static void print_cable_info(struct hinic_link_info *info) memcpy(tmp_vendor, info->vendor_name, sizeof(info->vendor_name)); - snprintf(tmp_str, (sizeof(tmp_str) - 1), + snprintf(tmp_str, sizeof(tmp_str), "Vendor: %s, %s, %s, length: %um, max_speed: %uGbps", tmp_vendor, info->sfp_type ? "SFP" : "QSFP", port_type,
Correct length and remove unnecessary brackets. Fixes: d9ce1917941c ("net/hinic/base: add hardware operation") Cc: stable@dpdk.org Signed-off-by: Kevin Traynor <ktraynor@redhat.com> --- v2: fix typo in commit msg Cc: xuanziyang2@huawei.com Cc: cloud.wangxiaoyun@huawei.com Cc: zhouguoyang@huawei.com --- drivers/net/hinic/base/hinic_pmd_hwdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)