From patchwork Wed Mar 11 11:32:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Kevin Traynor X-Patchwork-Id: 66540 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B0ABFA056A; Wed, 11 Mar 2020 12:33:34 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6A62A1BFFF; Wed, 11 Mar 2020 12:33:34 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 3092E1BF7F for ; Wed, 11 Mar 2020 12:33:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583926412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qk5assWfbKkki1Tg5CStepOFLd3arkdOKV6/fZDON48=; b=CgGtdy5Dz3ySXCyhl7OnJBLjwJCVLmBa5Tnp7epsFblugJkUfbGKlOfqEmikwFyWOPGHbC BiKd92tzGVkd8oS28zvPAZtkJrcOdbfWGdRRuJNklraW2zWzKXJC5oJtQ8Swqr1V3MozRv 8J83WcbW3jSM56Zk3h1YTAVDEtGLXlk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-60-HQsKhyjxPcmeJkVxqE7zfw-1; Wed, 11 Mar 2020 07:33:25 -0400 X-MC-Unique: HQsKhyjxPcmeJkVxqE7zfw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0A356184C81D; Wed, 11 Mar 2020 11:33:24 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.148]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9439C60C88; Wed, 11 Mar 2020 11:33:17 +0000 (UTC) From: Kevin Traynor To: dev@dpdk.org Cc: Kevin Traynor , stable@dpdk.org, allain.legacy@windriver.com, Steven Webster , Matt Peters Date: Wed, 11 Mar 2020 11:32:59 +0000 Message-Id: <20200311113300.32487-1-ktraynor@redhat.com> In-Reply-To: <20200220093744.13925-1-ktraynor@redhat.com> References: <20200220093744.13925-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [dpdk-dev] [PATCH v2 1/2] net/avp: fix gcc 10 maybe-uninitialized warning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" gcc 10.0.1 reports: ../drivers/net/avp/avp_ethdev.c: In function ‘avp_xmit_scattered_pkts’: ../drivers/net/avp/avp_ethdev.c:1791:24: warning: ‘avp_bufs[count]’ may be used uninitialized in this function [-Wmaybe-uninitialized] 1791 | tx_bufs[i] = avp_bufs[count]; | ~~~~~~~~^~~~~~~ ../drivers/net/avp/avp_ethdev.c:1791:24: warning: ‘avp_bufs[count]’ may be used uninitialized in this function [-Wmaybe-uninitialized] Fix by intializing the array. Fixes: 295abce2d25b ("net/avp: add packet transmit functions") Cc: stable@dpdk.org Signed-off-by: Kevin Traynor Acked-by: Steven Webster --- v2: no change note, commit log violates line length but I didn't want to split warning msg. Cc: allain.legacy@windriver.com Cc: Steven Webster Cc: Matt Peters --- drivers/net/avp/avp_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c index cd747b6be..1abe96ce5 100644 --- a/drivers/net/avp/avp_ethdev.c +++ b/drivers/net/avp/avp_ethdev.c @@ -1695,5 +1695,5 @@ avp_xmit_scattered_pkts(void *tx_queue, { struct rte_avp_desc *avp_bufs[(AVP_MAX_TX_BURST * - RTE_AVP_MAX_MBUF_SEGMENTS)]; + RTE_AVP_MAX_MBUF_SEGMENTS)] = {}; struct avp_queue *txq = (struct avp_queue *)tx_queue; struct rte_avp_desc *tx_bufs[AVP_MAX_TX_BURST];