[v2,5/8] bus/fslmc: fix usage of dpio blocklist flag

Message ID 20200911083520.24020-6-sachin.saxena@oss.nxp.com (mailing list archive)
State Superseded, archived
Headers
Series enhancement and fixes for nxp dpaax platform |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Sachin Saxena (OSS) Sept. 11, 2020, 8:35 a.m. UTC
From: Sachin Saxena <sachin.saxena@oss.nxp.com>

DPIO object shouldn't be reserved if it is mentioned in blocklist.
Exiting code is not setting the correct flag when such object is found.

Fixes: c904a212646a ("bus/fslmc: run secondary debug app without blocklist devices")

Signed-off-by: Sachin Saxena <sachin.saxena@oss.nxp.com>
---
 drivers/bus/fslmc/fslmc_vfio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Hemant Agrawal Sept. 14, 2020, 10:58 a.m. UTC | #1
Please squash it with patch 2/8

> -----Original Message-----
> From: Sachin Saxena (OSS) <sachin.saxena@oss.nxp.com>
> Sent: Friday, September 11, 2020 2:05 PM
> To: dev@dpdk.org; ferruh.yigit@intel.com
> Subject: [PATCH v2 5/8] bus/fslmc: fix usage of dpio blocklist flag
> 
> From: Sachin Saxena <sachin.saxena@oss.nxp.com>
> 
> DPIO object shouldn't be reserved if it is mentioned in blocklist.
> Exiting code is not setting the correct flag when such object is found.
> 
> Fixes: c904a212646a ("bus/fslmc: run secondary debug app without blocklist
> devices")
> 
> Signed-off-by: Sachin Saxena <sachin.saxena@oss.nxp.com>
> ---
>  drivers/bus/fslmc/fslmc_vfio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/bus/fslmc/fslmc_vfio.c b/drivers/bus/fslmc/fslmc_vfio.c
> index 6dd797632..83df83373 100644
> --- a/drivers/bus/fslmc/fslmc_vfio.c
> +++ b/drivers/bus/fslmc/fslmc_vfio.c
> @@ -816,7 +816,7 @@ fslmc_vfio_process_group(void)
>  			dpio_count++;
>  			if (dev->device.devargs &&
>  			    dev->device.devargs->policy ==
> RTE_DEV_BLACKLISTED)
> -				is_dpmcp_in_blocklist = true;
> +				is_dpio_in_blocklist = true;
>  		}
>  	}
> 
> --
> 2.28.0
  

Patch

diff --git a/drivers/bus/fslmc/fslmc_vfio.c b/drivers/bus/fslmc/fslmc_vfio.c
index 6dd797632..83df83373 100644
--- a/drivers/bus/fslmc/fslmc_vfio.c
+++ b/drivers/bus/fslmc/fslmc_vfio.c
@@ -816,7 +816,7 @@  fslmc_vfio_process_group(void)
 			dpio_count++;
 			if (dev->device.devargs &&
 			    dev->device.devargs->policy == RTE_DEV_BLACKLISTED)
-				is_dpmcp_in_blocklist = true;
+				is_dpio_in_blocklist = true;
 		}
 	}