From patchwork Tue Apr 20 13:21:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Traynor X-Patchwork-Id: 91880 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C31CA0548; Tue, 20 Apr 2021 15:22:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4ED20417D8; Tue, 20 Apr 2021 15:22:06 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id B243241735 for ; Tue, 20 Apr 2021 15:22:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618924923; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yY0tOBKrI1V1Hyb23qLkf59Ko7lMTkgT6YT/aCYkn6U=; b=M+0cf61jjPpPZZS41CWLIlJiHnyRCdGbrFKpdZhYsw0e69qdephmzwBBmbBP2QJUBAUCLN TRVpPL6odjYTXNGyXsFb1ntwcGlJ+RvZTbN4a8HsXW+XupIOHCr7+LpE1n+loNNLnChAbY VDkMQL+DMxefAiC8N3iKKIzHZs0MgRc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-498-AgDo-xmuNmKTY_gCES9YBg-1; Tue, 20 Apr 2021 09:22:01 -0400 X-MC-Unique: AgDo-xmuNmKTY_gCES9YBg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 898D218BA290; Tue, 20 Apr 2021 13:22:00 +0000 (UTC) Received: from rh.Home (ovpn-112-162.ams2.redhat.com [10.36.112.162]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9D040610F4; Tue, 20 Apr 2021 13:21:59 +0000 (UTC) From: Kevin Traynor To: dev@dpdk.org Cc: Kevin Traynor , Olivier Matz Date: Tue, 20 Apr 2021 14:21:50 +0100 Message-Id: <20210420132150.167817-2-ktraynor@redhat.com> In-Reply-To: <20210420132150.167817-1-ktraynor@redhat.com> References: <20210420130915.166692-1-ktraynor@redhat.com> <20210420132150.167817-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [dpdk-dev] [PATCH v2 2/2] app/test: silence clang 12 warning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" clang 12 gives a warning about string concatenation in arrays. In this case, as it is a long string test the strings are concatenated. Add parentheses to indicate this. $ clang --version clang version 12.0.0 (Fedora 12.0.0-0.3.rc1.fc34) [2556/2719] Compiling C object app/test/dpdk-test.p/test_cmdline_num.c.o ../app/test/test_cmdline_num.c:204:5: warning: suspicious concatenation of string literals in an array initialization; did you mean to separate the elements with a comma? [-Wstring-concatenation] "1111000011110000111100001111000011110000111100001111000011110000", ^ ../app/test/test_cmdline_num.c:203:3: note: place parentheses around the string literal to silence warning "0b1111000011110000111100001111000011110000111100001111000011110000" ^ Signed-off-by: Kevin Traynor --- v2: updated commit msg --- app/test/test_cmdline_num.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test/test_cmdline_num.c b/app/test/test_cmdline_num.c index ec479cdb3a..9276de59bd 100644 --- a/app/test/test_cmdline_num.c +++ b/app/test/test_cmdline_num.c @@ -201,6 +201,6 @@ const char * num_invalid_strs[] = { "-0b0111010101", /* too long (128+ chars) */ - "0b1111000011110000111100001111000011110000111100001111000011110000" - "1111000011110000111100001111000011110000111100001111000011110000", + ("0b1111000011110000111100001111000011110000111100001111000011110000" + "1111000011110000111100001111000011110000111100001111000011110000"), "1E3", "0A",