diff mbox series

crypto/qat: fix failed raw data path dequeue

Message ID 20210727154246.59519-1-roy.fan.zhang@intel.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers show
Series crypto/qat: fix failed raw data path dequeue | expand

Checks

Context Check Description
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-testing fail Testing issues
ci/iol-abi-testing success Testing PASS
ci/intel-Testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/github-robot success github build: passed
ci/checkpatch success coding style OK

Commit Message

Zhang, Roy Fan July 27, 2021, 3:42 p.m. UTC
This patch fixes the raw data path dequeue burst fail problem.
Previously the in case the queue is full and not all packets
asked to be dequeued are processed, the dequeue burst will
never happen.

Fixes: c21574edc52a ("cryptodev: add dequeue count parameter in raw API")
Cc: roy.fan.zhang@intel.com

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
 drivers/crypto/qat/qat_sym_hw_dp.c | 8 --------
 1 file changed, 8 deletions(-)

Comments

Akhil Goyal July 27, 2021, 6:10 p.m. UTC | #1
> This patch fixes the raw data path dequeue burst fail problem.
> Previously the in case the queue is full and not all packets
> asked to be dequeued are processed, the dequeue burst will
> never happen.
> 
> Fixes: c21574edc52a ("cryptodev: add dequeue count parameter in raw API")
> Cc: roy.fan.zhang@intel.com
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Cc: stable@dpdk.org

Applied to dpdk-next-crypto
Akhil Goyal July 27, 2021, 6:11 p.m. UTC | #2
> > This patch fixes the raw data path dequeue burst fail problem.
> > Previously the in case the queue is full and not all packets
> > asked to be dequeued are processed, the dequeue burst will
> > never happen.
> >
> > Fixes: c21574edc52a ("cryptodev: add dequeue count parameter in raw
> API")
> > Cc: roy.fan.zhang@intel.com
> >
> > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> Cc: stable@dpdk.org
> 
> Applied to dpdk-next-crypto
diff mbox series

Patch

diff --git a/drivers/crypto/qat/qat_sym_hw_dp.c b/drivers/crypto/qat/qat_sym_hw_dp.c
index 4305579b54..ac9ac05363 100644
--- a/drivers/crypto/qat/qat_sym_hw_dp.c
+++ b/drivers/crypto/qat/qat_sym_hw_dp.c
@@ -744,14 +744,6 @@  qat_sym_dp_dequeue_burst(void *qp_data, uint8_t *drv_ctx,
 		n = get_dequeue_count(resp_opaque);
 		if (unlikely(n == 0))
 			return 0;
-		else if (n > 1) {
-			head = (head + rx_queue->msg_size * (n - 1)) &
-				rx_queue->modulo_mask;
-			resp = (struct icp_qat_fw_comn_resp *)(
-				(uint8_t *)rx_queue->base_addr + head);
-			if (*(uint32_t *)resp == ADF_RING_EMPTY_SIG)
-				return 0;
-		}
 	} else {
 		if (unlikely(max_nb_to_dequeue == 0))
 			return 0;