From patchwork Tue Aug 17 13:44:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Baum X-Patchwork-Id: 97010 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F655A0548; Tue, 17 Aug 2021 15:47:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8B80841294; Tue, 17 Aug 2021 15:45:51 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2083.outbound.protection.outlook.com [40.107.223.83]) by mails.dpdk.org (Postfix) with ESMTP id 0922F4128E for ; Tue, 17 Aug 2021 15:45:49 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N4G1i2EpfdyBDy16TBhlaHuA3gQO/p43Xy7LABbgeLvB6wICAxKE4LgjAqmV7YGUN5lkZq1aH1N8USjF0wHkQyZ6K7GTlLAbBRikDHFRU53MLMstCLa8E27MBtMilZCGSBAC/gJpVsz45id4pEI3CJKqEzRYpyKTOT+x8M6ELHjWZ5MWx8EVRJc4JRRvt+d62FxG9b5Ws/9byp2AIyn9JIBcFaGTAQ37OM0VFL7L28OxQ6iUywzXgw4P1JErAA0x7ya68mBDWRxIUx4kaDReRVHR19QuvvBUWr+YWHvFfc2SEVAbCXB5S7K4VHe7E1nJJ5zBZEagB+ztAWQxNH33ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G6h8H4IyzxdGIrKOti1triigEOVqiYx6vtI0hLtTSaU=; b=Au+bqeJPQhByrsG+o9gwtckmZIQh8h5xQ0FMYVWQNwHfxHj3zN39vHGqdm+56ZnWGxGEifiicsYcGvtZaJYj5A6Ou4cE0IidIM5TCtby2iXOFY25dMjfBcoXgWGWcYR6e9xq5QRuOSkF6chAQOHD1Ne1BMwF+26MQ67KkwZoAMh09VC5o4tVCjx4icHlYajjKlvrW7jmptlTEmN8pmUFxbBoznQUbLVgKNVLEX4ctLJ1l3VkbROaruadvBPQmnqqPGR3ixOPjZLDuJ6gxlfH9X/w0BDso3/M+B2lJJsj3KO2sfyHDsMTtyrA/I3j/QyDL9hn18X0FmyKjESx/k8oUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.35) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G6h8H4IyzxdGIrKOti1triigEOVqiYx6vtI0hLtTSaU=; b=RJeY/gJyr+yvf290vYsGaWwR/s1jKfniLQWJa0ae/eAzqEly1+YYyw3kX3B3FiwHafkyUns/Xj7mUH2IMfdQatYL9qbg7wdFm0bGqcDKfqkG361aZmwjgenxLjDyAva+nYlG/2eWF/30P8mbjucP+3zDmqJOPacZ8WOx2mrlijJILgqJbAmDT6uGl2QgBmO0PN9E5IeMKHcQ3e+tCawTLOJqvD0/iD7jA1Ib6MtJN2R/5wMFJvUqCkc3BQKhZGbfcTQ4H8ZrK38Ie5baHOhS/VvUFTCbdSFqJPOLGNqaZUYr1ug6rmXH/DbRRYVQPUNr0g1umU9eryvPY4aQCcXTlA== Received: from BN1PR12CA0021.namprd12.prod.outlook.com (2603:10b6:408:e1::26) by BY5PR12MB4804.namprd12.prod.outlook.com (2603:10b6:a03:1b6::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.13; Tue, 17 Aug 2021 13:45:47 +0000 Received: from BN8NAM11FT017.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e1:cafe::7d) by BN1PR12CA0021.outlook.office365.com (2603:10b6:408:e1::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19 via Frontend Transport; Tue, 17 Aug 2021 13:45:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.35) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.35 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.35; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.35) by BN8NAM11FT017.mail.protection.outlook.com (10.13.177.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4415.14 via Frontend Transport; Tue, 17 Aug 2021 13:45:46 +0000 Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 17 Aug 2021 13:45:45 +0000 Received: from nvidia.com (172.20.187.6) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 17 Aug 2021 13:45:43 +0000 From: Michael Baum To: CC: Matan Azrad , Raslan Darawsheh , Viacheslav Ovsiienko Date: Tue, 17 Aug 2021 16:44:39 +0300 Message-ID: <20210817134441.1966618-20-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210817134441.1966618-1-michaelba@nvidia.com> References: <20210817134441.1966618-1-michaelba@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To DRHQMAIL107.nvidia.com (10.27.9.16) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9e05c113-eebb-494a-d3a7-08d961855122 X-MS-TrafficTypeDiagnostic: BY5PR12MB4804: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2887; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LRZgXaRoahXzb+nVhV68zAsSNrrIB5hnIdS8HN/i8teM1zXUthhQCqsk4lrLvpGz/7PDn0b6b3JDAYG5otTJ2isclKozqNThtEvej6/08FxaHGFhHtI3lycEafeIuhAGLVKTiRVdy+fb2q9w4vww7kURusxaoLO0gaHz0eYQ+yB+r9JZG+Y4uCilxqQoCZxU0tQvm3p6ZfV8WLMl0ADFlrnkFow3NXaHgCp8CaT/uh+Xblhze49whB/8D2Vl2IdFIjl4tR0pbSvoNOcBG3FPEgnViNS1jxusGNP1TOgikIrHtRlsKHHrJewZ+fozIpa3/t2rl8L5iG9ETAdAqTrD+6HJXcYWxrt8wBwPpKkIyBC/f887d7sohxCWyv0g30y/Dv2XfI9Hs73cDQBCyeUK3p637k8soI175FBi4QgTSWifJvljUCRCZ/EO53BnpnNly+PLkTiPgVZ48+S6iJr7m23wkGn6bqu91Oz/bai6JCyKgF+nkVtrRufWuhvqR4pEhFfHg0ooJWda1t0NmQxKXiF+/7uSfvlAoN0TlX3NRkCKll++Tng1IEU+VF+CGyRy26jjLpZzaDQMm/+epFzkjp1wYfnm2S56AzFp9PaPeen0KdFhS7/kEgkO0cTr8xIR4uJ5ziXVSufhtAXUOW1wp9AhZBQnP+CHvwLy3cBPBtZiMB8Tn+t83vSFT0l3cQUriE3ekeQCSn4k0AqOhwBfeA== X-Forefront-Antispam-Report: CIP:216.228.112.35; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid04.nvidia.com; CAT:NONE; SFS:(4636009)(376002)(346002)(396003)(136003)(39860400002)(36840700001)(46966006)(70586007)(107886003)(426003)(8936002)(86362001)(7696005)(36860700001)(70206006)(82740400003)(6916009)(336012)(2906002)(8676002)(5660300002)(55016002)(316002)(1076003)(7636003)(2616005)(36756003)(478600001)(6666004)(26005)(82310400003)(356005)(16526019)(83380400001)(6286002)(54906003)(186003)(47076005)(4326008); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2021 13:45:46.7908 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9e05c113-eebb-494a-d3a7-08d961855122 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.35]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT017.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4804 Subject: [dpdk-dev] [RFC 19/21] compress/mlx5: use HCA attributes from context device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Use HCA attributes from context device structure, instead of query it for itself. Signed-off-by: Michael Baum --- drivers/compress/mlx5/mlx5_compress.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/compress/mlx5/mlx5_compress.c b/drivers/compress/mlx5/mlx5_compress.c index 93b0cc8ea6..e5d900568d 100644 --- a/drivers/compress/mlx5/mlx5_compress.c +++ b/drivers/compress/mlx5/mlx5_compress.c @@ -753,7 +753,6 @@ mlx5_compress_dev_probe(struct mlx5_common_device *dev) struct rte_compressdev *cdev; struct mlx5_dev_ctx *dev_ctx = &dev->ctx; struct mlx5_compress_priv *priv; - struct mlx5_hca_attr att = { 0 }; struct rte_compressdev_pmd_init_params init_params = { .name = "", .socket_id = dev->dev->numa_node, @@ -765,14 +764,6 @@ mlx5_compress_dev_probe(struct mlx5_common_device *dev) rte_errno = ENOTSUP; return -rte_errno; } - if (mlx5_devx_cmd_query_hca_attr(dev_ctx->ctx, &att) != 0 || - att.mmo_compress_en == 0 || att.mmo_decompress_en == 0 || - att.mmo_dma_en == 0) { - DRV_LOG(ERR, "Not enough capabilities to support compress " - "operations, maybe old FW/OFED version?"); - rte_errno = ENOTSUP; - return -ENOTSUP; - } cdev = rte_compressdev_pmd_create(ibdev_name, dev->dev, sizeof(*priv), &init_params); if (cdev == NULL) { @@ -788,8 +779,8 @@ mlx5_compress_dev_probe(struct mlx5_common_device *dev) priv = cdev->data->dev_private; priv->dev_ctx = dev_ctx; priv->cdev = cdev; - priv->min_block_size = att.compress_min_block_size; - priv->sq_ts_format = att.sq_ts_format; + priv->min_block_size = dev_ctx->hca_attr.compress_min_block_size; + priv->sq_ts_format = dev_ctx->hca_attr.sq_ts_format; if (mlx5_compress_hw_global_prepare(priv) != 0) { rte_compressdev_pmd_destroy(priv->cdev); return -1;