[v6,04/10] mbuf: add IPsec ESP tunnel type
Checks
Commit Message
Add tunnel type for IPsec ESP tunnels
Signed-off-by: Declan Doherty <declan.doherty@intel.com>
Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
Signed-off-by: Abhijit Sinha <abhijit.sinha@intel.com>
Signed-off-by: Daniel Martin Buckley <daniel.m.buckley@intel.com>
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
---
lib/mbuf/rte_mbuf_core.h | 1 +
1 file changed, 1 insertion(+)
Comments
>
> Add tunnel type for IPsec ESP tunnels
>
> Signed-off-by: Declan Doherty <declan.doherty@intel.com>
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> Signed-off-by: Abhijit Sinha <abhijit.sinha@intel.com>
> Signed-off-by: Daniel Martin Buckley <daniel.m.buckley@intel.com>
> Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
> Acked-by: Akhil Goyal <gakhil@marvell.com>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
> ---
> lib/mbuf/rte_mbuf_core.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.h
> index bb38d7f581..a4d95deee6 100644
> --- a/lib/mbuf/rte_mbuf_core.h
> +++ b/lib/mbuf/rte_mbuf_core.h
> @@ -253,6 +253,7 @@ extern "C" {
> #define PKT_TX_TUNNEL_MPLSINUDP (0x5ULL << 45)
> #define PKT_TX_TUNNEL_VXLAN_GPE (0x6ULL << 45)
> #define PKT_TX_TUNNEL_GTP (0x7ULL << 45)
> +#define PKT_TX_TUNNEL_ESP (0x8ULL << 45)
As I can see, that's not ptype, that's TX flag.
Could you clarify what exactly what flag would mean for PMD TX:
- what is expected from the user who sets this flag
- what is expected from PMD that claims to support it.
BTW, would we need new DEV_TX_OFFLOAD_* for it?
> /**
> * Generic IP encapsulated tunnel type, used for TSO and checksum offload.
> * It can be used for tunnels which are not standards or listed above.
> --
> 2.25.1
On 9/23/2021 1:59 PM, Ananyev, Konstantin wrote:
>> Add tunnel type for IPsec ESP tunnels
>>
>> Signed-off-by: Declan Doherty <declan.doherty@intel.com>
>> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
>> Signed-off-by: Abhijit Sinha <abhijit.sinha@intel.com>
>> Signed-off-by: Daniel Martin Buckley <daniel.m.buckley@intel.com>
>> Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
>> Acked-by: Akhil Goyal <gakhil@marvell.com>
>> Acked-by: Olivier Matz <olivier.matz@6wind.com>
>> ---
>> lib/mbuf/rte_mbuf_core.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.h
>> index bb38d7f581..a4d95deee6 100644
>> --- a/lib/mbuf/rte_mbuf_core.h
>> +++ b/lib/mbuf/rte_mbuf_core.h
>> @@ -253,6 +253,7 @@ extern "C" {
>> #define PKT_TX_TUNNEL_MPLSINUDP (0x5ULL << 45)
>> #define PKT_TX_TUNNEL_VXLAN_GPE (0x6ULL << 45)
>> #define PKT_TX_TUNNEL_GTP (0x7ULL << 45)
>> +#define PKT_TX_TUNNEL_ESP (0x8ULL << 45)
> As I can see, that's not ptype, that's TX flag.
> Could you clarify what exactly what flag would mean for PMD TX:
> - what is expected from the user who sets this flag
> - what is expected from PMD that claims to support it.
>
> BTW, would we need new DEV_TX_OFFLOAD_* for it?
There is documentation above for the other tunnel types, they are
supposed to be used for TSO purposes. I will update the commit message
to clarify this.
>
>> /**
>> * Generic IP encapsulated tunnel type, used for TSO and checksum offload.
>> * It can be used for tunnels which are not standards or listed above.
>> --
>> 2.25.1
@@ -253,6 +253,7 @@ extern "C" {
#define PKT_TX_TUNNEL_MPLSINUDP (0x5ULL << 45)
#define PKT_TX_TUNNEL_VXLAN_GPE (0x6ULL << 45)
#define PKT_TX_TUNNEL_GTP (0x7ULL << 45)
+#define PKT_TX_TUNNEL_ESP (0x8ULL << 45)
/**
* Generic IP encapsulated tunnel type, used for TSO and checksum offload.
* It can be used for tunnels which are not standards or listed above.