diff mbox series

[v3] devtools: add acronyms in dictionary for commit checks

Message ID 20210917105839.270289-1-asekhar@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers show
Series [v3] devtools: add acronyms in dictionary for commit checks | expand

Checks

Context Check Description
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-spell-check-testing warning Testing issues
ci/intel-Testing fail Testing issues
ci/Intel-compilation success Compilation OK
ci/github-robot: build success github build: passed
ci/checkpatch warning coding style issues

Commit Message

Ashwin Sekhar Thalakalath Kottilveetil Sept. 17, 2021, 10:58 a.m. UTC
Update word list with Marvell specific acronyms.

CPT  -> Cryptographic Accelerator Unit
CQ   -> Completion Queue
LBK  -> Loopback Interface Unit
LMT  -> Large Atomic Store Unit
MCAM -> Match Content Addressable Memory
NIX  -> Network Interface Controller Unit
NPA  -> Network Pool Allocator
NPC  -> Network Parser and CAM Unit
ROC  -> Rest Of Chip
RQ   -> Receive Queue
RVU  -> Resource Virtualization Unit
SQ   -> Send Queue
SSO  -> Schedule Synchronize Order Unit
TIM  -> Timer Unit

Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>
---
 devtools/words-case.txt | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Jerin Jacob Sept. 17, 2021, 11:03 a.m. UTC | #1
On Fri, Sep 17, 2021 at 4:32 PM Ashwin Sekhar T K <asekhar@marvell.com> wrote:
>
> Update word list with Marvell specific acronyms.
>
> CPT  -> Cryptographic Accelerator Unit
> CQ   -> Completion Queue
> LBK  -> Loopback Interface Unit
> LMT  -> Large Atomic Store Unit
> MCAM -> Match Content Addressable Memory
> NIX  -> Network Interface Controller Unit
> NPA  -> Network Pool Allocator
> NPC  -> Network Parser and CAM Unit
> ROC  -> Rest Of Chip
> RQ   -> Receive Queue
> RVU  -> Resource Virtualization Unit
> SQ   -> Send Queue
> SSO  -> Schedule Synchronize Order Unit
> TIM  -> Timer Unit

Suggested-by: Ferruh Yigit <ferruh.yigit@intel.com>

> Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>

Reviewed-by: Jerin Jacob <jerinj@marvell.com>


> ---
>  devtools/words-case.txt | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/devtools/words-case.txt b/devtools/words-case.txt
> index 0bbad48626..0ea23689f0 100644
> --- a/devtools/words-case.txt
> +++ b/devtools/words-case.txt
> @@ -6,6 +6,8 @@ Arm
>  armv7
>  armv8
>  BAR
> +CPT
> +CQ
>  CRC
>  DCB
>  DevX
> @@ -33,10 +35,13 @@ L2
>  L3
>  L4
>  LACP
> +LBK
>  Linux
> +LMT
>  LRO
>  LSC
>  MAC
> +MCAM
>  MPLS
>  MSI
>  MSI-X
> @@ -44,6 +49,9 @@ MSS
>  MTU
>  NEON
>  NIC
> +NIX
> +NPA
> +NPC
>  null
>  NUMA
>  NVGRE
> @@ -57,15 +65,21 @@ PVID
>  QinQ
>  RDMA
>  RETA
> +ROC
> +RQ
>  RSS
> +RVU
>  Rx
>  SCTP
>  SMP
>  SoC
> +SQ
> +SSO
>  SW
>  TC
>  TCAM
>  Thor
> +TIM
>  TOS
>  TPID
>  TSO
> --
> 2.32.0
>
Thomas Monjalon Sept. 17, 2021, 12:55 p.m. UTC | #2
17/09/2021 12:58, Ashwin Sekhar T K:
> Update word list with Marvell specific acronyms.
> 
> CPT  -> Cryptographic Accelerator Unit
> CQ   -> Completion Queue
> LBK  -> Loopback Interface Unit
> LMT  -> Large Atomic Store Unit

How LMT means that?

> MCAM -> Match Content Addressable Memory

Is it specific to a device?

> NIX  -> Network Interface Controller Unit

Where is it used? Is it different of NIC?

> NPA  -> Network Pool Allocator
> NPC  -> Network Parser and CAM Unit
> ROC  -> Rest Of Chip

All these stuff look device-specific. Please add details.

> RQ   -> Receive Queue
> RVU  -> Resource Virtualization Unit
> SQ   -> Send Queue
> SSO  -> Schedule Synchronize Order Unit
> TIM  -> Timer Unit
Ashwin Sekhar Thalakalath Kottilveetil Sept. 17, 2021, 1:54 p.m. UTC | #3
Please see other comments inline.

Ashwin Sekhar T K 

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Friday, September 17, 2021 6:26 PM
> To: Ashwin Sekhar Thalakalath Kottilveetil <asekhar@marvell.com>
> Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Sunil
> Kumar Kori <skori@marvell.com>; Satha Koteswara Rao Kottidi
> <skoteshwar@marvell.com>; Pavan Nikhilesh Bhagavatula
> <pbhagavatula@marvell.com>; Kiran Kumar Kokkilagadda
> <kirankumark@marvell.com>; Satheesh Paul <psatheesh@marvell.com>;
> Ashwin Sekhar Thalakalath Kottilveetil <asekhar@marvell.com>; Anoob
> Joseph <anoobj@marvell.com>; Akhil Goyal <gakhil@marvell.com>;
> ferruh.yigit@intel.com; david.marchand@redhat.com
> Subject: [EXT] Re: [PATCH v3] devtools: add acronyms in dictionary for
> commit checks
> 
> External Email
> 
> ----------------------------------------------------------------------
> 17/09/2021 12:58, Ashwin Sekhar T K:
> > Update word list with Marvell specific acronyms.
> >
> > CPT  -> Cryptographic Accelerator Unit
> > CQ   -> Completion Queue
> > LBK  -> Loopback Interface Unit
> > LMT  -> Large Atomic Store Unit
> 
> How LMT means that?
LMT is how the Large Atomic Store Unit in the CNXK devices is referred to as.
It will be difficult to put a 1:1 mapping between the letters and actual
names.
> 
> > MCAM -> Match Content Addressable Memory
> 
> Is it specific to a device?
This is specific to Marvell CNXK devices.
> 
> > NIX  -> Network Interface Controller Unit
> 
> Where is it used? Is it different of NIC?
It is used throughout the CNXK driver code (drivers/net/cnxk). This is not same as
NIC.
> 
> > NPA  -> Network Pool Allocator
> > NPC  -> Network Parser and CAM Unit
> > ROC  -> Rest Of Chip
> 
> All these stuff look device-specific. Please add details.
Please suggest where to add details. 
> 
> > RQ   -> Receive Queue
> > RVU  -> Resource Virtualization Unit
> > SQ   -> Send Queue
> > SSO  -> Schedule Synchronize Order Unit TIM  -> Timer Unit
> 
> 
> 
>
Thomas Monjalon Sept. 17, 2021, 2:05 p.m. UTC | #4
17/09/2021 15:54, Ashwin Sekhar Thalakalath Kottilveetil:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 17/09/2021 12:58, Ashwin Sekhar T K:
> > > Update word list with Marvell specific acronyms.
> > >
> > > CPT  -> Cryptographic Accelerator Unit
> > > CQ   -> Completion Queue
> > > LBK  -> Loopback Interface Unit
> > > LMT  -> Large Atomic Store Unit
> > 
> > How LMT means that?
> LMT is how the Large Atomic Store Unit in the CNXK devices is referred to as.
> It will be difficult to put a 1:1 mapping between the letters and actual
> names.
> > 
> > > MCAM -> Match Content Addressable Memory
> > 
> > Is it specific to a device?
> This is specific to Marvell CNXK devices.
> > 
> > > NIX  -> Network Interface Controller Unit
> > 
> > Where is it used? Is it different of NIC?
> It is used throughout the CNXK driver code (drivers/net/cnxk). This is not same as
> NIC.
> > 
> > > NPA  -> Network Pool Allocator
> > > NPC  -> Network Parser and CAM Unit
> > > ROC  -> Rest Of Chip
> > 
> > All these stuff look device-specific. Please add details.
> Please suggest where to add details. 
> > 
> > > RQ   -> Receive Queue
> > > RVU  -> Resource Virtualization Unit
> > > SQ   -> Send Queue
> > > SSO  -> Schedule Synchronize Order Unit TIM  -> Timer Unit

Please add details in the commit log so we understand they are Marvell acronyms.

One more question: why is useful to add? Some people forget uppercases?
Ashwin Sekhar Thalakalath Kottilveetil Sept. 17, 2021, 2:53 p.m. UTC | #5
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Friday, September 17, 2021 7:35 PM
> To: Ashwin Sekhar Thalakalath Kottilveetil <asekhar@marvell.com>
> Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Sunil
> Kumar Kori <skori@marvell.com>; Satha Koteswara Rao Kottidi
> <skoteshwar@marvell.com>; Pavan Nikhilesh Bhagavatula
> <pbhagavatula@marvell.com>; Kiran Kumar Kokkilagadda
> <kirankumark@marvell.com>; Satheesh Paul <psatheesh@marvell.com>;
> Anoob Joseph <anoobj@marvell.com>; Akhil Goyal <gakhil@marvell.com>;
> ferruh.yigit@intel.com; david.marchand@redhat.com
> Subject: Re: [EXT] Re: [PATCH v3] devtools: add acronyms in dictionary for
> commit checks
> 
> 17/09/2021 15:54, Ashwin Sekhar Thalakalath Kottilveetil:
> > From: Thomas Monjalon <thomas@monjalon.net>
> > > 17/09/2021 12:58, Ashwin Sekhar T K:
> > > > Update word list with Marvell specific acronyms.
> > > >
> > > > CPT  -> Cryptographic Accelerator Unit
> > > > CQ   -> Completion Queue
> > > > LBK  -> Loopback Interface Unit
> > > > LMT  -> Large Atomic Store Unit
> > >
> > > How LMT means that?
> > LMT is how the Large Atomic Store Unit in the CNXK devices is referred to
> as.
> > It will be difficult to put a 1:1 mapping between the letters and
> > actual names.
> > >
> > > > MCAM -> Match Content Addressable Memory
> > >
> > > Is it specific to a device?
> > This is specific to Marvell CNXK devices.
> > >
> > > > NIX  -> Network Interface Controller Unit
> > >
> > > Where is it used? Is it different of NIC?
> > It is used throughout the CNXK driver code (drivers/net/cnxk). This is
> > not same as NIC.
> > >
> > > > NPA  -> Network Pool Allocator
> > > > NPC  -> Network Parser and CAM Unit ROC  -> Rest Of Chip
> > >
> > > All these stuff look device-specific. Please add details.
> > Please suggest where to add details.
> > >
> > > > RQ   -> Receive Queue
> > > > RVU  -> Resource Virtualization Unit
> > > > SQ   -> Send Queue
> > > > SSO  -> Schedule Synchronize Order Unit TIM  -> Timer Unit
> 
> Please add details in the commit log so we understand they are Marvell
> acronyms.
Commit log already mentions these are Marvell specific acronyms. I did not
add explanation for each of them as this would make the message too long.
> 
> One more question: why is useful to add? Some people forget uppercases?
Upper case is desired but not really mandatory. This was a suggestion put
forth to me In one of the reviews.
https://patches.dpdk.org/project/dpdk/patch/20210830135231.2610152-1-asekhar@marvell.com/

I can abandon this change if you feel it is not appropriate to put many
device specific acronyms in the top level word list.
> 
> 
>
Thomas Monjalon Sept. 17, 2021, 4:15 p.m. UTC | #6
17/09/2021 16:53, Ashwin Sekhar Thalakalath Kottilveetil:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 17/09/2021 15:54, Ashwin Sekhar Thalakalath Kottilveetil:
> > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > 17/09/2021 12:58, Ashwin Sekhar T K:
> > > > > Update word list with Marvell specific acronyms.
[...]
> > Please add details in the commit log so we understand they are Marvell
> > acronyms.
> Commit log already mentions these are Marvell specific acronyms. I did not
> add explanation for each of them as this would make the message too long.

Oh yes, I missed it, sorry.

> > One more question: why is useful to add? Some people forget uppercases?
> 
> Upper case is desired but not really mandatory. This was a suggestion put
> forth to me In one of the reviews.
> https://patches.dpdk.org/project/dpdk/patch/20210830135231.2610152-1-asekhar@marvell.com/
> 
> I can abandon this change if you feel it is not appropriate to put many
> device specific acronyms in the top level word list.

No strong opinion, but I think the patch is OK.
David, Ferruh, opinions?
Ferruh Yigit Sept. 20, 2021, 9:05 a.m. UTC | #7
On 9/17/2021 5:15 PM, Thomas Monjalon wrote:
> 17/09/2021 16:53, Ashwin Sekhar Thalakalath Kottilveetil:
>> From: Thomas Monjalon <thomas@monjalon.net>
>>> 17/09/2021 15:54, Ashwin Sekhar Thalakalath Kottilveetil:
>>>> From: Thomas Monjalon <thomas@monjalon.net>
>>>>> 17/09/2021 12:58, Ashwin Sekhar T K:
>>>>>> Update word list with Marvell specific acronyms.
> [...]
>>> Please add details in the commit log so we understand they are Marvell
>>> acronyms.
>> Commit log already mentions these are Marvell specific acronyms. I did not
>> add explanation for each of them as this would make the message too long.
> 
> Oh yes, I missed it, sorry.
> 
>>> One more question: why is useful to add? Some people forget uppercases?
>>
>> Upper case is desired but not really mandatory. This was a suggestion put
>> forth to me In one of the reviews.
>> https://patches.dpdk.org/project/dpdk/patch/20210830135231.2610152-1-asekhar@marvell.com/
>>
>> I can abandon this change if you feel it is not appropriate to put many
>> device specific acronyms in the top level word list.
> 
> No strong opinion, but I think the patch is OK.
> David, Ferruh, opinions?
> 

Yes this is suggested to be sure acronyms are uppercase in the patch title.

But if an issue can be described in generic concepts, I am for using them to
instead of using device specific acronyms, to make commit logs less cryptic.
Like 'NIC' should be used instead of 'NIX'.

Similarly we can try to use long version of CQ/SQ/RQ, although we may need to
use them because of limited title length time to time.

Rest seems device specific abbreviations we may not escape to use them, so they
are OK to me.
Ferruh Yigit Sept. 20, 2021, 9:07 a.m. UTC | #8
On 9/17/2021 11:58 AM, Ashwin Sekhar T K wrote:
> Update word list with Marvell specific acronyms.
> 
> CPT  -> Cryptographic Accelerator Unit
> CQ   -> Completion Queue
> LBK  -> Loopback Interface Unit
> LMT  -> Large Atomic Store Unit
> MCAM -> Match Content Addressable Memory
> NIX  -> Network Interface Controller Unit
> NPA  -> Network Pool Allocator
> NPC  -> Network Parser and CAM Unit
> ROC  -> Rest Of Chip

Out of curiosity, what is "rest of chip"?

> RQ   -> Receive Queue
> RVU  -> Resource Virtualization Unit
> SQ   -> Send Queue
> SSO  -> Schedule Synchronize Order Unit
> TIM  -> Timer Unit
> 
> Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>
Jerin Jacob Sept. 20, 2021, 9:10 a.m. UTC | #9
On Mon, Sep 20, 2021 at 2:37 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 9/17/2021 11:58 AM, Ashwin Sekhar T K wrote:
> > Update word list with Marvell specific acronyms.
> >
> > CPT  -> Cryptographic Accelerator Unit
> > CQ   -> Completion Queue
> > LBK  -> Loopback Interface Unit
> > LMT  -> Large Atomic Store Unit
> > MCAM -> Match Content Addressable Memory
> > NIX  -> Network Interface Controller Unit
> > NPA  -> Network Pool Allocator
> > NPC  -> Network Parser and CAM Unit
> > ROC  -> Rest Of Chip
>
> Out of curiosity, what is "rest of chip"?

All the HW accelerators excluding the CPU cores.

>
> > RQ   -> Receive Queue
> > RVU  -> Resource Virtualization Unit
> > SQ   -> Send Queue
> > SSO  -> Schedule Synchronize Order Unit
> > TIM  -> Timer Unit
> >
> > Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>
>
Ashwin Sekhar Thalakalath Kottilveetil Sept. 20, 2021, 9:19 a.m. UTC | #10
> > Oh yes, I missed it, sorry.
> >
> >>> One more question: why is useful to add? Some people forget
> uppercases?
> >>
> >> Upper case is desired but not really mandatory. This was a suggestion
> >> put forth to me In one of the reviews.
> >> https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__patches.dpdk.org
> >> _project_dpdk_patch_20210830135231.2610152-2D1-2Dasekhar-
> 40marvell.co
> >> m_&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=pYk-QOhvnkU-
> _75y0NKSn535ZotEGI
> >> _E69Py3Ppondk&m=tCLT4AyWr6-
> VYmqkdbD879kj0uDFhCqF6jjOWfe8Dn4&s=EWthslG
> >> Cy_OWH4bqcOEKKkweFTe4yHZ-2O5yqiKp39w&e=
> >>
> >> I can abandon this change if you feel it is not appropriate to put
> >> many device specific acronyms in the top level word list.
> >
> > No strong opinion, but I think the patch is OK.
> > David, Ferruh, opinions?
> >
> 
> Yes this is suggested to be sure acronyms are uppercase in the patch title.
> 
> But if an issue can be described in generic concepts, I am for using them to
> instead of using device specific acronyms, to make commit logs less cryptic.
Agree that certain commit logs could be re-worded and put in more
generic terms.

> Like 'NIC' should be used instead of 'NIX'.
But NIX and NIC are not exactly interchangeable. NIX refers to a co-processor.
NIX in conjunction with other co-processors (NPA, LMT etc.) delivers the
functionality of a NIC.

> 
> Similarly we can try to use long version of CQ/SQ/RQ, although we may need
> to use them because of limited title length time to time.
> 
> Rest seems device specific abbreviations we may not escape to use them, so
> they are OK to me.
Ashwin Sekhar Thalakalath Kottilveetil Sept. 20, 2021, 9:21 a.m. UTC | #11
> On 9/17/2021 11:58 AM, Ashwin Sekhar T K wrote:
> > Update word list with Marvell specific acronyms.
> >
> > CPT  -> Cryptographic Accelerator Unit
> > CQ   -> Completion Queue
> > LBK  -> Loopback Interface Unit
> > LMT  -> Large Atomic Store Unit
> > MCAM -> Match Content Addressable Memory NIX  -> Network Interface
> > Controller Unit NPA  -> Network Pool Allocator NPC  -> Network Parser
> > and CAM Unit ROC  -> Rest Of Chip
> 
> Out of curiosity, what is "rest of chip"?
Anything which is non-CPU. Co-processors like NPA, NIX, etc. are collectively
referred to as ROC.
> 
> > RQ   -> Receive Queue
> > RVU  -> Resource Virtualization Unit
> > SQ   -> Send Queue
> > SSO  -> Schedule Synchronize Order Unit TIM  -> Timer Unit
> >
> > Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>
Ferruh Yigit Sept. 20, 2021, 10:31 a.m. UTC | #12
On 9/20/2021 10:19 AM, Ashwin Sekhar Thalakalath Kottilveetil wrote:
>>> Oh yes, I missed it, sorry.
>>>
>>>>> One more question: why is useful to add? Some people forget
>> uppercases?
>>>>
>>>> Upper case is desired but not really mandatory. This was a suggestion
>>>> put forth to me In one of the reviews.
>>>> https://urldefense.proofpoint.com/v2/url?u=https-
>> 3A__patches.dpdk.org
>>>> _project_dpdk_patch_20210830135231.2610152-2D1-2Dasekhar-
>> 40marvell.co
>>>> m_&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=pYk-QOhvnkU-
>> _75y0NKSn535ZotEGI
>>>> _E69Py3Ppondk&m=tCLT4AyWr6-
>> VYmqkdbD879kj0uDFhCqF6jjOWfe8Dn4&s=EWthslG
>>>> Cy_OWH4bqcOEKKkweFTe4yHZ-2O5yqiKp39w&e=
>>>>
>>>> I can abandon this change if you feel it is not appropriate to put
>>>> many device specific acronyms in the top level word list.
>>>
>>> No strong opinion, but I think the patch is OK.
>>> David, Ferruh, opinions?
>>>
>>
>> Yes this is suggested to be sure acronyms are uppercase in the patch title.
>>
>> But if an issue can be described in generic concepts, I am for using them to
>> instead of using device specific acronyms, to make commit logs less cryptic.
> Agree that certain commit logs could be re-worded and put in more
> generic terms.
> 
>> Like 'NIC' should be used instead of 'NIX'.
> But NIX and NIC are not exactly interchangeable. NIX refers to a co-processor.
> NIX in conjunction with other co-processors (NPA, LMT etc.) delivers the
> functionality of a NIC.
> 

Got it, my bad, I understood they are same. OK to keep it.

>>
>> Similarly we can try to use long version of CQ/SQ/RQ, although we may need
>> to use them because of limited title length time to time.
>>
>> Rest seems device specific abbreviations we may not escape to use them, so
>> they are OK to me.
>
Ferruh Yigit Sept. 20, 2021, 10:32 a.m. UTC | #13
On 9/20/2021 10:10 AM, Jerin Jacob wrote:
> On Mon, Sep 20, 2021 at 2:37 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>
>> On 9/17/2021 11:58 AM, Ashwin Sekhar T K wrote:
>>> Update word list with Marvell specific acronyms.
>>>
>>> CPT  -> Cryptographic Accelerator Unit
>>> CQ   -> Completion Queue
>>> LBK  -> Loopback Interface Unit
>>> LMT  -> Large Atomic Store Unit
>>> MCAM -> Match Content Addressable Memory
>>> NIX  -> Network Interface Controller Unit
>>> NPA  -> Network Pool Allocator
>>> NPC  -> Network Parser and CAM Unit
>>> ROC  -> Rest Of Chip
>>
>> Out of curiosity, what is "rest of chip"?
> 
> All the HW accelerators excluding the CPU cores.
> 

Thanks.

>>
>>> RQ   -> Receive Queue
>>> RVU  -> Resource Virtualization Unit
>>> SQ   -> Send Queue
>>> SSO  -> Schedule Synchronize Order Unit
>>> TIM  -> Timer Unit
>>>
>>> Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>
>>
Ferruh Yigit Nov. 3, 2021, 4:44 p.m. UTC | #14
On 9/20/2021 11:32 AM, Ferruh Yigit wrote:
> On 9/20/2021 10:10 AM, Jerin Jacob wrote:
>> On Mon, Sep 20, 2021 at 2:37 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>>
>>> On 9/17/2021 11:58 AM, Ashwin Sekhar T K wrote:
>>>> Update word list with Marvell specific acronyms.
>>>>
>>>> CPT  -> Cryptographic Accelerator Unit
>>>> CQ   -> Completion Queue
>>>> LBK  -> Loopback Interface Unit
>>>> LMT  -> Large Atomic Store Unit
>>>> MCAM -> Match Content Addressable Memory
>>>> NIX  -> Network Interface Controller Unit
>>>> NPA  -> Network Pool Allocator
>>>> NPC  -> Network Parser and CAM Unit
>>>> ROC  -> Rest Of Chip
>>>
>>> Out of curiosity, what is "rest of chip"?
>>
>> All the HW accelerators excluding the CPU cores.
>>
> 
> Thanks.
> 
>>>
>>>> RQ   -> Receive Queue
>>>> RVU  -> Resource Virtualization Unit
>>>> SQ   -> Send Queue
>>>> SSO  -> Schedule Synchronize Order Unit
>>>> TIM  -> Timer Unit
>>>>
>>>> Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>
>>>
> 

Hi David, Thomas,

Can we proceed with this patch if there is no more objection?

There are multiple 'cnxk' patches are using these acronyms,
it would be good the have them checked.
(Although I suspect Jerin already have the patch locally,
since there is no missuses in sent patches.)

patchwork:
https://patches.dpdk.org/project/dpdk/patch/20210917105839.270289-1-asekhar@marvell.com/
Thomas Monjalon Nov. 25, 2021, 11:30 a.m. UTC | #15
17/09/2021 13:03, Jerin Jacob:
> On Fri, Sep 17, 2021 at 4:32 PM Ashwin Sekhar T K <asekhar@marvell.com> wrote:
> >
> > Update word list with Marvell specific acronyms.
> >
> > CPT  -> Cryptographic Accelerator Unit
> > CQ   -> Completion Queue
> > LBK  -> Loopback Interface Unit
> > LMT  -> Large Atomic Store Unit
> > MCAM -> Match Content Addressable Memory
> > NIX  -> Network Interface Controller Unit
> > NPA  -> Network Pool Allocator
> > NPC  -> Network Parser and CAM Unit
> > ROC  -> Rest Of Chip
> > RQ   -> Receive Queue
> > RVU  -> Resource Virtualization Unit
> > SQ   -> Send Queue
> > SSO  -> Schedule Synchronize Order Unit
> > TIM  -> Timer Unit
> 
> Suggested-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> > Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>
> 
> Reviewed-by: Jerin Jacob <jerinj@marvell.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/devtools/words-case.txt b/devtools/words-case.txt
index 0bbad48626..0ea23689f0 100644
--- a/devtools/words-case.txt
+++ b/devtools/words-case.txt
@@ -6,6 +6,8 @@  Arm
 armv7
 armv8
 BAR
+CPT
+CQ
 CRC
 DCB
 DevX
@@ -33,10 +35,13 @@  L2
 L3
 L4
 LACP
+LBK
 Linux
+LMT
 LRO
 LSC
 MAC
+MCAM
 MPLS
 MSI
 MSI-X
@@ -44,6 +49,9 @@  MSS
 MTU
 NEON
 NIC
+NIX
+NPA
+NPC
 null
 NUMA
 NVGRE
@@ -57,15 +65,21 @@  PVID
 QinQ
 RDMA
 RETA
+ROC
+RQ
 RSS
+RVU
 Rx
 SCTP
 SMP
 SoC
+SQ
+SSO
 SW
 TC
 TCAM
 Thor
+TIM
 TOS
 TPID
 TSO