[v5,15/16] devbind: add dma device class
Checks
Commit Message
Add a new class for DMA devices. Devices listed under the DMA class are to
be used with the dmadev library.
Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
Reviewed-by: Conor Walsh <conor.walsh@intel.com>
---
usertools/dpdk-devbind.py | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
Comments
On Fri, Sep 17, 2021 at 03:24:36PM +0000, Kevin Laatz wrote:
> Add a new class for DMA devices. Devices listed under the DMA class are to
> be used with the dmadev library.
>
> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> Reviewed-by: Conor Walsh <conor.walsh@intel.com>
> ---
One small comment below to be fixed.
Reviewed-by: Bruce Richardson <bruce.richardson@intel.com>
> usertools/dpdk-devbind.py | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
> index 74d16e4c4b..8bb573f4b0 100755
> --- a/usertools/dpdk-devbind.py
> +++ b/usertools/dpdk-devbind.py
> @@ -69,12 +69,13 @@
> network_devices = [network_class, cavium_pkx, avp_vnic, ifpga_class]
> baseband_devices = [acceleration_class]
> crypto_devices = [encryption_class, intel_processor_class]
> +dma_devices = []
> eventdev_devices = [cavium_sso, cavium_tim, intel_dlb, octeontx2_sso]
> mempool_devices = [cavium_fpa, octeontx2_npa]
> compress_devices = [cavium_zip]
> regex_devices = [octeontx2_ree]
> -misc_devices = [cnxk_bphy, cnxk_bphy_cgx, intel_ioat_bdw, intel_ioat_skx, intel_ioat_icx, intel_idxd_spr,
> - intel_ntb_skx, intel_ntb_icx,
> +misc_devices = [cnxk_bphy, cnxk_bphy_cgx, intel_ioat_bdw, intel_ioat_skx,
> + intel_ioat_icx, intel_idxd_spr, intel_ntb_skx, intel_ntb_icx,
This looks a purely cosmetic change, which doesn't really below in the
patch - especially since a number of these entries are to move in later
patches for 21.11.
/Bruce
Reviewed-by: Chengwen Feng <fengchengwen@huawei.com>
On 2021/9/17 23:24, Kevin Laatz wrote:
> Add a new class for DMA devices. Devices listed under the DMA class are to
> be used with the dmadev library.
>
> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> Reviewed-by: Conor Walsh <conor.walsh@intel.com>
> ---
> usertools/dpdk-devbind.py | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
> index 74d16e4c4b..8bb573f4b0 100755
> --- a/usertools/dpdk-devbind.py
> +++ b/usertools/dpdk-devbind.py
> @@ -69,12 +69,13 @@
> network_devices = [network_class, cavium_pkx, avp_vnic, ifpga_class]
> baseband_devices = [acceleration_class]
> crypto_devices = [encryption_class, intel_processor_class]
> +dma_devices = []
> eventdev_devices = [cavium_sso, cavium_tim, intel_dlb, octeontx2_sso]
> mempool_devices = [cavium_fpa, octeontx2_npa]
> compress_devices = [cavium_zip]
> regex_devices = [octeontx2_ree]
> -misc_devices = [cnxk_bphy, cnxk_bphy_cgx, intel_ioat_bdw, intel_ioat_skx, intel_ioat_icx, intel_idxd_spr,
> - intel_ntb_skx, intel_ntb_icx,
> +misc_devices = [cnxk_bphy, cnxk_bphy_cgx, intel_ioat_bdw, intel_ioat_skx,
> + intel_ioat_icx, intel_idxd_spr, intel_ntb_skx, intel_ntb_icx,
> octeontx2_dma]
>
> # global dict ethernet devices present. Dictionary indexed by PCI address.
> @@ -583,6 +584,9 @@ def show_status():
> if status_dev in ["crypto", "all"]:
> show_device_status(crypto_devices, "Crypto")
>
> + if status_dev in ["dma", "all"]:
> + show_device_status(dma_devices, "DMA")
> +
> if status_dev in ["event", "all"]:
> show_device_status(eventdev_devices, "Eventdev")
>
> @@ -651,7 +655,7 @@ def parse_args():
> parser.add_argument(
> '--status-dev',
> help="Print the status of given device group.",
> - choices=['baseband', 'compress', 'crypto', 'event',
> + choices=['baseband', 'compress', 'crypto', 'dma', 'event',
> 'mempool', 'misc', 'net', 'regex'])
> bind_group = parser.add_mutually_exclusive_group()
> bind_group.add_argument(
> @@ -732,6 +736,7 @@ def do_arg_actions():
> get_device_details(network_devices)
> get_device_details(baseband_devices)
> get_device_details(crypto_devices)
> + get_device_details(dma_devices)
> get_device_details(eventdev_devices)
> get_device_details(mempool_devices)
> get_device_details(compress_devices)
> @@ -754,6 +759,7 @@ def main():
> get_device_details(network_devices)
> get_device_details(baseband_devices)
> get_device_details(crypto_devices)
> + get_device_details(dma_devices)
> get_device_details(eventdev_devices)
> get_device_details(mempool_devices)
> get_device_details(compress_devices)
>
@@ -69,12 +69,13 @@
network_devices = [network_class, cavium_pkx, avp_vnic, ifpga_class]
baseband_devices = [acceleration_class]
crypto_devices = [encryption_class, intel_processor_class]
+dma_devices = []
eventdev_devices = [cavium_sso, cavium_tim, intel_dlb, octeontx2_sso]
mempool_devices = [cavium_fpa, octeontx2_npa]
compress_devices = [cavium_zip]
regex_devices = [octeontx2_ree]
-misc_devices = [cnxk_bphy, cnxk_bphy_cgx, intel_ioat_bdw, intel_ioat_skx, intel_ioat_icx, intel_idxd_spr,
- intel_ntb_skx, intel_ntb_icx,
+misc_devices = [cnxk_bphy, cnxk_bphy_cgx, intel_ioat_bdw, intel_ioat_skx,
+ intel_ioat_icx, intel_idxd_spr, intel_ntb_skx, intel_ntb_icx,
octeontx2_dma]
# global dict ethernet devices present. Dictionary indexed by PCI address.
@@ -583,6 +584,9 @@ def show_status():
if status_dev in ["crypto", "all"]:
show_device_status(crypto_devices, "Crypto")
+ if status_dev in ["dma", "all"]:
+ show_device_status(dma_devices, "DMA")
+
if status_dev in ["event", "all"]:
show_device_status(eventdev_devices, "Eventdev")
@@ -651,7 +655,7 @@ def parse_args():
parser.add_argument(
'--status-dev',
help="Print the status of given device group.",
- choices=['baseband', 'compress', 'crypto', 'event',
+ choices=['baseband', 'compress', 'crypto', 'dma', 'event',
'mempool', 'misc', 'net', 'regex'])
bind_group = parser.add_mutually_exclusive_group()
bind_group.add_argument(
@@ -732,6 +736,7 @@ def do_arg_actions():
get_device_details(network_devices)
get_device_details(baseband_devices)
get_device_details(crypto_devices)
+ get_device_details(dma_devices)
get_device_details(eventdev_devices)
get_device_details(mempool_devices)
get_device_details(compress_devices)
@@ -754,6 +759,7 @@ def main():
get_device_details(network_devices)
get_device_details(baseband_devices)
get_device_details(crypto_devices)
+ get_device_details(dma_devices)
get_device_details(eventdev_devices)
get_device_details(mempool_devices)
get_device_details(compress_devices)