From patchwork Fri Sep 24 15:57:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Olivier Matz X-Patchwork-Id: 99639 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5736A0548; Fri, 24 Sep 2021 17:58:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8239F41356; Fri, 24 Sep 2021 17:58:13 +0200 (CEST) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by mails.dpdk.org (Postfix) with ESMTP id 75ACE4132B for ; Fri, 24 Sep 2021 17:58:09 +0200 (CEST) Received: by mail-wr1-f49.google.com with SMTP id r23so3567281wra.6 for ; Fri, 24 Sep 2021 08:58:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=H9CfQdlzO2MAaTjpsalAe97t1CMRfElsAxkb3P1z/BU=; b=WfokmZFBPlTo9NYwGLE8xzCH8FAFomjEHjVlg7P5JQZb2NmZTd7IRQX/JDCcsUAasf 5QsCnU5t3VslodmmiXypiN49ymp+0NyhbgmVwIfewL9M9O89m/LXIaByKfnONhgbtMw8 oidebeCeX9TpaIr1DtPV0xyNL8v7IwnBXGdt7SS/N3WP5L2VGV9zQqFE4LDj/yaQKTHA WTgwxMQ8MgU9Gvikw9Ho3PXLdU5WPzYk0vCJ3if3XRlItf/cTTMalnLkxOHdBLOAaVTl 8VXHZKt57+XqfF4WG+NFPqYX027juwTrP5bzgaOH0q3xZroQrmZxwU4x6oVV9Dn94TNM gjHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=H9CfQdlzO2MAaTjpsalAe97t1CMRfElsAxkb3P1z/BU=; b=6TpOkbUSKnmYmP7iExSNiGmNBispJv/gRUArcAxgCavWLX73UDTR9gWbL/lm5FQjDK cgheioZ9w+sp5xyUE/aWjNa9gDiJSNHGvsiFkPUKUmKXNKJG1Sh55cb2oEueHzdEpk05 gLop8r9wteOvDMQUzXuUA5HHS0aGWuh59ZmFVQs+IlDHG25LA8v92p1Pg8eDp6hYEnrj g4QtBuKpehgNsYo8ajNRJ+R5t9VgHZCcGpMWqQ4xw3dPPMJ7M1eXyGG8d+K+7XD7omWk Fb5H403x8fFDKfoWjUO845s9wftwVH7opNNepb706SM7CNnLZMYrIEwncgGFpeCzh+tc dIfg== X-Gm-Message-State: AOAM531aTJ5/8UemD24allSKw/JcR7ZF90V7lyngo3zYEL99Rg50YxZK v08yv8gvy23rhbGJY/UrajthjSLUHYyH4g== X-Google-Smtp-Source: ABdhPJxzz88VB3QT4pD1mnktNFgrrLkDiKKbWjMnDOPjaXdyOJGHMQxMZl2bewuiNMlBnhcrJu2liw== X-Received: by 2002:a05:600c:499a:: with SMTP id h26mr2814526wmp.164.1632499089301; Fri, 24 Sep 2021 08:58:09 -0700 (PDT) Received: from gojira.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id a75sm9280829wmd.4.2021.09.24.08.58.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Sep 2021 08:58:08 -0700 (PDT) From: Olivier Matz To: dev@dpdk.org Cc: Olivier Matz , Bruce Richardson , Xueming Li , Gaetan Rivet , Ray Kinsella Date: Fri, 24 Sep 2021 17:57:39 +0200 Message-Id: <20210924155740.20510-5-olivier.matz@6wind.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210924155740.20510-1-olivier.matz@6wind.com> References: <20210924155740.20510-1-olivier.matz@6wind.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 4/5] kvargs: remove experimental function to compare string X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The function was designed to be used as a handler for rte_kvargs_process() to compare the value string in a kvlist. For readability, its usages in DPDK have been replaced by rte_kvargs_get_with_value() in previous commit. Remove this function, as it is not used anymore. Signed-off-by: Olivier Matz --- lib/kvargs/rte_kvargs.c | 9 --------- lib/kvargs/rte_kvargs.h | 26 -------------------------- 2 files changed, 35 deletions(-) diff --git a/lib/kvargs/rte_kvargs.c b/lib/kvargs/rte_kvargs.c index 20abb23183..11f624ef14 100644 --- a/lib/kvargs/rte_kvargs.c +++ b/lib/kvargs/rte_kvargs.c @@ -283,12 +283,3 @@ rte_kvargs_parse_delim(const char *args, const char * const valid_keys[], free(copy); return kvlist; } - -int -rte_kvargs_strcmp(const char *key __rte_unused, - const char *value, void *opaque) -{ - const char *str = opaque; - - return -abs(strcmp(str, value)); -} diff --git a/lib/kvargs/rte_kvargs.h b/lib/kvargs/rte_kvargs.h index e40df1bd2a..3c1754c3d9 100644 --- a/lib/kvargs/rte_kvargs.h +++ b/lib/kvargs/rte_kvargs.h @@ -197,32 +197,6 @@ int rte_kvargs_process(const struct rte_kvargs *kvlist, unsigned rte_kvargs_count(const struct rte_kvargs *kvlist, const char *key_match); -/** - * Generic kvarg handler for string comparison. - * - * This function can be used for a generic string comparison processing - * on a list of kvargs. - * - * @param key - * kvarg pair key. - * - * @param value - * kvarg pair value. - * - * @param opaque - * Opaque pointer to a string. - * - * @return - * 0 if the strings match. - * !0 otherwise or on error. - * - * Unlike strcmp, comparison ordering is not kept. - * In order for rte_kvargs_process to stop processing on match error, - * a negative value is returned even if strcmp had returned a positive one. - */ -__rte_experimental -int rte_kvargs_strcmp(const char *key, const char *value, void *opaque); - #ifdef __cplusplus } #endif