mbuf: remove deprecated bad outer IPv4 checksum flag on Rx
Checks
Commit Message
Removed offload flag PKT_RX_EIP_CKSUM_BAD. PKT_RX_OUTER_IP_CKSUM_BAD
should be used as a replacement.
Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
---
doc/guides/rel_notes/deprecation.rst | 7 +------
doc/guides/rel_notes/release_21_11.rst | 3 +++
lib/mbuf/rte_mbuf_core.h | 7 -------
3 files changed, 4 insertions(+), 13 deletions(-)
Comments
Hi Andrew,
On Wed, Sep 29, 2021 at 10:37:34AM +0300, Andrew Rybchenko wrote:
> Removed offload flag PKT_RX_EIP_CKSUM_BAD. PKT_RX_OUTER_IP_CKSUM_BAD
> should be used as a replacement.
>
> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
FYI, I just submitted a patchset that removes all PKT_ flags and
fixes the namespace. I will rebase it on top of your patch.
> ---
> doc/guides/rel_notes/deprecation.rst | 7 +------
> doc/guides/rel_notes/release_21_11.rst | 3 +++
> lib/mbuf/rte_mbuf_core.h | 7 -------
> 3 files changed, 4 insertions(+), 13 deletions(-)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 59445a6f42..3175426dad 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -42,7 +42,7 @@ Deprecation Notices
> * mbuf: The mbuf offload flags ``PKT_*`` will be renamed as ``RTE_MBUF_F_*``.
> A compatibility layer will be kept until DPDK 22.11, except for the flags
> that are already deprecated (``PKT_RX_L4_CKSUM_BAD``, ``PKT_RX_IP_CKSUM_BAD``,
> - ``PKT_RX_EIP_CKSUM_BAD``, ``PKT_TX_QINQ_PKT``) which will be removed.
> + ``PKT_RX_OUTER_IP_CKSUM_BAD``, ``PKT_TX_QINQ_PKT``) which will be removed.
>
I think this one should not be modified.
You can add my ack to the v2.
Thanks!
Olivier
Hi Olivier,
On 9/30/21 12:51 AM, Olivier Matz wrote:
> Hi Andrew,
>
> On Wed, Sep 29, 2021 at 10:37:34AM +0300, Andrew Rybchenko wrote:
>> Removed offload flag PKT_RX_EIP_CKSUM_BAD. PKT_RX_OUTER_IP_CKSUM_BAD
>> should be used as a replacement.
>>
>> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>
> FYI, I just submitted a patchset that removes all PKT_ flags and
> fixes the namespace. I will rebase it on top of your patch.
I'm sorry for inconvenience.
>> ---
>> doc/guides/rel_notes/deprecation.rst | 7 +------
>> doc/guides/rel_notes/release_21_11.rst | 3 +++
>> lib/mbuf/rte_mbuf_core.h | 7 -------
>> 3 files changed, 4 insertions(+), 13 deletions(-)
>>
>> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
>> index 59445a6f42..3175426dad 100644
>> --- a/doc/guides/rel_notes/deprecation.rst
>> +++ b/doc/guides/rel_notes/deprecation.rst
>> @@ -42,7 +42,7 @@ Deprecation Notices
>> * mbuf: The mbuf offload flags ``PKT_*`` will be renamed as ``RTE_MBUF_F_*``.
>> A compatibility layer will be kept until DPDK 22.11, except for the flags
>> that are already deprecated (``PKT_RX_L4_CKSUM_BAD``, ``PKT_RX_IP_CKSUM_BAD``,
>> - ``PKT_RX_EIP_CKSUM_BAD``, ``PKT_TX_QINQ_PKT``) which will be removed.
>> + ``PKT_RX_OUTER_IP_CKSUM_BAD``, ``PKT_TX_QINQ_PKT``) which will be removed.
>>
>
> I think this one should not be modified.
>
> You can add my ack to the v2.
Fixed in v2.
Thanks,
Andrew.
@@ -42,7 +42,7 @@ Deprecation Notices
* mbuf: The mbuf offload flags ``PKT_*`` will be renamed as ``RTE_MBUF_F_*``.
A compatibility layer will be kept until DPDK 22.11, except for the flags
that are already deprecated (``PKT_RX_L4_CKSUM_BAD``, ``PKT_RX_IP_CKSUM_BAD``,
- ``PKT_RX_EIP_CKSUM_BAD``, ``PKT_TX_QINQ_PKT``) which will be removed.
+ ``PKT_RX_OUTER_IP_CKSUM_BAD``, ``PKT_TX_QINQ_PKT``) which will be removed.
* pci: To reduce unnecessary ABIs exposed by DPDK bus driver, "rte_bus_pci.h"
will be made internal in 21.11 and macros/data structures/functions defined
@@ -159,11 +159,6 @@ Deprecation Notices
will be limited to maximum 256 queues.
Also compile time flag ``RTE_ETHDEV_QUEUE_STAT_CNTRS`` will be removed.
-* ethdev: The offload flag ``PKT_RX_EIP_CKSUM_BAD`` will be removed and
- replaced by the new flag ``PKT_RX_OUTER_IP_CKSUM_BAD``. The new name is more
- consistent with existing outer header checksum status flag naming, which
- should help in reducing confusion about its usage.
-
* i40e: As there are both i40evf and iavf pmd, the functions of them are
duplicated. And now more and more advanced features are developed on iavf.
To keep consistent with kernel driver's name
@@ -126,6 +126,9 @@ Removed Items
blacklist/whitelist are removed. Users must use the new
block/allow list arguments.
+* mbuf: Removed offload flag ``PKT_RX_EIP_CKSUM_BAD``.
+ ``PKT_RX_OUTER_IP_CKSUM_BAD`` should be used as a replacement.
+
API Changes
-----------
@@ -79,13 +79,6 @@ extern "C" {
*/
#define PKT_RX_OUTER_IP_CKSUM_BAD (1ULL << 5)
-/**
- * Deprecated.
- * This flag has been renamed, use PKT_RX_OUTER_IP_CKSUM_BAD instead.
- */
-#define PKT_RX_EIP_CKSUM_BAD \
- RTE_DEPRECATED(PKT_RX_EIP_CKSUM_BAD) PKT_RX_OUTER_IP_CKSUM_BAD
-
/**
* A vlan has been stripped by the hardware and its tci is saved in
* mbuf->vlan_tci. This can only happen if vlan stripping is enabled