From patchwork Wed Sep 29 07:37:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Rybchenko X-Patchwork-Id: 99975 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE6ECA0547; Wed, 29 Sep 2021 09:39:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E01D540E3C; Wed, 29 Sep 2021 09:39:18 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 0D0624068F for ; Wed, 29 Sep 2021 09:39:17 +0200 (CEST) Received: by shelob.oktetlabs.ru (Postfix, from userid 122) id B8DB07F6D0; Wed, 29 Sep 2021 10:39:16 +0300 (MSK) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shelob.oktetlabs.ru X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=ALL_TRUSTED, DKIM_ADSP_DISCARD, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from aros.oktetlabs.ru (aros.oktetlabs.ru [192.168.38.17]) by shelob.oktetlabs.ru (Postfix) with ESMTP id 1436C7F52E; Wed, 29 Sep 2021 10:39:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 1436C7F52E Authentication-Results: shelob.oktetlabs.ru/1436C7F52E; dkim=none; dkim-atps=neutral From: Andrew Rybchenko To: Ray Kinsella , Olivier Matz Cc: dev@dpdk.org Date: Wed, 29 Sep 2021 10:37:34 +0300 Message-Id: <20210929073734.1382905-1-andrew.rybchenko@oktetlabs.ru> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] mbuf: remove deprecated bad outer IPv4 checksum flag on Rx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Removed offload flag PKT_RX_EIP_CKSUM_BAD. PKT_RX_OUTER_IP_CKSUM_BAD should be used as a replacement. Signed-off-by: Andrew Rybchenko --- doc/guides/rel_notes/deprecation.rst | 7 +------ doc/guides/rel_notes/release_21_11.rst | 3 +++ lib/mbuf/rte_mbuf_core.h | 7 ------- 3 files changed, 4 insertions(+), 13 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 59445a6f42..3175426dad 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -42,7 +42,7 @@ Deprecation Notices * mbuf: The mbuf offload flags ``PKT_*`` will be renamed as ``RTE_MBUF_F_*``. A compatibility layer will be kept until DPDK 22.11, except for the flags that are already deprecated (``PKT_RX_L4_CKSUM_BAD``, ``PKT_RX_IP_CKSUM_BAD``, - ``PKT_RX_EIP_CKSUM_BAD``, ``PKT_TX_QINQ_PKT``) which will be removed. + ``PKT_RX_OUTER_IP_CKSUM_BAD``, ``PKT_TX_QINQ_PKT``) which will be removed. * pci: To reduce unnecessary ABIs exposed by DPDK bus driver, "rte_bus_pci.h" will be made internal in 21.11 and macros/data structures/functions defined @@ -159,11 +159,6 @@ Deprecation Notices will be limited to maximum 256 queues. Also compile time flag ``RTE_ETHDEV_QUEUE_STAT_CNTRS`` will be removed. -* ethdev: The offload flag ``PKT_RX_EIP_CKSUM_BAD`` will be removed and - replaced by the new flag ``PKT_RX_OUTER_IP_CKSUM_BAD``. The new name is more - consistent with existing outer header checksum status flag naming, which - should help in reducing confusion about its usage. - * i40e: As there are both i40evf and iavf pmd, the functions of them are duplicated. And now more and more advanced features are developed on iavf. To keep consistent with kernel driver's name diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst index a84c912f20..6c5a3c8981 100644 --- a/doc/guides/rel_notes/release_21_11.rst +++ b/doc/guides/rel_notes/release_21_11.rst @@ -126,6 +126,9 @@ Removed Items blacklist/whitelist are removed. Users must use the new block/allow list arguments. +* mbuf: Removed offload flag ``PKT_RX_EIP_CKSUM_BAD``. + ``PKT_RX_OUTER_IP_CKSUM_BAD`` should be used as a replacement. + API Changes ----------- diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.h index bb38d7f581..8db76d4885 100644 --- a/lib/mbuf/rte_mbuf_core.h +++ b/lib/mbuf/rte_mbuf_core.h @@ -79,13 +79,6 @@ extern "C" { */ #define PKT_RX_OUTER_IP_CKSUM_BAD (1ULL << 5) -/** - * Deprecated. - * This flag has been renamed, use PKT_RX_OUTER_IP_CKSUM_BAD instead. - */ -#define PKT_RX_EIP_CKSUM_BAD \ - RTE_DEPRECATED(PKT_RX_EIP_CKSUM_BAD) PKT_RX_OUTER_IP_CKSUM_BAD - /** * A vlan has been stripped by the hardware and its tci is saved in * mbuf->vlan_tci. This can only happen if vlan stripping is enabled