diff mbox series

[2/3] drivers/net: temporary disable ixgbe and txgbe

Message ID 20210930145014.2476799-3-gakhil@marvell.com (mailing list archive)
State Superseded, archived
Delegated to: akhil goyal
Headers show
Series crypto/security session framework rework | expand

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Akhil Goyal Sept. 30, 2021, 2:50 p.m. UTC
The PMDs ixgbe and txgbe are currently making
rte_security_session private data as constant,
but they are getting filled inside the API.
This was feasible as the session_private_data
and rte_security_session pointers were separate.
But now these two will be from same memory chunk.
Hence it cannot use them as const.
Need help from PMD owners to fix this.
Cc: Jian Wang <jianwang@trustnetic.com>
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: Haiyue Wang <haiyue.wang@intel.com>
Cc: Fan Zhang <roy.fan.zhang@intel.com>

Signed-off-by: Akhil Goyal <gakhil@marvell.com>
---
 drivers/net/meson.build | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Zhang, Roy Fan Oct. 12, 2021, 12:26 p.m. UTC | #1
Hi Akhil,

Looks like you commented out ixgbe/txgbe from build in this patch,
but you didn't add them back in in the next patch?

Regards,
Fan

> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Thursday, September 30, 2021 3:50 PM
> To: dev@dpdk.org
> Cc: thomas@monjalon.net; david.marchand@redhat.com;
> hemant.agrawal@nxp.com; anoobj@marvell.com; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>;
> Doherty, Declan <declan.doherty@intel.com>; matan@nvidia.com;
> g.singh@nxp.com; Zhang, Roy Fan <roy.fan.zhang@intel.com>;
> jianjay.zhou@huawei.com; asomalap@amd.com; ruifeng.wang@arm.com;
> Ananyev, Konstantin <konstantin.ananyev@intel.com>; Nicolau, Radu
> <radu.nicolau@intel.com>; ajit.khaparde@broadcom.com;
> rnagadheeraj@marvell.com; adwivedi@marvell.com; Power, Ciara
> <ciara.power@intel.com>; Akhil Goyal <gakhil@marvell.com>; Jian Wang
> <jianwang@trustnetic.com>; Jiawen Wu <jiawenwu@trustnetic.com>; Wang,
> Haiyue <haiyue.wang@intel.com>
> Subject: [PATCH 2/3] drivers/net: temporary disable ixgbe and txgbe
> 
> The PMDs ixgbe and txgbe are currently making
> rte_security_session private data as constant,
> but they are getting filled inside the API.
> This was feasible as the session_private_data
> and rte_security_session pointers were separate.
> But now these two will be from same memory chunk.
> Hence it cannot use them as const.
> Need help from PMD owners to fix this.
> Cc: Jian Wang <jianwang@trustnetic.com>
> Cc: Jiawen Wu <jiawenwu@trustnetic.com>
> Cc: Haiyue Wang <haiyue.wang@intel.com>
> Cc: Fan Zhang <roy.fan.zhang@intel.com>
> 
> Signed-off-by: Akhil Goyal <gakhil@marvell.com>
> ---
>  drivers/net/meson.build | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/meson.build b/drivers/net/meson.build
> index bcf488f203..4c0cd50cd5 100644
> --- a/drivers/net/meson.build
> +++ b/drivers/net/meson.build
> @@ -30,7 +30,7 @@ drivers = [
>          'igc',
>          'ionic',
>          'ipn3ke',
> -        'ixgbe',
> +	#        'ixgbe',
>          'kni',
>          'liquidio',
>          'memif',
> @@ -55,7 +55,7 @@ drivers = [
>          'szedata2',
>          'tap',
>          'thunderx',
> -        'txgbe',
> +#        'txgbe',
>          'vdev_netvsc',
>          'vhost',
>          'virtio',
> --
> 2.25.1
Akhil Goyal Oct. 12, 2021, 12:29 p.m. UTC | #2
> Hi Akhil,
> 
> Looks like you commented out ixgbe/txgbe from build in this patch,
> but you didn't add them back in in the next patch?
> 
Yes because these need attention from the maintainer of these drivers.
I mentioned this in the commit log.
Zhang, Roy Fan Oct. 12, 2021, 1:32 p.m. UTC | #3
Adding Radu as a gentle remainder to review the approach.

> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Tuesday, October 12, 2021 1:30 PM
> To: Zhang, Roy Fan <roy.fan.zhang@intel.com>; dev@dpdk.org
> Cc: thomas@monjalon.net; david.marchand@redhat.com;
> hemant.agrawal@nxp.com; Anoob Joseph <anoobj@marvell.com>; De Lara
> Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>; Doherty, Declan <declan.doherty@intel.com>;
> matan@nvidia.com; g.singh@nxp.com; jianjay.zhou@huawei.com;
> asomalap@amd.com; ruifeng.wang@arm.com; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Nicolau, Radu <radu.nicolau@intel.com>;
> ajit.khaparde@broadcom.com; Nagadheeraj Rottela
> <rnagadheeraj@marvell.com>; Ankur Dwivedi <adwivedi@marvell.com>;
> Power, Ciara <ciara.power@intel.com>; Jian Wang
> <jianwang@trustnetic.com>; Jiawen Wu <jiawenwu@trustnetic.com>; Wang,
> Haiyue <haiyue.wang@intel.com>
> Subject: RE: [PATCH 2/3] drivers/net: temporary disable ixgbe and txgbe
> 
> > Hi Akhil,
> >
> > Looks like you commented out ixgbe/txgbe from build in this patch,
> > but you didn't add them back in in the next patch?
> >
> Yes because these need attention from the maintainer of these drivers.
> I mentioned this in the commit log.
diff mbox series

Patch

diff --git a/drivers/net/meson.build b/drivers/net/meson.build
index bcf488f203..4c0cd50cd5 100644
--- a/drivers/net/meson.build
+++ b/drivers/net/meson.build
@@ -30,7 +30,7 @@  drivers = [
         'igc',
         'ionic',
         'ipn3ke',
-        'ixgbe',
+	#        'ixgbe',
         'kni',
         'liquidio',
         'memif',
@@ -55,7 +55,7 @@  drivers = [
         'szedata2',
         'tap',
         'thunderx',
-        'txgbe',
+#        'txgbe',
         'vdev_netvsc',
         'vhost',
         'virtio',