From patchwork Tue Oct 12 21:18:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 101278 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 97FEDA0C4D; Tue, 12 Oct 2021 23:20:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4F4C141157; Tue, 12 Oct 2021 23:20:15 +0200 (CEST) Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by mails.dpdk.org (Postfix) with ESMTP id 863544111A for ; Tue, 12 Oct 2021 23:20:10 +0200 (CEST) Received: by mail-pg1-f174.google.com with SMTP id r201so315716pgr.4 for ; Tue, 12 Oct 2021 14:20:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version; bh=esa8aTc5d0GQZFDmTglSl2RqsH9xdOhtrNLnqjtU6uU=; b=KMZ/l3+CZhzPMTAqUPsaQMI2cKPu1GdQ7FxULBuQVoJuFHMXSs9y0sbAbmq6YUR6lD ivuAiNW6JpF0FSh8DGp6tGAA66O/WoHQ5xppU+hGrcZDN1a7bCLKg8odj7DuRM2ir9Ik BZ7v4s2AAj3RVtAu9fwiW0FTARb/OW3WTtKiI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version; bh=esa8aTc5d0GQZFDmTglSl2RqsH9xdOhtrNLnqjtU6uU=; b=mrSM3V2s39dlzyPvgbmYYMoXI+fapLXLuF+F51OmR4BHaG8+goXFGBihz2aq9TN6rl pkAAHbm2AfEEudD9+/gzPpiP8yBsI2pWELiR2util0K8xX3j/rOxTMY9oklN9WKoObPE cmpz2e/Edtr61KBnd9aAIcuma5n/YgE+07an93BadmajtSzC/qwcz3t4bk8YN2UUW5KA b+qDumMeyRpUn1Wf2Y52QuuoTItpp9uyIxuWgt+QiTm5Vfmsxx0UZto7pMWBHva/dJSf /GF6y+F5s894mTcampjTSl7J1juhIivJVitVFxt9sEdj1c22F2mmKViHUg1FX79KYCIg KxJA== X-Gm-Message-State: AOAM533dVdSTSiIJgc2m+rkEOrfQ9FdpWtreFxAgiSFYGyzjXO6YCQ5k xaL2GeNrEa5cTvsLrSSslAnRK+wydC3G9s+fBH/m3xwRA0oiygrCrVFbJD2/eNwSYXlSOvUdUXS e6zbEVOpPa3IppSLTRg0Wo5g0Ok6pl7Oewtor00CwqZn9Yge+xmh6531ktYBtxFA= X-Google-Smtp-Source: ABdhPJz56+j0ij2dqvVY84ktvsKGyJPN96vJ4GCoFsBUFVoH1bwbtl5BIvkoq4nrTI18CDuqIGm2uA== X-Received: by 2002:aa7:8b56:0:b0:44c:10a:4ee9 with SMTP id i22-20020aa78b56000000b0044c010a4ee9mr34133647pfd.46.1634073609387; Tue, 12 Oct 2021 14:20:09 -0700 (PDT) Received: from localhost.localdomain ([136.52.99.246]) by smtp.gmail.com with ESMTPSA id ls7sm4084941pjb.16.2021.10.12.14.20.08 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Oct 2021 14:20:08 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Cc: ferruh.yigit@intel.com, stable@dpdk.org, Lance Richardson Date: Tue, 12 Oct 2021 14:18:44 -0700 Message-Id: <20211012211845.71121-3-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.30.1 (Apple Git-130) In-Reply-To: <20211012211845.71121-1-ajit.khaparde@broadcom.com> References: <20211012211845.71121-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [dpdk-dev] [PATCH v4 2/3] net/bnxt: fix Rx queue state on start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fix Rx queue state on device start. The state of Rx queues could be incorrect in some cases because instead of updating the state for all the Rx queues, we are updating it for queues in a VNIC. Fixes: 0105ea1296c9 ("net/bnxt: support runtime queue setup") Cc: stable@dpdk.org Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson --- drivers/net/bnxt/bnxt_ethdev.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index aa7e7fdc85..a98f93ab29 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -482,12 +482,6 @@ static int bnxt_setup_one_vnic(struct bnxt *bp, uint16_t vnic_id) rxq->vnic->fw_grp_ids[j] = INVALID_HW_RING_ID; else vnic->rx_queue_cnt++; - - if (!rxq->rx_deferred_start) { - bp->eth_dev->data->rx_queue_state[j] = - RTE_ETH_QUEUE_STATE_STARTED; - rxq->rx_started = true; - } } PMD_DRV_LOG(DEBUG, "vnic->rx_queue_cnt = %d\n", vnic->rx_queue_cnt); @@ -824,6 +818,16 @@ static int bnxt_start_nic(struct bnxt *bp) } } + for (j = 0; j < bp->rx_nr_rings; j++) { + struct bnxt_rx_queue *rxq = bp->rx_queues[j]; + + if (!rxq->rx_deferred_start) { + bp->eth_dev->data->rx_queue_state[j] = + RTE_ETH_QUEUE_STATE_STARTED; + rxq->rx_started = true; + } + } + rc = bnxt_hwrm_cfa_l2_set_rx_mask(bp, &bp->vnic_info[0], 0, NULL); if (rc) { PMD_DRV_LOG(ERR,