From patchwork Sat Oct 23 12:17:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Xueming(Steven) Li" X-Patchwork-Id: 102706 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 317E9A0C4E; Sat, 23 Oct 2021 14:18:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AEFBC4069D; Sat, 23 Oct 2021 14:18:17 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam07on2040.outbound.protection.outlook.com [40.107.95.40]) by mails.dpdk.org (Postfix) with ESMTP id D39BC40041 for ; Sat, 23 Oct 2021 14:18:16 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OA8aCyCOQFABtlgllW+s+xe0GH/69PZWs10NyIF8LSOOSHAHfafyudwjAR9YqhjC6aRZkXb4/Ixy6XRa1YM+ZlBaiaTlbgZXWr1PAu/VirXsgrY5/TC9jENYAXWClp8oyreQ2Zvg1D6ado2GgEoE7HPFrnomK972hKdMmBL4ul7G7h0DWrpH7FYoGqcAwowoISMhG3B10Gp2JAyW9n65QdOzio7RpP828gINow/19Ekfo6K1txBUf5C0nW+K4b1xftHOzq6ULWZNWMUvOvTky2qraE/fmuRD2tA0e0vz8v2DINRDC88xyOGlSAlQaZsIV1OCxPNmawt1Uk2+RAwkyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EK/koS373WtVGCmKYgtG1YOaSL4dNAT9RwLsXX7+maQ=; b=jdUia9k0bRX7gHQROh/UZWLoFP8fy/lsONlHsIsPntPd9SwQghGVGn8dYcVwrabNLGX0kSBxQYD2VQpn3Sq1CvHdWHjxU+wWaHRDwDfhQMAO+hw8W/xNME35BcbVUqSceGXV91o8SXn/KaHALzNFSpWyZeizQCkcUGL7CuEROT8SvyVV35hq7BIN66cnBM46ieC1OhIBW3mi6ZaotpoXTcqErpGmPmjdJFutE2ofIeIhmH18xlOUJ7/9/vWNWyQTuNaorv9945A+kE14DC4QQMNkI1A+e+acYUytRBDT7T7pG0FrRntv5Iho4TofWSsM+bIi3dDnKwgUgNLuGr22nQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=u256.net smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EK/koS373WtVGCmKYgtG1YOaSL4dNAT9RwLsXX7+maQ=; b=asT+cwWeRdgsgI9r5TNHgmBGri3/UP2eBHlPeJ/t6ubw/9bbvqdPYigS3WT8JEBkiD/nny60ORIRextLaLTzAMXFdywBBhLpMaifq0Fs6JZlkwj0RP2nR6K6G0rOmPdrB6mfxHNglWpTHOShg8TUKYc9yQhhzPua+4z+O3zb3cTNStYxNe0+Hr7b7wX7zs9VWmp+cGtUklCI4cMwMDEC8w63j6RpSWAW7hA02lzW4aRmjxnQHxpAyvIr/V3aB7uhj4WRleVvS14Yti8hJd/B1rhlb7l/sy2addvTVG3owWYn69H+Qk6VHTMAZgbb+BMr5mQAoVNnD+x1NSVTbvUWdg== Received: from BN9PR03CA0380.namprd03.prod.outlook.com (2603:10b6:408:f7::25) by BYAPR12MB3429.namprd12.prod.outlook.com (2603:10b6:a03:a8::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.20; Sat, 23 Oct 2021 12:18:14 +0000 Received: from BN8NAM11FT059.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f7:cafe::69) by BN9PR03CA0380.outlook.office365.com (2603:10b6:408:f7::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17 via Frontend Transport; Sat, 23 Oct 2021 12:18:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; u256.net; dkim=none (message not signed) header.d=none;u256.net; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT059.mail.protection.outlook.com (10.13.177.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4628.16 via Frontend Transport; Sat, 23 Oct 2021 12:18:14 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Sat, 23 Oct 2021 12:18:12 +0000 From: Xueming Li To: CC: , David Marchand , "Gaetan Rivet" Date: Sat, 23 Oct 2021 20:17:55 +0800 Message-ID: <20211023121755.169290-1-xuemingl@nvidia.com> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5e8454a2-c922-4325-dd53-08d9961f3011 X-MS-TrafficTypeDiagnostic: BYAPR12MB3429: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:37; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XXU+jLbHS8CQszqvyRYp0GCC+EeQKy8QzwZduCx6GbKayersRxUxIeSU0DNoEChEy/JeL17IraNxNiI4Umgd6AABaUIr3i3xqNVPD3ehVNUAYx+nKLAKEE3LalPIwNSNlW/ccyKeLuQFr8LrHSvPzuY2CZulodxz2aFg7xWojoW0+SJbfqBr3ro7UFQfMUowoUd/WJl6bgYfcQzEIUNOQYZh3iv4A34hQqqCyru+Po82ejWac1vFU5cvFmhBiXmv53IeC2hTJ1CIRgEA4hZjrT4fGpgeh821UadnACgKYlNWyM7YLrkknZKAXQdJkJDwZriCI6A+Tn/0xu6kWvKWBa+xkJHzv0BHKGp8tbLVLUdzMNXgYQXqvkzi4fusZfV+vjghzuc1HZkYoBE7UFg/5rCTvWs2744TKuqjXz9bggoiFKFzjM5MH6nCNI/y+ldcCkJdxpBWw0RedzvYdF3eIONm723YLQo/QOywrgiRgm2k0ft+tyUbm/zAGzYQtGoCVKoBGyWtkeZgPURO8awg51t1OEUpdNb1t3eSmuSK5hdwfRc0S05fArQHipb+/Bq2DU017I39zzwrsQzf4jIUMe7Ca7Z3zpNU2EkT5JH53nWAYrGiRRGDOR7NKr8DgqWW9WG1V0XOhoAJKRZR6YkME8E7A1HeLXlTsHO9lFewtDO02BKOry4lkr2JyCMJlAfxSHYbEXjIvhviD4sOV+aQ6g== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(2906002)(186003)(36860700001)(4744005)(26005)(336012)(8676002)(36756003)(5660300002)(2616005)(16526019)(82310400003)(426003)(316002)(36906005)(7696005)(8936002)(6916009)(86362001)(47076005)(508600001)(55016002)(6666004)(70586007)(70206006)(54906003)(7636003)(4326008)(1076003)(356005)(6286002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2021 12:18:14.2556 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5e8454a2-c922-4325-dd53-08d9961f3011 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT059.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3429 Subject: [dpdk-dev] [PATCH v1] test: fix devargs test case memory leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In layer argument test function, kvargs are parsed and checked without free. This patch calls rte_kvargs_free() function to avoid memory leak. Fixes: a4975cd20dca ("test: add devargs test cases") Signed-off-by: Xueming Li Reviewed-by: David Marchand --- app/test/test_devargs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test/test_devargs.c b/app/test/test_devargs.c index 19036716bf7..16621285d2d 100644 --- a/app/test/test_devargs.c +++ b/app/test/test_devargs.c @@ -43,8 +43,10 @@ test_args(const char *devargs, const char *layer, const char *args, const int n) if ((int)kvlist->count != n) { printf("rte_devargs_parse(%s) %s_str: %s kv number %u, not %d\n", devargs, layer, args, kvlist->count, n); + rte_kvargs_free(kvlist); return -1; } + rte_kvargs_free(kvlist); return 0; }