From patchwork Tue Oct 26 05:05:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Venkat Duvvuru X-Patchwork-Id: 102848 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85AC7A0C47; Tue, 26 Oct 2021 07:07:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 07476411AA; Tue, 26 Oct 2021 07:06:54 +0200 (CEST) Received: from relay.smtp-ext.broadcom.com (lpdvsmtp11.broadcom.com [192.19.166.231]) by mails.dpdk.org (Postfix) with ESMTP id D1D6241164 for ; Tue, 26 Oct 2021 07:06:22 +0200 (CEST) Received: from S60.dhcp.broadcom.net (unknown [10.123.66.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by relay.smtp-ext.broadcom.com (Postfix) with ESMTPS id 25FEE7DBA; Mon, 25 Oct 2021 22:06:20 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com 25FEE7DBA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1635224782; bh=dhBC3wT3BJDF4K2M2j+AvBRYFEbQuGFz1BB6vjqdlc0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GKh1dJfl9/bwmeXS/R6czc7ACFEqEz6DZ4yTrSjKe3P5ZKirIfIG60Q9A0IsxcqGU dLtkVcLPBpy0sWQsPwhKy90xDBaFk/18MrOZoBHnkMu5V8ffUwDbGl8KuX4VEoJiKl UcQ9BTSOPJc12tn/t4l1MOLRAp0CdCQ6g3SCTHY4= From: Venkat Duvvuru To: dev@dpdk.org Cc: Kishore Padmanabha , Venkat Duvvuru Date: Tue, 26 Oct 2021 10:35:40 +0530 Message-Id: <20211026050547.14692-13-venkatkumar.duvvuru@broadcom.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211026050547.14692-1-venkatkumar.duvvuru@broadcom.com> References: <20211001055909.27276-1-venkatkumar.duvvuru@broadcom.com> <20211026050547.14692-1-venkatkumar.duvvuru@broadcom.com> Subject: [dpdk-dev] [PATCH v2 12/19] net/bnxt: updated the log messages X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Kishore Padmanabha Some of the error level log messages are made debug level messages. When Truflow is not enabled then Truflow init error messages are moved to debug level instead. Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Shahaji Bhosle Reviewed-by: Michael Baucom Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 24 ++++++++++++------------ drivers/net/bnxt/tf_ulp/ulp_def_rules.c | 2 +- drivers/net/bnxt/tf_ulp/ulp_flow_db.c | 2 +- drivers/net/bnxt/tf_ulp/ulp_mark_mgr.c | 2 +- 4 files changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/net/bnxt/tf_ulp/bnxt_ulp.c b/drivers/net/bnxt/tf_ulp/bnxt_ulp.c index 7deacd1f3e..21f71d6445 100644 --- a/drivers/net/bnxt/tf_ulp/bnxt_ulp.c +++ b/drivers/net/bnxt/tf_ulp/bnxt_ulp.c @@ -1396,16 +1396,16 @@ bnxt_ulp_port_init(struct bnxt *bp) uint32_t ulp_flags; int32_t rc = 0; - if (!BNXT_PF(bp) && !BNXT_VF_IS_TRUSTED(bp)) { - BNXT_TF_DBG(ERR, - "Skip ulp init for port: %d, not a TVF or PF\n", + if (!BNXT_TRUFLOW_EN(bp)) { + BNXT_TF_DBG(DEBUG, + "Skip ulp init for port: %d, TF is not enabled\n", bp->eth_dev->data->port_id); return rc; } - if (!BNXT_TRUFLOW_EN(bp)) { - BNXT_TF_DBG(ERR, - "Skip ulp init for port: %d, truflow is not enabled\n", + if (!BNXT_PF(bp) && !BNXT_VF_IS_TRUSTED(bp)) { + BNXT_TF_DBG(DEBUG, + "Skip ulp init for port: %d, not a TVF or PF\n", bp->eth_dev->data->port_id); return rc; } @@ -1520,16 +1520,16 @@ bnxt_ulp_port_deinit(struct bnxt *bp) struct rte_pci_device *pci_dev; struct rte_pci_addr *pci_addr; - if (!BNXT_PF(bp) && !BNXT_VF_IS_TRUSTED(bp)) { - BNXT_TF_DBG(ERR, - "Skip ULP deinit port:%d, not a TVF or PF\n", + if (!BNXT_TRUFLOW_EN(bp)) { + BNXT_TF_DBG(DEBUG, + "Skip ULP deinit for port:%d, TF is not enabled\n", bp->eth_dev->data->port_id); return; } - if (!BNXT_TRUFLOW_EN(bp)) { - BNXT_TF_DBG(ERR, - "Skip ULP deinit for port:%d, truflow is not enabled\n", + if (!BNXT_PF(bp) && !BNXT_VF_IS_TRUSTED(bp)) { + BNXT_TF_DBG(DEBUG, + "Skip ULP deinit port:%d, not a TVF or PF\n", bp->eth_dev->data->port_id); return; } diff --git a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c index 01233c0f5e..8790d7ac0d 100644 --- a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c +++ b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c @@ -323,7 +323,7 @@ ulp_default_flow_create(struct rte_eth_dev *eth_dev, ulp_ctx = bnxt_ulp_eth_dev_ptr2_cntxt_get(eth_dev); if (!ulp_ctx) { BNXT_TF_DBG(ERR, - "ULP context is not initialized. Failed to create dflt flow.\n"); + "ULP is not init'ed. Fail to create dflt flow.\n"); return -EINVAL; } diff --git a/drivers/net/bnxt/tf_ulp/ulp_flow_db.c b/drivers/net/bnxt/tf_ulp/ulp_flow_db.c index 79dc869e64..9968311c44 100644 --- a/drivers/net/bnxt/tf_ulp/ulp_flow_db.c +++ b/drivers/net/bnxt/tf_ulp/ulp_flow_db.c @@ -470,7 +470,7 @@ ulp_flow_db_init(struct bnxt_ulp_context *ulp_ctxt) } /* All good so return. */ - BNXT_TF_DBG(INFO, "FlowDB initialized with %d flows.\n", + BNXT_TF_DBG(DEBUG, "FlowDB initialized with %d flows.\n", flow_tbl->num_flows); return 0; error_free: diff --git a/drivers/net/bnxt/tf_ulp/ulp_mark_mgr.c b/drivers/net/bnxt/tf_ulp/ulp_mark_mgr.c index 271520e1d3..9dffaef73b 100644 --- a/drivers/net/bnxt/tf_ulp/ulp_mark_mgr.c +++ b/drivers/net/bnxt/tf_ulp/ulp_mark_mgr.c @@ -116,7 +116,7 @@ ulp_mark_db_init(struct bnxt_ulp_context *ctxt) mark_tbl->gfid_mask = (mark_tbl->gfid_num_entries / 2) - 1; mark_tbl->gfid_type_bit = (mark_tbl->gfid_num_entries / 2); - BNXT_TF_DBG(DEBUG, "GFID Max = 0x%08x\nGFID MASK = 0x%08x\n", + BNXT_TF_DBG(DEBUG, "GFID Max = 0x%08x GFID MASK = 0x%08x\n", mark_tbl->gfid_num_entries - 1, mark_tbl->gfid_mask);