diff mbox series

test: enable bitmap in fast tests

Message ID 20211027140544.2871-1-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers show
Series test: enable bitmap in fast tests | expand

Checks

Context Check Description
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing fail Testing issues
ci/intel-Testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/Intel-compilation success Compilation OK
ci/github-robot: build success github build: passed
ci/checkpatch success coding style OK

Commit Message

David Marchand Oct. 27, 2021, 2:05 p.m. UTC
This test was never added to the list of tests to run in CI.
Its name does not follow the implicit convention of ending with
_autotest.
Let's fix this.

Fixes: 5e9647fd5a1a ("test/bitmap: test scan after half cacheline is cleared")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 app/test/meson.build   | 1 +
 app/test/test_bitmap.c | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

Comments

Cristian Dumitrescu Oct. 27, 2021, 2:55 p.m. UTC | #1
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Wednesday, October 27, 2021 3:06 PM
> To: dev@dpdk.org
> Cc: aconole@redhat.com; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>; Nithin Dabilpuram
> <ndabilpuram@marvell.com>
> Subject: [PATCH] test: enable bitmap in fast tests
> 
> This test was never added to the list of tests to run in CI.
> Its name does not follow the implicit convention of ending with
> _autotest.
> Let's fix this.
> 
> Fixes: 5e9647fd5a1a ("test/bitmap: test scan after half cacheline is cleared")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  app/test/meson.build   | 1 +
>  app/test/test_bitmap.c | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/app/test/meson.build b/app/test/meson.build
> index 71fce2efda..510584010a 100644
> --- a/app/test/meson.build
> +++ b/app/test/meson.build
> @@ -198,6 +198,7 @@ test_deps = [
>  fast_tests = [
>          ['acl_autotest', true],
>          ['atomic_autotest', false],
> +        ['bitmap_autotest', true],
>          ['bpf_autotest', true],
>          ['bpf_convert_autotest', true],
>          ['bitops_autotest', true],
> diff --git a/app/test/test_bitmap.c b/app/test/test_bitmap.c
> index 70d8fffb5a..e9c61590ae 100644
> --- a/app/test/test_bitmap.c
> +++ b/app/test/test_bitmap.c
> @@ -269,4 +269,4 @@ test_bitmap(void)
>  	return test_bitmap_all_set();
>  }
> 
> -REGISTER_TEST_COMMAND(bitmap_test, test_bitmap);
> +REGISTER_TEST_COMMAND(bitmap_autotest, test_bitmap);
> --
> 2.23.0

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
David Marchand Nov. 10, 2021, 10:45 a.m. UTC | #2
On Wed, Oct 27, 2021 at 4:55 PM Dumitrescu, Cristian
<cristian.dumitrescu@intel.com> wrote:
> > This test was never added to the list of tests to run in CI.
> > Its name does not follow the implicit convention of ending with
> > _autotest.
> > Let's fix this.
> >
> > Fixes: 5e9647fd5a1a ("test/bitmap: test scan after half cacheline is cleared")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/app/test/meson.build b/app/test/meson.build
index 71fce2efda..510584010a 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -198,6 +198,7 @@  test_deps = [
 fast_tests = [
         ['acl_autotest', true],
         ['atomic_autotest', false],
+        ['bitmap_autotest', true],
         ['bpf_autotest', true],
         ['bpf_convert_autotest', true],
         ['bitops_autotest', true],
diff --git a/app/test/test_bitmap.c b/app/test/test_bitmap.c
index 70d8fffb5a..e9c61590ae 100644
--- a/app/test/test_bitmap.c
+++ b/app/test/test_bitmap.c
@@ -269,4 +269,4 @@  test_bitmap(void)
 	return test_bitmap_all_set();
 }
 
-REGISTER_TEST_COMMAND(bitmap_test, test_bitmap);
+REGISTER_TEST_COMMAND(bitmap_autotest, test_bitmap);