From patchwork Mon Nov 15 17:58:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Conor Walsh X-Patchwork-Id: 104335 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E82FA0032; Mon, 15 Nov 2021 18:59:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7B20E410EA; Mon, 15 Nov 2021 18:59:17 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id B2B02410EA; Mon, 15 Nov 2021 18:59:15 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10169"; a="220701934" X-IronPort-AV: E=Sophos;i="5.87,237,1631602800"; d="scan'208";a="220701934" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2021 09:59:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,237,1631602800"; d="scan'208";a="506023831" Received: from silpixa00401160.ir.intel.com ([10.55.129.96]) by orsmga008.jf.intel.com with ESMTP; 15 Nov 2021 09:59:06 -0800 From: Conor Walsh To: ferruh.yigit@intel.com, david.marchand@redhat.com, longfengx.liang@intel.com, dev@dpdk.org Cc: david.hunt@intel.com, yipeng1.wang@intel.com, sameh.gobriel@intel.com, bruce.richardson@intel.com, vladimir.medvedkin@intel.com, hemant.agrawal@nxp.com, sachin.saxena@oss.nxp.com, fiona.trahe@intel.com, john.griffin@intel.com, deepak.k.jain@intel.com, harry.van.haaren@intel.com, ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com, xuanziyang2@huawei.com, cloud.wangxiaoyun@huawei.com, sthotton@marvell.com, srinivasan@marvell.com, heinrich.kuhn@corigine.com, hkalra@marvell.com, rmody@marvell.com, dsinghrawat@marvell.com, jiawenwu@trustnetic.com, yongwang@vmware.com, john.mcnamara@intel.com, gakhil@marvell.com, roy.fan.zhang@intel.com, arkadiuszx.kusztal@intel.com, michael.baucom@broadcom.com, venkatkumar.duvvuru@broadcom.com, lance.richardson@broadcom.com, kishore.padmanabha@broadcom.com, jerin.jacob@caviumnetworks.com, mjatharakonda@oneconvergence.com, simon.horman@corigine.com, david.george@sophos.com, sony.chacko@qlogic.com, harish.patil@qlogic.com, stephen@networkplumber.org, jerinjacobk@gmail.com, Conor Walsh , stable@dpdk.org Subject: [PATCH 1/6] app/test: fix unused but set variables Date: Mon, 15 Nov 2021 17:58:50 +0000 Message-Id: <20211115175855.1091621-2-conor.walsh@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211115175855.1091621-1-conor.walsh@intel.com> References: <20211112140111.922171-1-conor.walsh@intel.com> <20211115175855.1091621-1-conor.walsh@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patch fixes unused but set variables within the following test apps: - test distributor perf - test thash perf Bugzilla ID: 881 Fixes: c0de0eb82e40 ("distributor: switch over to new API") Fixes: 239fffe0402e ("test/thash: add performance tests for Toeplitz hash") Cc: stable@dpdk.org Reported-by: Liang Longfeng Signed-off-by: Conor Walsh Acked-by: Vladimir Medvedkin --- app/test/test_distributor_perf.c | 3 --- app/test/test_thash_perf.c | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/test/test_distributor_perf.c b/app/test/test_distributor_perf.c index fdbeae6d2f..92e330f194 100644 --- a/app/test/test_distributor_perf.c +++ b/app/test/test_distributor_perf.c @@ -108,7 +108,6 @@ static int handle_work(void *arg) { struct rte_distributor *d = arg; - unsigned int count = 0; unsigned int num = 0; int i; unsigned int id = __atomic_fetch_add(&worker_idx, 1, __ATOMIC_RELAXED); @@ -120,11 +119,9 @@ handle_work(void *arg) num = rte_distributor_get_pkt(d, id, buf, buf, num); while (!quit) { worker_stats[id].handled_packets += num; - count += num; num = rte_distributor_get_pkt(d, id, buf, buf, num); } worker_stats[id].handled_packets += num; - count += num; rte_distributor_return_pkt(d, id, buf, num); return 0; } diff --git a/app/test/test_thash_perf.c b/app/test/test_thash_perf.c index 7aa9360120..687582aa32 100644 --- a/app/test/test_thash_perf.c +++ b/app/test/test_thash_perf.c @@ -61,6 +61,9 @@ run_rss_calc(uint32_t *tuples[BATCH_SZ], enum test_rss_type type, int len, } end_tsc = rte_rdtsc_precise(); + /* To avoid compiler warnings set hash to used. */ + RTE_SET_USED(hash); + return end_tsc - start_tsc; }