From patchwork Tue Nov 16 09:42:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joyce Kong X-Patchwork-Id: 104388 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8CF47A0C43; Tue, 16 Nov 2021 10:43:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2F7B641186; Tue, 16 Nov 2021 10:43:18 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id 3D3E941226 for ; Tue, 16 Nov 2021 10:43:15 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C39281FB; Tue, 16 Nov 2021 01:43:14 -0800 (PST) Received: from net-arm-n1amp-02.shanghai.arm.com (net-arm-n1amp-02.shanghai.arm.com [10.169.210.110]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id EF9003F5A1; Tue, 16 Nov 2021 01:43:12 -0800 (PST) From: Joyce Kong To: Cc: dev@dpdk.org, honnappa.nagarahalli@arm.com, nd@arm.com, Joyce Kong , Ruifeng Wang Subject: [PATCH v2 09/12] app/compress: use compiler atomic builtins for display sync Date: Tue, 16 Nov 2021 09:42:02 +0000 Message-Id: <20211116094205.750359-10-joyce.kong@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211116094205.750359-1-joyce.kong@arm.com> References: <20211116094205.750359-1-joyce.kong@arm.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Convert rte_atomic_test_and_set usage to compiler atomic CAS operation for display sync. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- app/test-compress-perf/comp_perf_test_common.h | 2 +- .../comp_perf_test_cyclecount.c | 15 +++++++-------- .../comp_perf_test_throughput.c | 10 +++++++--- app/test-compress-perf/comp_perf_test_verify.c | 6 ++++-- 4 files changed, 19 insertions(+), 14 deletions(-) diff --git a/app/test-compress-perf/comp_perf_test_common.h b/app/test-compress-perf/comp_perf_test_common.h index 72705c6a2b..d039e5a29a 100644 --- a/app/test-compress-perf/comp_perf_test_common.h +++ b/app/test-compress-perf/comp_perf_test_common.h @@ -14,7 +14,7 @@ struct cperf_mem_resources { uint16_t qp_id; uint8_t lcore_id; - rte_atomic16_t print_info_once; + uint16_t print_info_once; uint32_t total_bufs; uint8_t *compressed_data; diff --git a/app/test-compress-perf/comp_perf_test_cyclecount.c b/app/test-compress-perf/comp_perf_test_cyclecount.c index c875ddbdac..da55b02b74 100644 --- a/app/test-compress-perf/comp_perf_test_cyclecount.c +++ b/app/test-compress-perf/comp_perf_test_cyclecount.c @@ -466,7 +466,7 @@ cperf_cyclecount_test_runner(void *test_ctx) struct cperf_cyclecount_ctx *ctx = test_ctx; struct comp_test_data *test_data = ctx->ver.options; uint32_t lcore = rte_lcore_id(); - static rte_atomic16_t display_once = RTE_ATOMIC16_INIT(0); + static uint16_t display_once; static rte_spinlock_t print_spinlock; int i; @@ -486,10 +486,12 @@ cperf_cyclecount_test_runner(void *test_ctx) ctx->ver.mem.lcore_id = lcore; + uint16_t exp = 0; /* * printing information about current compression thread */ - if (rte_atomic16_test_and_set(&ctx->ver.mem.print_info_once)) + if (__atomic_compare_exchange_n(&ctx->ver.mem.print_info_once, &exp, + 1, 0, __ATOMIC_RELAXED, __ATOMIC_RELAXED)) printf(" lcore: %u," " driver name: %s," " device name: %s," @@ -546,9 +548,10 @@ cperf_cyclecount_test_runner(void *test_ctx) (ctx->ver.mem.total_bufs * test_data->num_iter); /* R E P O R T processing */ - if (rte_atomic16_test_and_set(&display_once)) { + rte_spinlock_lock(&print_spinlock); - rte_spinlock_lock(&print_spinlock); + if (display_once == 0) { + display_once = 1; printf("\nLegend for the table\n" " - Retries section: number of retries for the following operations:\n" @@ -576,12 +579,8 @@ cperf_cyclecount_test_runner(void *test_ctx) "setup/op", "[C-e]", "[C-d]", "[D-e]", "[D-d]"); - - rte_spinlock_unlock(&print_spinlock); } - rte_spinlock_lock(&print_spinlock); - printf("%12u" "%6u" "%12zu" diff --git a/app/test-compress-perf/comp_perf_test_throughput.c b/app/test-compress-perf/comp_perf_test_throughput.c index 13922b658c..d3dff070b0 100644 --- a/app/test-compress-perf/comp_perf_test_throughput.c +++ b/app/test-compress-perf/comp_perf_test_throughput.c @@ -329,15 +329,17 @@ cperf_throughput_test_runner(void *test_ctx) struct cperf_benchmark_ctx *ctx = test_ctx; struct comp_test_data *test_data = ctx->ver.options; uint32_t lcore = rte_lcore_id(); - static rte_atomic16_t display_once = RTE_ATOMIC16_INIT(0); + static uint16_t display_once; int i, ret = EXIT_SUCCESS; ctx->ver.mem.lcore_id = lcore; + uint16_t exp = 0; /* * printing information about current compression thread */ - if (rte_atomic16_test_and_set(&ctx->ver.mem.print_info_once)) + if (__atomic_compare_exchange_n(&ctx->ver.mem.print_info_once, &exp, + 1, 0, __ATOMIC_RELAXED, __ATOMIC_RELAXED)) printf(" lcore: %u," " driver name: %s," " device name: %s," @@ -391,7 +393,9 @@ cperf_throughput_test_runner(void *test_ctx) ctx->decomp_gbps = rte_get_tsc_hz() / ctx->decomp_tsc_byte * 8 / 1000000000; - if (rte_atomic16_test_and_set(&display_once)) { + exp = 0; + if (__atomic_compare_exchange_n(&display_once, &exp, 1, 0, + __ATOMIC_RELAXED, __ATOMIC_RELAXED)) { printf("\n%12s%6s%12s%17s%15s%16s\n", "lcore id", "Level", "Comp size", "Comp ratio [%]", "Comp [Gbps]", "Decomp [Gbps]"); diff --git a/app/test-compress-perf/comp_perf_test_verify.c b/app/test-compress-perf/comp_perf_test_verify.c index 5e13257b79..f6e21368e8 100644 --- a/app/test-compress-perf/comp_perf_test_verify.c +++ b/app/test-compress-perf/comp_perf_test_verify.c @@ -388,7 +388,7 @@ cperf_verify_test_runner(void *test_ctx) struct cperf_verify_ctx *ctx = test_ctx; struct comp_test_data *test_data = ctx->options; int ret = EXIT_SUCCESS; - static rte_atomic16_t display_once = RTE_ATOMIC16_INIT(0); + static uint16_t display_once; uint32_t lcore = rte_lcore_id(); ctx->mem.lcore_id = lcore; @@ -427,8 +427,10 @@ cperf_verify_test_runner(void *test_ctx) ctx->ratio = (double) ctx->comp_data_sz / test_data->input_data_sz * 100; + uint16_t exp = 0; if (!ctx->silent) { - if (rte_atomic16_test_and_set(&display_once)) { + if (__atomic_compare_exchange_n(&display_once, &exp, 1, 0, + __ATOMIC_RELAXED, __ATOMIC_RELAXED)) { printf("%12s%6s%12s%17s\n", "lcore id", "Level", "Comp size", "Comp ratio [%]"); }