From patchwork Mon Jan 24 17:45:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 106360 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82505A04AD; Mon, 24 Jan 2022 18:47:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5FAD041181; Mon, 24 Jan 2022 18:47:27 +0100 (CET) Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by mails.dpdk.org (Postfix) with ESMTP id C1F7641181 for ; Mon, 24 Jan 2022 18:47:24 +0100 (CET) Received: by mail-pf1-f182.google.com with SMTP id x37so12713957pfh.8 for ; Mon, 24 Jan 2022 09:47:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Fx9fGBqwaJ0wCgjZtyoP2WepXlYkO+A7iATlxzyO6H0=; b=lv1NcdKoMT0PtTnorZBakcZ8V6auSgrfOSUSQ9ddSkKyEyH3m5isIfmZQYuYP+a2x3 pWK+9j7wazYrz6j7iTA7Vz7j9U8tdrPAXL3Qdz4btnV/7FvksgimYQL867fR8OCXybx5 HCA5xj2xrdliBow46Wgv5vlFLvbuGjJrIEoZi5DSHO7p6aHAqI3IoXJAdY7v/QIwqvOV KakcHDmu2+/eifqNOi5ZetNvYRfEDb+TwARhriFisTgIOzqBmsh5iuJgrZpXpHfJXn90 5fx0nA2j9laVVv6IDGTnc+l818gHjEs3fLSAoxjeeMaziSLtBJHSZ+rxTvfZX005kWwS v10A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Fx9fGBqwaJ0wCgjZtyoP2WepXlYkO+A7iATlxzyO6H0=; b=hAY7xQA3ObFlGr434y05TKoh3XUbba7RtYLvmy96OZy1+Q66yYxMud3oLhca9gQjIA 4k3nAU9ZI6zJR1XZsGRJlE+xlRlmH/oe393WQFOIV9oi/NuUAQn7KB/mAYH90Ac6gyV+ RaGbnmfWXIGbdVxtrUc3N8Sm9nbszY62dGw9Xkjhm0jeqxEAuNN6+vGZ5Y5cRSd+NLO8 SrRkZGYAP/aKcZSnXSiHf1PRzcli+xgevtLO0+ipbUXIYV+skwhAM6eGZiqmIJSjmIEy a+nIQ7QPkSu+pHfnx7oVdRuDmkVMBOCZ+AgTtWyVBDe/8AxfEgJLnSFU3pF0PMgEboTl rDFQ== X-Gm-Message-State: AOAM5317FOaSbCPRoz0vVI/4apTfNyHBrBq9DUsnwkYZMzh+AynkjDyz N3K09CDIYXhzKPhZ7x0ccRU3YTPyGPwVUQ== X-Google-Smtp-Source: ABdhPJwXYT59nEu3ATpYl/Nz3EF2d/4TuPPa5o0U6bW8OHQwW4utWarAKxCnEIBcD2J2aNycaYMrUg== X-Received: by 2002:a63:9142:: with SMTP id l63mr12629374pge.476.1643046443762; Mon, 24 Jan 2022 09:47:23 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id q7sm15835082pfs.37.2022.01.24.09.47.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 09:47:23 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v2 02/83] devtools/cocci: add script to fix unnecessary null checks Date: Mon, 24 Jan 2022 09:45:58 -0800 Message-Id: <20220124174719.14417-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220124174719.14417-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This script is based on the idea of the nullfree script in the Linux kernel. It finds cases where a check for null pointer is done, but is unnecessary because the function already handles NULL pointer. Basic example: if (x->buf) rte_free(x->buf); can be reduced to: rte_free(x->buf); Signed-off-by: Stephen Hemminger --- devtools/cocci/nullfree.cocci | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) create mode 100644 devtools/cocci/nullfree.cocci diff --git a/devtools/cocci/nullfree.cocci b/devtools/cocci/nullfree.cocci new file mode 100644 index 000000000000..363b6149ac28 --- /dev/null +++ b/devtools/cocci/nullfree.cocci @@ -0,0 +1,33 @@ +// +// Remove unnecessary NULL pointer checks before free functions +// All these functions work like libc free which allows +// free(NULL) as a no-op. +// +@@ +expression E; +@@ +( +- if (E != NULL) free(E); ++ free(E); +| +- if (E != NULL) rte_bitmap_free(E); ++ rte_bitmap_free(E); +| +- if (E != NULL) rte_free(E); ++ rte_free(E); +| +- if (E != NULL) rte_hash_free(E); ++ rte_hash_free(E); +| +- if (E != NULL) rte_ring_free(E); ++ rte_ring_free(E); +| +- if (E != NULL) rte_pktmbuf_free(E); ++ rte_pktmbuf_free(E); +| +- if (E != NULL) rte_mempool_free(E); ++ rte_mempool_free(E); +| +- if (E != NULL) rte_kvargs_free(E); ++ rte_kvargs_free(E); +)