diff mbox series

[v2] net/ice/base: support E824S and E825 devices

Message ID 20220216074516.1077717-1-robinx.zhang@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Qi Zhang
Headers
Series [v2] net/ice/base: support E824S and E825 devices |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-testing warning apply patch failure
ci/intel-Testing success Testing PASS

Commit Message

Robin Zhang Feb. 16, 2022, 7:45 a.m. UTC 
  Add support for E824S and E825 family devices.

Signed-off-by: Robin Zhang <robinx.zhang@intel.com>
---
 doc/guides/rel_notes/release_22_03.rst |  4 ++++
 drivers/net/ice/base/ice_common.c      |  6 ++++++
 drivers/net/ice/base/ice_devids.h      | 13 +++++++++++++
 drivers/net/ice/ice_ethdev.c           |  6 ++++++
 4 files changed, 29 insertions(+)

Comments

Qi Zhang Feb. 23, 2022, 2:42 a.m. UTC | #1 
> -----Original Message-----
> From: Zhang, RobinX <robinx.zhang@intel.com>
> Sent: Wednesday, February 16, 2022 3:45 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Guo, Junfeng <junfeng.guo@intel.com>; Yang, SteveX
> <stevex.yang@intel.com>; Zhang, RobinX <robinx.zhang@intel.com>
> Subject: [PATCH v2] net/ice/base: support E824S and E825 devices
> 
> Add support for E824S and E825 family devices.
> 
> Signed-off-by: Robin Zhang <robinx.zhang@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi
Ferruh Yigit Feb. 24, 2022, 11:37 a.m. UTC | #2 
On 2/23/2022 2:42 AM, Zhang, Qi Z wrote:
> 
> 
>> -----Original Message-----
>> From: Zhang, RobinX <robinx.zhang@intel.com>
>> Sent: Wednesday, February 16, 2022 3:45 PM
>> To: dev@dpdk.org
>> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
>> <qi.z.zhang@intel.com>; Guo, Junfeng <junfeng.guo@intel.com>; Yang, SteveX
>> <stevex.yang@intel.com>; Zhang, RobinX <robinx.zhang@intel.com>
>> Subject: [PATCH v2] net/ice/base: support E824S and E825 devices
>>
>> Add support for E824S and E825 family devices.
>>
>> Signed-off-by: Robin Zhang <robinx.zhang@intel.com>
> 
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> 
> Applied to dpdk-next-net-intel.
> 

Hi Qi, Robin,

The apply note is on v2, but v1 seems merged to your tree,
omitting release notes update (which was the request on v1).

I guess you don't want to document it in release notes
since devices are still under test and it will be
documented later when device support is matured, is this
correct?
If so can you please clarify this in the commit log with
a new version of patch?
diff mbox series

Patch

diff --git a/doc/guides/rel_notes/release_22_03.rst b/doc/guides/rel_notes/release_22_03.rst
index 41923f50e6..63df1c78da 100644
--- a/doc/guides/rel_notes/release_22_03.rst
+++ b/doc/guides/rel_notes/release_22_03.rst
@@ -118,6 +118,10 @@  New Features
   * Added PPPoL2TPv2oUDP FDIR distribute packets based on inner IP
     src/dst address and UDP/TCP src/dst port.
 
+* **Updated the Intel ice driver.**
+
+  * Added new device IDs to support E824S and E825 devices.
+
 * **Updated Wangxun ngbe driver.**
 
   * Added support for devices of custom PHY interfaces.
diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c
index ae55bebaa2..db87bacd97 100644
--- a/drivers/net/ice/base/ice_common.c
+++ b/drivers/net/ice/base/ice_common.c
@@ -167,6 +167,12 @@  static enum ice_status ice_set_mac_type(struct ice_hw *hw)
 	case ICE_DEV_ID_E823C_QSFP:
 	case ICE_DEV_ID_E823C_SFP:
 	case ICE_DEV_ID_E823C_SGMII:
+	case ICE_DEV_ID_E824S:
+	case ICE_DEV_ID_E825C_BACKPLANE:
+	case ICE_DEV_ID_E825C_QSFP:
+	case ICE_DEV_ID_E825C_SFP:
+	case ICE_DEV_ID_E825C_1GBE:
+	case ICE_DEV_ID_E825X:
 		hw->mac_type = ICE_MAC_GENERIC;
 		break;
 	default:
diff --git a/drivers/net/ice/base/ice_devids.h b/drivers/net/ice/base/ice_devids.h
index e52bb71403..96f2528c5e 100644
--- a/drivers/net/ice/base/ice_devids.h
+++ b/drivers/net/ice/base/ice_devids.h
@@ -58,5 +58,18 @@ 
 #define ICE_DEV_ID_E822L_10G_BASE_T	0x1899
 /* Intel(R) Ethernet Connection E822-L 1GbE */
 #define ICE_DEV_ID_E822L_SGMII		0x189A
+/* Intel(R) Ethernet Connection E824-S */
+#define ICE_DEV_ID_E824S		0x0DBD
+/* Intel(R) Ethernet Connection E825-C for backplane */
+#define ICE_DEV_ID_E825C_BACKPLANE	0x579C
+/* Intel(R) Ethernet Connection E825-C for QSFP */
+#define ICE_DEV_ID_E825C_QSFP	        0x579D
+/* Intel(R) Ethernet Connection E825-C for SFP */
+#define ICE_DEV_ID_E825C_SFP	        0x579E
+/* Intel(R) Ethernet Connection E825-C 1GbE */
+#define ICE_DEV_ID_E825C_1GBE	        0x579F
+/* Intel(R) Ethernet Connection E825-X */
+#define ICE_DEV_ID_E825X	        0x0DCD
+
 
 #endif /* _ICE_DEVIDS_H_ */
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 1a469afeac..13adcf90ed 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -196,6 +196,12 @@  static const struct rte_pci_id pci_id_ice_map[] = {
 	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E822L_SFP) },
 	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E822L_10G_BASE_T) },
 	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E822L_SGMII) },
+	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E824S) },
+	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E825C_BACKPLANE) },
+	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E825C_QSFP) },
+	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E825C_SFP) },
+	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E825C_1GBE) },
+	{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E825X) },
 	{ .vendor_id = 0, /* sentinel */ },
 };