From patchwork Thu Feb 17 13:06:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 107734 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34CD1A00BE; Thu, 17 Feb 2022 14:06:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F420A4114B; Thu, 17 Feb 2022 14:06:32 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D06FF4114D for ; Thu, 17 Feb 2022 14:06:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645103190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8KRoIk3yzpu2T/i2WuQYwpqZs9jPFeh1e3sYfcpy8S8=; b=O7M4kbZLtedA8ib71QLNDeced4oq8nDy+1LKCLQ9eozuT7zkU279UZ5YkUoeF6HwqQBwVs V8dJh7mUY8B1eknBRefPWm9Lo/Vb9Uhdn4VZbg4TcMctJ7w4TjoTCqSquqs1F5WjDD/WrU 9fxUs8GFRsKKD73H++Qn8m29z1DGVAc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-646-o5PnlrTIObCSo203FwUM-A-1; Thu, 17 Feb 2022 08:06:27 -0500 X-MC-Unique: o5PnlrTIObCSo203FwUM-A-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 76140801AA6; Thu, 17 Feb 2022 13:06:25 +0000 (UTC) Received: from dmarchan.remote.csb (unknown [10.40.194.195]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3AED573162; Thu, 17 Feb 2022 13:06:23 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: stable@dpdk.org, Ciara Loftus , Qi Zhang , Xiaolong Ye , Ferruh Yigit , Stephen Hemminger , Luca Boccassi , Kevin Laatz Subject: [PATCH] net/af_xdp: add missing trailing newline in logs Date: Thu, 17 Feb 2022 14:06:14 +0100 Message-Id: <20220217130614.23255-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Caught while trying --in-memory mode, some log messages in this driver are not terminated with a newline: rte_pmd_af_xdp_probe(): net_af_xdp: Failed to register multi-process IPC callback: Operation not supportedvdev_probe(): failed to initialize net_af_xdp device Other locations in this driver had the same issue, fix all at once. Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks") Fixes: 9876cf8316b3 ("net/af_xdp: re-enable secondary process support") Cc: stable@dpdk.org Signed-off-by: David Marchand Acked-by: Ciara Loftus --- drivers/net/af_xdp/rte_eth_af_xdp.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c index 6ac710c6bd..8bdc2920cf 100644 --- a/drivers/net/af_xdp/rte_eth_af_xdp.c +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c @@ -1071,7 +1071,7 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals, umem = rte_zmalloc_socket("umem", sizeof(*umem), 0, rte_socket_id()); if (umem == NULL) { - AF_XDP_LOG(ERR, "Failed to allocate umem info"); + AF_XDP_LOG(ERR, "Failed to allocate umem info\n"); return NULL; } @@ -1084,7 +1084,7 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals, ret = xsk_umem__create(&umem->umem, base_addr, umem_size, &rxq->fq, &rxq->cq, &usr_config); if (ret) { - AF_XDP_LOG(ERR, "Failed to create umem"); + AF_XDP_LOG(ERR, "Failed to create umem\n"); goto err; } umem->buffer = base_addr; @@ -1124,7 +1124,7 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals, umem = rte_zmalloc_socket("umem", sizeof(*umem), 0, rte_socket_id()); if (umem == NULL) { - AF_XDP_LOG(ERR, "Failed to allocate umem info"); + AF_XDP_LOG(ERR, "Failed to allocate umem info\n"); return NULL; } @@ -1160,7 +1160,7 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals, &usr_config); if (ret) { - AF_XDP_LOG(ERR, "Failed to create umem"); + AF_XDP_LOG(ERR, "Failed to create umem\n"); goto err; } umem->mz = mz; @@ -1847,7 +1847,7 @@ afxdp_mp_request_fds(const char *name, struct rte_eth_dev *dev) AF_XDP_LOG(DEBUG, "Sending multi-process IPC request for %s\n", name); ret = rte_mp_request_sync(&request, &replies, &timeout); if (ret < 0 || replies.nb_received != 1) { - AF_XDP_LOG(ERR, "Failed to request fds from primary: %d", + AF_XDP_LOG(ERR, "Failed to request fds from primary: %d\n", rte_errno); return -1; } @@ -1996,7 +1996,7 @@ rte_pmd_af_xdp_probe(struct rte_vdev_device *dev) if (!afxdp_dev_count) { ret = rte_mp_action_register(ETH_AF_XDP_MP_KEY, afxdp_mp_send_fds); if (ret < 0) { - AF_XDP_LOG(ERR, "%s: Failed to register multi-process IPC callback: %s", + AF_XDP_LOG(ERR, "%s: Failed to register multi-process IPC callback: %s\n", name, strerror(rte_errno)); return -1; }