From patchwork Wed Feb 23 18:48:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Baum X-Patchwork-Id: 108192 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 56556A00C2; Wed, 23 Feb 2022 19:48:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 31C624114F; Wed, 23 Feb 2022 19:48:50 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2081.outbound.protection.outlook.com [40.107.220.81]) by mails.dpdk.org (Postfix) with ESMTP id 9C51D41147 for ; Wed, 23 Feb 2022 19:48:48 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RXslVO25HSXgnypu58hhIphpmHZPP4igYJJ3vtMLGa4A4xZ1q0v5CMm/wHBHBNIjElwJW0+IQTa5nKsPrzVFqfRsK6B2DG3ZgoKO4Jb7YZkuhg84vYUV5Zuc7A5uRZC36HT35Al29lLyhVhvPofey3JcLwPOVVRsjooFF5HX+1B5aJNh2IK2SJhRR9D2VKPS2/YgTVlIZcVe0NZkIh4CNjvIkm6dgCbW1rtyQ/fyd/zziBlsLMk90Uz+HQG2moig51MUpFRGzWTMufK0zm/lTpxSjy6VzZX1v/4XQMhXPG9EbBoiCCCteLrWoIA+SLaKiDVGAeaha8SEvk9i5PdHxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GdUSLOlT9QofU8MwUYJu7txcOqc+2xv6QfbbiLZ6OzM=; b=cSrZsbXJVxHRVpJfrC6DwGRANA+5iMNo8UV5YSK+N2dVubW8ZcpFwZL8wXkhJM0Qd69VFvJTdE3n3EyUygaZjupzK3kqgZywJrx0ikA1lwAbxMayMyYA0R1ZYb64hO7UBUhoUA5XRMZkDH5SlzsE79ycqVR7FwuUTDN8BzlU/VvXlio7S5KnERgSmZ//IUJQpr3BvGOVL/Q57AvC6YAnkRiOL10xoRPaey9yFlvl7Hj/6iMPij8HvVqe52rYeiuw9yMV7Xbudktfq3m8Sk5MM0pkhYZd6f1shZSnBEqmnNFyE1WCZz09CBU9hsO2/8UhypEjrlxgPWkKSkw9h1zzVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.236) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GdUSLOlT9QofU8MwUYJu7txcOqc+2xv6QfbbiLZ6OzM=; b=oNmzx1P8VC+4/1QGmtF/jeeImbFyoeN1pVlOKDZcqnqtMZgDnOiApktxcsQq7Hf+OAHPK/nvzkOjMAoTuuSK3//d7BSn9OAM4yWOJr2D4kQXzhaZtb0al2Scz7wlNmPhLZncIaTK1zvlANmLZ8OYi6Am8Ptw44VWWvfe43T61XeF7h156pmp1bz7zMikENnlr1jLSQfyBg5TK0t+BoYbHQrwIyydaHZ2Pt+RTt++7sFIbOaftwDXHcujyl7eKFfN0+aQkh/Wo10sqUvsD62CtMa6YH9NltK0CNrhWvVIC/gEWhRI5j1iFBp+gfiy4myy9/iuNmzekzmDCMwRdmq5YA== Received: from DS7PR06CA0026.namprd06.prod.outlook.com (2603:10b6:8:54::16) by MN2PR12MB4472.namprd12.prod.outlook.com (2603:10b6:208:267::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Wed, 23 Feb 2022 18:48:46 +0000 Received: from DM6NAM11FT039.eop-nam11.prod.protection.outlook.com (2603:10b6:8:54:cafe::d6) by DS7PR06CA0026.outlook.office365.com (2603:10b6:8:54::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22 via Frontend Transport; Wed, 23 Feb 2022 18:48:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.236) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.236 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.236; helo=mail.nvidia.com; Received: from mail.nvidia.com (12.22.5.236) by DM6NAM11FT039.mail.protection.outlook.com (10.13.172.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5017.22 via Frontend Transport; Wed, 23 Feb 2022 18:48:46 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by DRHQMAIL109.nvidia.com (10.27.9.19) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 23 Feb 2022 18:48:45 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.9; Wed, 23 Feb 2022 10:48:44 -0800 Received: from nvidia.com (10.127.8.13) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.9 via Frontend Transport; Wed, 23 Feb 2022 10:48:43 -0800 From: Michael Baum To: CC: Matan Azrad , Raslan Darawsheh , Viacheslav Ovsiienko Subject: [PATCH v2 1/6] common/mlx5: consider local functions as internal Date: Wed, 23 Feb 2022 20:48:30 +0200 Message-ID: <20220223184835.3061161-2-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220223184835.3061161-1-michaelba@nvidia.com> References: <20220222210416.2669519-1-michaelba@nvidia.com> <20220223184835.3061161-1-michaelba@nvidia.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f9367ee0-ae41-42e9-5b6f-08d9f6fd1f53 X-MS-TrafficTypeDiagnostic: MN2PR12MB4472:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: e2fsDqRyzQdN5CfMMIsWsbJ9TbPmR2o2AAuyhgNBNl0jll7EFK8ZEJhyBlTU2DrudoXq+8V8aX6UhuM4/QmbFd3+sq7pLhVlc1vezLYGOe9sGw+sd9Osq27RG1xY3ToP/rYHuljZYiSkYM9+pyRK7Ky+fDWioBpfYR69I3ns+NLRekVzOKJ9kAXbzim3w68bXLE+n1s7FzmUNJTnlR7POeWsK/3P4oOZd+UOwwcnUQZ8sXQ/Kfuy3MSnTjIFhvbBDOcyid4Mum4atuzwKBlEigc4+ZSgAVSYL6GyoD/W4K7z6fWb6usae5tPyu735WXnavkVnQOeSPxnpIOty7Dsmt4yWRKbcyNEjvHJOBlKDu7dxh6uufVd2Sh/1toR/lO8nyyhjyYhUdwRgiFy7ttbdo8TGQQjNUKnWIWzrAKOIe6If1MeEaU3+y0mpyWVuqadtGGp7JFW1d7WHVF6YeSEqYN8Aa8SI6TeHYNuwV7iDlfGGkLEbK/kQxl+n8oLzMra4LgmcfQS9Axzb+w4SzQfjfHPfKnZgf/veVyxarD0o4ohAB5mwEgtI+OvVQSvNETKDn+n2E2B2ks6uw1mCYfZjrJ9XbjGTGQqpqGOg86IFGgBr3WaEcnUnGfPQqhEoanKh4UY6JHIv8E1ykWJPXGf6hYn8WdhId6VhHzks2EdEMHZ9/Cx6FTF2b5XfvKIgDgyCSWoAg3y01jL3SWGsqbxwg== X-Forefront-Antispam-Report: CIP:12.22.5.236; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(356005)(5660300002)(70206006)(81166007)(54906003)(8676002)(316002)(8936002)(4326008)(55016003)(7696005)(40460700003)(6916009)(36756003)(70586007)(2616005)(82310400004)(1076003)(186003)(26005)(6286002)(47076005)(107886003)(508600001)(2906002)(426003)(6666004)(336012)(86362001)(36860700001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 18:48:46.1101 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f9367ee0-ae41-42e9-5b6f-08d9f6fd1f53 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.236]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT039.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4472 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The functions which are not explicitly marked as internal were exported because the local catch-all rule was missing in the version script. After adding the missing rule, all local functions are hidden. The function mlx5_get_device_guid is used in another library, so it needs to be exported (as internal). Because the local functions were exported as non-internal in DPDK 21.11, any change in these functions would break the ABI. An ABI exception is added for this library, considering that all functions are either local or internal. Signed-off-by: Michael Baum --- devtools/libabigail.abignore | 4 ++++ drivers/common/mlx5/linux/mlx5_common_os.h | 1 + drivers/common/mlx5/version.map | 3 +++ 3 files changed, 8 insertions(+) diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore index ef0602975a..78d57497e6 100644 --- a/devtools/libabigail.abignore +++ b/devtools/libabigail.abignore @@ -20,3 +20,7 @@ ; Ignore changes to rte_crypto_asym_op, asymmetric crypto API is experimental [suppress_type] name = rte_crypto_asym_op + +; Ignore changes in common mlx5 driver, should be all internal +[suppress_file] + soname_regexp = ^librte_common_mlx5\. \ No newline at end of file diff --git a/drivers/common/mlx5/linux/mlx5_common_os.h b/drivers/common/mlx5/linux/mlx5_common_os.h index 83066e752d..edf356a30a 100644 --- a/drivers/common/mlx5/linux/mlx5_common_os.h +++ b/drivers/common/mlx5/linux/mlx5_common_os.h @@ -300,6 +300,7 @@ mlx5_set_context_attr(struct rte_device *dev, struct ibv_context *ctx); * 0 if OFED doesn't support. * >0 if success. */ +__rte_internal int mlx5_get_device_guid(const struct rte_pci_addr *dev, uint8_t *guid, size_t len); diff --git a/drivers/common/mlx5/version.map b/drivers/common/mlx5/version.map index 1c6153c576..cb20a7d893 100644 --- a/drivers/common/mlx5/version.map +++ b/drivers/common/mlx5/version.map @@ -80,6 +80,7 @@ INTERNAL { mlx5_free; + mlx5_get_device_guid; # WINDOWS_NO_EXPORT mlx5_get_ifname_sysfs; # WINDOWS_NO_EXPORT mlx5_get_pci_addr; # WINDOWS_NO_EXPORT @@ -149,4 +150,6 @@ INTERNAL { mlx5_mp_req_mempool_reg; mlx5_mr_mempool2mr_bh; mlx5_mr_mempool_populate_cache; + + local: *; };