net/nfp: remove unneeded header inclusion
Checks
Commit Message
Looking at this driver history, there was never a need for including
execinfo.h.
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 3 ---
1 file changed, 3 deletions(-)
Comments
Hi David,
Thanks for your work.
On 2022-04-08 11:41:16 +0200, David Marchand wrote:
> Looking at this driver history, there was never a need for including
> execinfo.h.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
> ---
> drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> index bad80a5a1c..08bc4e8ef2 100644
> --- a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> +++ b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> @@ -16,9 +16,6 @@
>
> #include <assert.h>
> #include <stdio.h>
> -#if defined(RTE_BACKTRACE)
> -#include <execinfo.h>
> -#endif
> #include <stdlib.h>
> #include <unistd.h>
> #include <stdint.h>
> --
> 2.23.0
>
On 4/21/2022 12:14 PM, Niklas Soderlund wrote:
> Hi David,
>
> Thanks for your work.
>
> On 2022-04-08 11:41:16 +0200, David Marchand wrote:
>> Looking at this driver history, there was never a need for including
>> execinfo.h.
>>
>> Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
>
Fixes: bdbf45c24b07 ("net/nfp: fix build with musl libc")
Cc: stable@dpdk.org
Applied to dpdk-next-net/main, thanks.
@@ -16,9 +16,6 @@
#include <assert.h>
#include <stdio.h>
-#if defined(RTE_BACKTRACE)
-#include <execinfo.h>
-#endif
#include <stdlib.h>
#include <unistd.h>
#include <stdint.h>