From patchwork Thu Jun 23 02:26:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jin Liu X-Patchwork-Id: 113283 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9962CA0545; Thu, 23 Jun 2022 04:27:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 142674280B; Thu, 23 Jun 2022 04:27:05 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2097.outbound.protection.outlook.com [40.107.94.97]) by mails.dpdk.org (Postfix) with ESMTP id 4ABF140DDB for ; Thu, 23 Jun 2022 04:26:59 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oVetUeuqxqnusVpZzfvFIMjDUSmh5B7+6U9HZvbdeCF6ZFfjoGAZEcGpH839V4YKCKm6uoE+tC4rvPpFF6edPfNV5mA6q5nOqIzc/5LMVvZbzA8T6w6cSZvNbZbb7EHcPeQLwx8Rqlq0ypuWjCEG6+y7/nduSQmG1fGG42CdhMK+K6sIetS+xkjkOcZFog9tz1szzx2iCzsyQIltXMIYwUpG1QZ1QnBS0dHE5SGlfwl0ZGUVgekEgT8Xb5+rCcv3gu5R3isd9uSN1YdgpiVZrDhA3NTI2uu0ZPOEs03qBQyhPnZmIao84ZijNyjrK9fS2QSRe3LlYXv6vB5L3rdz3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h0XMQ/gppdgEIimBF1bLvhm5GOnKmL0wp/g835CrBL0=; b=JY47l6l07o0SrAnh6nHCxhpr8FuTYY82ytgSJaxAoPblq0Pv1xKxFgdZVw0B8qvdgKs0gwX+TEaHQjYOkTLiANqLgJ1fkAEqT1i2U7ERP3al736T7YZ/lLbTSy+AC077IzRcTJpCrrgcP2zzYCyulMF1crrqVnsyVa4wTLffR5gZ/mNM/1eUSHZfvD7+YoXfbDbt5THGOu9sK7nOc+0a2Tot/NhxHmipTQVVR8bTUxajIIU2TT7rIG0eYuqeSxk8hYdGIJOQPyyCdPOUnVObSsQiJsEeYrRty7qll4ul1frLynBLibq9R+/0MV5Es4icMgPAjts5EaeBFhBjUhiTqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h0XMQ/gppdgEIimBF1bLvhm5GOnKmL0wp/g835CrBL0=; b=IqQES08JaGWYNULrS7/EHmb5i8diVSyZs1cmeSWppACQ6c3H1BXOd0fuD7Ax9KMLnr2BEVKNMBU7M1coR1Q8ZF4dYckbYprt69O1EHcquUvwifiBkI9k6xLHp/ymFFiiOg8FYUmYKyflAgsBv+r0qLfKW+dolk+fMArN+WTnt6M= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from DM6PR13MB3004.namprd13.prod.outlook.com (2603:10b6:5:191::21) by MN2PR13MB3535.namprd13.prod.outlook.com (2603:10b6:208:169::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15; Thu, 23 Jun 2022 02:26:56 +0000 Received: from DM6PR13MB3004.namprd13.prod.outlook.com ([fe80::ac31:a36a:cc15:cd35]) by DM6PR13MB3004.namprd13.prod.outlook.com ([fe80::ac31:a36a:cc15:cd35%7]) with mapi id 15.20.5373.015; Thu, 23 Jun 2022 02:26:56 +0000 From: Jin Liu To: dev@dpdk.org Cc: niklas.soderlund@corigine.com, Jin Liu , Chaoyong He Subject: [PATCH v4 02/13] net/nfp: remove unnecessary forward function declaration Date: Thu, 23 Jun 2022 04:26:04 +0200 Message-Id: <20220623022615.3628093-3-jin.liu@corigine.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220623022615.3628093-1-jin.liu@corigine.com> References: <20220617093444.2004000-1-jin.liu@corigine.com> <20220623022615.3628093-1-jin.liu@corigine.com> X-ClientProxiedBy: LO4P265CA0222.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:33a::10) To DM6PR13MB3004.namprd13.prod.outlook.com (2603:10b6:5:191::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 379222ff-4b86-4a05-f6f0-08da54bfd7d2 X-MS-TrafficTypeDiagnostic: MN2PR13MB3535:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1R1JJOB/57yGWThj2F3G5cPwejRM9wdZxqf7w1EcM9zZQtLdnuseQRMo5p2WLIc4Y35gzUiG4WcKGWw3SKQnDFIg1yzMP6oaaDYMzM8Cgy8hxc5Ek8pwAUrBpZCLtNoWqav32Cjk3bQJUU47VfJXapxg88l4FYVTg4+INB1LJT/iuGrmKLyhxLQFfnIfXdOmqy5JaI9lA9TJsjKcllrpP82cVA8gPh4ATWsna79+QCxrfMlUJTvhaTca9RMfeIT3hcg2g0jZgLE4jkhTvQmR89YYzrMr8Pmtnkcjc03vSR9jsd90rKE2oXNGmN8N5vCvtJY1Z74076qyvaUVWNlZYdK36eczk8Krgkj6jHtbE4JjPzr26sUPFZm47r4qyoDO3h4rRtBarmICDxa0kmO9j9eiN9nXKPe4jK/MF5VAiDaTpBmU2VGB+9PwG8iqApBT2LUfNHljSm8dX/Fa/FV+MSZINKNmrlQwUhSfKRZ/QZxI/R5SV6DW1lYnruqrBz9rz1DIxIDMJBkzjf90gUNBX/rQokSPoxsNvVEcGyrMgHTANbdKQAXv6OctuUVsK4L4BnaIrzz4jmlvzEyxgAHvhfj4u2qPs9riczF4GBo4cBdyNq2ZqOE1p5hwAiFof1MxiAxc9oWqlLMDSxOWpct6BPBp9vkhPEAgEC+5cn8c39SEneUEJdb5k7F92bA/wUC3JKOJvq+OGw5IOmP0kDlg/snf5pta4OiEc+kRzvp8oznmFePYSWjyL9z7R3LN1ful6KKYPfQHPR8Uewu5SfgYat4q0ih3MKFuluFloiEW+wCbKR8912QAFYlmjoBKcz9V X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR13MB3004.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(376002)(366004)(346002)(136003)(396003)(39830400003)(6666004)(107886003)(1076003)(38100700002)(38350700002)(6486002)(36756003)(66574015)(8936002)(54906003)(2616005)(6916009)(5660300002)(316002)(66556008)(52116002)(6506007)(186003)(66946007)(8676002)(4326008)(66476007)(41300700001)(86362001)(6512007)(26005)(83380400001)(478600001)(2906002)(44832011); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?jP12wZ6kjm4NciOYJqKXjcV96+wI?= =?utf-8?q?SbdVFnNWEnDLj56Wf3SFymN8bbGflsbcewta1A1xQJtDuB9cSnWDTTmGEk1K6NUCy?= =?utf-8?q?bIwkGJUFg4zECWVrKRJ2SpmGMLvxegtwLjrIO45zchoFXP5dJtw6id0vo/IxY6jc9?= =?utf-8?q?hnF14a/omLWkzzU9XbyVld0rHA02V0yByIgtBNqsF2P5UDTFR3ANRhk24iCQsU+wt?= =?utf-8?q?vo4LzI5ZYgp+IXrSU+u3uNf8mxsmRZumIzAmhVL1qQb/fzs9SSAIfoUJPwao5vgv6?= =?utf-8?q?eyE/+Bz4XsYxkMhLwR3iifqZusUO/UJSiT5K4DUjuIYY6SvbXOu4KcDfXF7lzuAUn?= =?utf-8?q?uhUY/qc3H+i4dYg83/OYDlXGhhIb9AwPK/84XS9IDn5vuIVSbO6rSFvpO4koiQmeH?= =?utf-8?q?y+IU7COvuacd3Et35OEVKVZTP+MM8wkaTxUAsAPmjzQYCr3TC8hvSWikXgmJBtkEN?= =?utf-8?q?k+2g8L8ojdarbOki83787yNsghbmRq39vr2kDy4RN63CVAJ79x189ZHFUJEB6EssD?= =?utf-8?q?ZTz6MmBckmLAS9qRRnglqac5lFZuKsakXSfZmWDkCBgWX9D0ViPn/4/fKvRWFEWWA?= =?utf-8?q?nCV/KGzRK7wDFXjRPRmEo4ZGSAJoyB8WT+4u66oN0mOSY8xhgNaIM/VjdKi4UMJiJ?= =?utf-8?q?p5PTAjXZJCp0jVSBeZrenaxARajbxT/3YUzX2omqUB6I95BR4HDyJcUhrR0yAwGwc?= =?utf-8?q?jXFJM7D/Z5/ajysp5uwOAk1aii32Hzr+3juK/dVSuA5fJi4cuxsWHDJPvauFIfRKo?= =?utf-8?q?b3/mzZdAhxF0tKpWfZ1LF9458HI4BN4RgCWlJq8oNi70OquDs6egeIyYfPD35XwbB?= =?utf-8?q?+wPWmWtJSJBuCFZA7CGESCRKeKVQm1+416kgpejoyrMCmIuk/Pd+WrbX6ZWPt3lC2?= =?utf-8?q?xqpbctZmtI5ZY+DauWMtjBVZPkQL2tzOq4beJ2wB+8R1N636mHYKtERtENPJBg4XV?= =?utf-8?q?zGdZ4HY2uYBj2PeGQsfSTW/BnsKCD475jEpECC2Fll4YLxSc0Me5vJLW3p2M30zwt?= =?utf-8?q?vJX5smMw0n+XQbQB/+SePN2VsP0X37Sx38xpxDFtmjrz2RrIYdT0puQzhFKwJSj6M?= =?utf-8?q?cOMO+w+utlnQ9abzkW79DHcDIK0ZMigLOxthhLlMTtaxPGiNMBawPHf3xCd7msDKA?= =?utf-8?q?pK39/05PoUOv0EvaNfiZYtKPONgcwsYSS7/KDz3vJcnXYfZ4wQ7yJMTajn4i8ntpJ?= =?utf-8?q?fVWW/YvUovLf0Pefu1sU59kzO3mlMsELpoJd0pL0n9wR4KhbPXJ92n55C7pQGNI7i?= =?utf-8?q?xbUoNcsFDWB9mfLltBreNIkgI1ywIHJ24TN07G4hDrPOsKiUQiBy7q5cUeYC7QU2+?= =?utf-8?q?TN3+mHCFGQlIBnnFaUlPDprlmtlRGCS2qNabEewBamx7/juYB/yWLn1FOLOaKQXcB?= =?utf-8?q?+jtmMllwVlJG9B7F3xIH16PNRDYyzKUji0fJGMEoVQjdJUxokKcuDlqKnfbmC/73G?= =?utf-8?q?b2UyoKrUF0PcNHeUIWa51Gb5OdLmrx/9+1GheEpBdmTdR9jZN5QL5weZR8Yjdxpvi?= =?utf-8?q?b7eCCLQrQ71E?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 379222ff-4b86-4a05-f6f0-08da54bfd7d2 X-MS-Exchange-CrossTenant-AuthSource: DM6PR13MB3004.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2022 02:26:56.5103 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uWjBfipXRLfdOaTU7j5DkR9Dnu0yWVVN7qXPLNeJnsVEmx6RSX4nzT/K1jiVbJssDqq1L25sl/BSeQUOR8O59g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB3535 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This commit remove some unnecessary forward function declarations. Signed-off-by: Chaoyong He Signed-off-by: Jin Liu Signed-off-by: Niklas Söderlund --- drivers/net/nfp/nfp_ethdev.c | 22 ---------------------- drivers/net/nfp/nfp_ethdev_vf.c | 12 ------------ drivers/net/nfp/nfp_rxtx.c | 21 --------------------- 3 files changed, 55 deletions(-) diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c index eb0d92a98c..36ab31b688 100644 --- a/drivers/net/nfp/nfp_ethdev.c +++ b/drivers/net/nfp/nfp_ethdev.c @@ -38,28 +38,6 @@ #include "nfp_ctrl.h" #include "nfp_cpp_bridge.h" - -static int nfp_net_pf_read_mac(struct nfp_pf_dev *pf_dev, int port); -static int nfp_net_start(struct rte_eth_dev *dev); -static int nfp_net_stop(struct rte_eth_dev *dev); -static int nfp_net_set_link_up(struct rte_eth_dev *dev); -static int nfp_net_set_link_down(struct rte_eth_dev *dev); -static int nfp_net_close(struct rte_eth_dev *dev); -static int nfp_net_init(struct rte_eth_dev *eth_dev); -static int nfp_fw_upload(struct rte_pci_device *dev, - struct nfp_nsp *nsp, char *card); -static int nfp_fw_setup(struct rte_pci_device *dev, - struct nfp_cpp *cpp, - struct nfp_eth_table *nfp_eth_table, - struct nfp_hwinfo *hwinfo); -static int nfp_init_phyports(struct nfp_pf_dev *pf_dev); -static int nfp_pf_init(struct rte_pci_device *pci_dev); -static int nfp_pf_secondary_init(struct rte_pci_device *pci_dev); -static int nfp_pf_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, - struct rte_pci_device *dev); -static int nfp_pci_uninit(struct rte_eth_dev *eth_dev); -static int eth_nfp_pci_remove(struct rte_pci_device *pci_dev); - static int nfp_net_pf_read_mac(struct nfp_pf_dev *pf_dev, int port) { diff --git a/drivers/net/nfp/nfp_ethdev_vf.c b/drivers/net/nfp/nfp_ethdev_vf.c index 381a25c03c..8d68ccbc95 100644 --- a/drivers/net/nfp/nfp_ethdev_vf.c +++ b/drivers/net/nfp/nfp_ethdev_vf.c @@ -23,18 +23,6 @@ #include "nfp_logs.h" #include "nfp_ctrl.h" -static void nfp_netvf_read_mac(struct nfp_net_hw *hw); -static int nfp_netvf_start(struct rte_eth_dev *dev); -static int nfp_netvf_stop(struct rte_eth_dev *dev); -static int nfp_netvf_set_link_up(struct rte_eth_dev *dev); -static int nfp_netvf_set_link_down(struct rte_eth_dev *dev); -static int nfp_netvf_close(struct rte_eth_dev *dev); -static int nfp_netvf_init(struct rte_eth_dev *eth_dev); -static int nfp_vf_pci_uninit(struct rte_eth_dev *eth_dev); -static int eth_nfp_vf_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, - struct rte_pci_device *pci_dev); -static int eth_nfp_vf_pci_remove(struct rte_pci_device *pci_dev); - static void nfp_netvf_read_mac(struct nfp_net_hw *hw) { diff --git a/drivers/net/nfp/nfp_rxtx.c b/drivers/net/nfp/nfp_rxtx.c index 335a90b2c9..cd7faa2c58 100644 --- a/drivers/net/nfp/nfp_rxtx.c +++ b/drivers/net/nfp/nfp_rxtx.c @@ -21,27 +21,6 @@ #include "nfp_logs.h" #include "nfp_ctrl.h" -/* Prototypes */ -static int nfp_net_rx_fill_freelist(struct nfp_net_rxq *rxq); -static inline void nfp_net_mbuf_alloc_failed(struct nfp_net_rxq *rxq); -static inline void nfp_net_set_hash(struct nfp_net_rxq *rxq, - struct nfp_net_rx_desc *rxd, - struct rte_mbuf *mbuf); -static inline void nfp_net_rx_cksum(struct nfp_net_rxq *rxq, - struct nfp_net_rx_desc *rxd, - struct rte_mbuf *mb); -static void nfp_net_rx_queue_release_mbufs(struct nfp_net_rxq *rxq); -static int nfp_net_tx_free_bufs(struct nfp_net_txq *txq); -static void nfp_net_tx_queue_release_mbufs(struct nfp_net_txq *txq); -static inline uint32_t nfp_free_tx_desc(struct nfp_net_txq *txq); -static inline uint32_t nfp_net_txq_full(struct nfp_net_txq *txq); -static inline void nfp_net_tx_tso(struct nfp_net_txq *txq, - struct nfp_net_tx_desc *txd, - struct rte_mbuf *mb); -static inline void nfp_net_tx_cksum(struct nfp_net_txq *txq, - struct nfp_net_tx_desc *txd, - struct rte_mbuf *mb); - static int nfp_net_rx_fill_freelist(struct nfp_net_rxq *rxq) {