[v2] doc: add event timer expiry drop stat
Checks
Commit Message
The structure ``rte_event_timer_adapter_stats`` will be
extended by adding a new field, ``evtim_drop_count``. This stat
will represent the number of times an event_timer expiry event
is dropped by the event timer adapter.
Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
---
v2:
* update commit message
---
doc/guides/rel_notes/deprecation.rst | 6 ++++++
1 file changed, 6 insertions(+)
Comments
On Tue, Jun 28, 2022 at 8:38 AM Naga Harish K S V
<s.v.naga.harish.k@intel.com> wrote:
>
> The structure ``rte_event_timer_adapter_stats`` will be
> extended by adding a new field, ``evtim_drop_count``. This stat
> will represent the number of times an event_timer expiry event
> is dropped by the event timer adapter.
>
> Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
> ---
> v2:
> * update commit message
> ---
> doc/guides/rel_notes/deprecation.rst | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 4e5b23c53d..597a457a37 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -125,3 +125,9 @@ Deprecation Notices
> applications should be updated to use the ``dmadev`` library instead,
> with the underlying HW-functionality being provided by the ``ioat`` or
> ``idxd`` dma drivers
> +
> +* eventdev/timer: The structure ``rte_event_timer_adapter_stats`` will be
> + extended by adding a new field, ``evtim_drop_count``. This stat will
> + represent the number of times an event_timer expiry event is dropped
> + by the timer adapter. This field will be used by a future patch adding
> + support for periodic mode to the software timer adapter in DPDK 22.11.
> --
> 2.25.1
>
On 7/12/2022 5:22 PM, Jerin Jacob wrote:
> On Tue, Jun 28, 2022 at 8:38 AM Naga Harish K S V
> <s.v.naga.harish.k@intel.com> wrote:
>> The structure ``rte_event_timer_adapter_stats`` will be
>> extended by adding a new field, ``evtim_drop_count``. This stat
>> will represent the number of times an event_timer expiry event
>> is dropped by the event timer adapter.
>>
>> Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
>
> Acked-by: Jerin Jacob <jerinj@marvell.com>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>> ---
>> v2:
>> * update commit message
>> ---
>> doc/guides/rel_notes/deprecation.rst | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
>> index 4e5b23c53d..597a457a37 100644
>> --- a/doc/guides/rel_notes/deprecation.rst
>> +++ b/doc/guides/rel_notes/deprecation.rst
>> @@ -125,3 +125,9 @@ Deprecation Notices
>> applications should be updated to use the ``dmadev`` library instead,
>> with the underlying HW-functionality being provided by the ``ioat`` or
>> ``idxd`` dma drivers
>> +
>> +* eventdev/timer: The structure ``rte_event_timer_adapter_stats`` will be
>> + extended by adding a new field, ``evtim_drop_count``. This stat will
>> + represent the number of times an event_timer expiry event is dropped
>> + by the timer adapter. This field will be used by a future patch adding
>> + support for periodic mode to the software timer adapter in DPDK 22.11.
>> --
>> 2.25.1
>>
> -----Original Message-----
> From: Hemant Agrawal <hemant.agrawal@oss.nxp.com>
> Sent: Tuesday, July 12, 2022 4:08 PM
> To: dev@dpdk.org
> Subject: Re: [PATCH v2] doc: add event timer expiry drop stat
>
>
> On 7/12/2022 5:22 PM, Jerin Jacob wrote:
> > On Tue, Jun 28, 2022 at 8:38 AM Naga Harish K S V
> > <s.v.naga.harish.k@intel.com> wrote:
> >> The structure ``rte_event_timer_adapter_stats`` will be
> >> extended by adding a new field, ``evtim_drop_count``. This stat
> >> will represent the number of times an event_timer expiry event
> >> is dropped by the event timer adapter.
> >>
> >> Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
> >
> > Acked-by: Jerin Jacob <jerinj@marvell.com>
>
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Adding a statistic seems reasonable;
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
28/06/2022 04:34, Naga Harish K S V:
> The structure ``rte_event_timer_adapter_stats`` will be
> extended by adding a new field, ``evtim_drop_count``. This stat
> will represent the number of times an event_timer expiry event
> is dropped by the event timer adapter.
>
> Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
Reviewed-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Applied, thanks.
@@ -125,3 +125,9 @@ Deprecation Notices
applications should be updated to use the ``dmadev`` library instead,
with the underlying HW-functionality being provided by the ``ioat`` or
``idxd`` dma drivers
+
+* eventdev/timer: The structure ``rte_event_timer_adapter_stats`` will be
+ extended by adding a new field, ``evtim_drop_count``. This stat will
+ represent the number of times an event_timer expiry event is dropped
+ by the timer adapter. This field will be used by a future patch adding
+ support for periodic mode to the software timer adapter in DPDK 22.11.