From patchwork Wed Oct 5 14:34:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 117385 X-Patchwork-Delegate: andrew.rybchenko@oktetlabs.ru Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B782A0542; Wed, 5 Oct 2022 16:35:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CA5F9427EE; Wed, 5 Oct 2022 16:35:15 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 6712240694; Wed, 5 Oct 2022 16:35:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664980513; x=1696516513; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=CoXt98/ADQro9U8fhNjMwDX6Mq3z+C13msteV+x+mU4=; b=HLJb+ooWCEgbuggksJhR2k0kFlZpK+HPKBjX+0bGGKr7HhCrEtv3+AUA KCwnTBwbjdYSn5CGOGS/5DLB/8fO1ZwsDGgh6cKW9QAQuI6SO+a8RQKot 1ynDoFSpbJSGEnQ0Tnjd4UuqkkMdJwoqcStjDYlSRikMTnIAZofgxtP70 XQ96zzUOpDtF7djPACaKYtM5rM/g4HzDdoGxfiAeyuSlY5EuWd+82/Kee h7VE0gkcr1j/pzOoe8V5TN25grGVFzzs0ILYILvhhcm+IiogQCi7pj4fF oraOZU+0Uy2G5UZQcfJEaDzzaHyDokZ9GdqP1l5FxlAFg3eXlOX5IA6zD Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10491"; a="290419718" X-IronPort-AV: E=Sophos;i="5.95,161,1661842800"; d="scan'208";a="290419718" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2022 07:35:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10491"; a="619480558" X-IronPort-AV: E=Sophos;i="5.95,161,1661842800"; d="scan'208";a="619480558" Received: from silpixa00401385.ir.intel.com ([10.237.214.34]) by orsmga007.jf.intel.com with ESMTP; 05 Oct 2022 07:35:00 -0700 From: Bruce Richardson To: dev@dpdk.org Cc: techboard@dpdk.org, Bruce Richardson Subject: [PATCH 2/2] kni: add deprecation warning at runtime Date: Wed, 5 Oct 2022 15:34:51 +0100 Message-Id: <20221005143451.157613-2-bruce.richardson@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221005143451.157613-1-bruce.richardson@intel.com> References: <20221005143451.157613-1-bruce.richardson@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When KNI is being used at runtime, output a warning message about its deprecated status. This is part of the deprecation process for KNI agreed by the DPDK technical board.[1] [1] http://mails.dpdk.org/archives/dev/2022-June/243596.html Signed-off-by: Bruce Richardson --- doc/guides/rel_notes/deprecation.rst | 6 ++---- lib/kni/rte_kni.c | 2 ++ 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 6c2fc15c77..8d99ce5f2f 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -44,10 +44,8 @@ Deprecation Notices applications - other technologies such as virtio-user are recommended instead. Following the DPDK technical board `decision `_ - and `refinement `_: - - * Some deprecation warnings will be added in DPDK 22.11. - * The KNI kernel module, library and PMD will be removed from the DPDK 23.11. + and `refinement `_, + the KNI kernel module, library and PMD will be removed from the DPDK 23.11 release. * lib: will fix extending some enum/define breaking the ABI. There are multiple samples in DPDK that enum/define terminated with a ``.*MAX.*`` value which is diff --git a/lib/kni/rte_kni.c b/lib/kni/rte_kni.c index 7971c56bb4..eb7c10ff19 100644 --- a/lib/kni/rte_kni.c +++ b/lib/kni/rte_kni.c @@ -96,6 +96,8 @@ static volatile int kni_fd = -1; int rte_kni_init(unsigned int max_kni_ifaces __rte_unused) { + RTE_LOG(WARNING, KNI, "WARNING: KNI is deprecated and will be removed in DPDK 23.11\n"); + #if LINUX_VERSION_CODE < KERNEL_VERSION(4, 10, 0) if (rte_eal_iova_mode() != RTE_IOVA_PA) { RTE_LOG(ERR, KNI, "KNI requires IOVA as PA\n");