From patchwork Wed Nov 9 01:17:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Xing, Beilei" X-Patchwork-Id: 119569 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A27C7A0093; Wed, 9 Nov 2022 02:49:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 84639410DE; Wed, 9 Nov 2022 02:49:22 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id BA8A1400D4 for ; Wed, 9 Nov 2022 02:49:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667958560; x=1699494560; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=OXM0Z5AN6/MQhxnpH7YB5pxJQyqLfjMdA2CZr9YoI9Q=; b=cG0CwbXOnFwoQRS5KbrnMF40k9KRHiCMHc4AEY8aUPTyHZ7tAre49Ua/ OpXg0LgOes0XTsq6vteZv52PhtFGDneklTV2GNwXuRedJNsz+l6UKE4nw iFjvDpSD8QgVnOn6PVaNVEZ3Qg4jtE2T4xXqun/V5CGJuNWisQkk8fpBh 6//sOMoous36P4gkRywjnSQlulWlljn4K0TUF/KV1qtHGak9cvDTy7BZY IZz5KCTf8F9+MYD5FJN1/uxpWc600QkFvV7euMjcjxh50NYU6wExAOQ8V 5d9QjCwHpPWNKmLWxmsPjLBpjGJvn8dqF5dXtyIz6EAdm7tMMfwOS8pMF g==; X-IronPort-AV: E=McAfee;i="6500,9779,10525"; a="291247746" X-IronPort-AV: E=Sophos;i="5.96,149,1665471600"; d="scan'208";a="291247746" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2022 17:49:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10525"; a="705516888" X-IronPort-AV: E=Sophos;i="5.96,149,1665471600"; d="scan'208";a="705516888" Received: from dpdk-beileix-3.sh.intel.com ([10.67.110.253]) by fmsmga004.fm.intel.com with ESMTP; 08 Nov 2022 17:49:18 -0800 From: beilei.xing@intel.com To: jingjing.wu@intel.com Cc: dev@dpdk.org, yuan.peng@intel.com, Beilei Xing Subject: [PATCH] net/idpf: fix TSO issue Date: Wed, 9 Nov 2022 01:17:55 +0000 Message-Id: <20221109011755.7964-1-beilei.xing@intel.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Beilei Xing This patch fixes TSO by adding Tx checksum offload. Fixes: ed5b21acc67e ("net/idpf: support Tx offloading") Signed-off-by: Beilei Xing Tested-by: Peng, Yuan --- drivers/net/idpf/idpf_ethdev.c | 4 ++++ drivers/net/idpf/idpf_rxtx.c | 5 +++++ drivers/net/idpf/idpf_rxtx.h | 10 +++++++++- 3 files changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c index 50aac65daf..54e25390eb 100644 --- a/drivers/net/idpf/idpf_ethdev.c +++ b/drivers/net/idpf/idpf_ethdev.c @@ -71,6 +71,10 @@ idpf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) RTE_ETH_RX_OFFLOAD_TIMESTAMP; dev_info->tx_offload_capa = + RTE_ETH_TX_OFFLOAD_IPV4_CKSUM | + RTE_ETH_TX_OFFLOAD_UDP_CKSUM | + RTE_ETH_TX_OFFLOAD_TCP_CKSUM | + RTE_ETH_TX_OFFLOAD_SCTP_CKSUM | RTE_ETH_TX_OFFLOAD_TCP_TSO | RTE_ETH_TX_OFFLOAD_MULTI_SEGS | RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE; diff --git a/drivers/net/idpf/idpf_rxtx.c b/drivers/net/idpf/idpf_rxtx.c index bafa007faf..b338a67de7 100644 --- a/drivers/net/idpf/idpf_rxtx.c +++ b/drivers/net/idpf/idpf_rxtx.c @@ -1692,6 +1692,8 @@ idpf_splitq_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, if (unlikely((tx_id % 32) == 0)) txd->qw1.cmd_dtype |= IDPF_TXD_FLEX_FLOW_CMD_RE; + if (ol_flags & IDPF_TX_CKSUM_OFFLOAD_MASK) + txd->qw1.cmd_dtype |= IDPF_TXD_FLEX_FLOW_CMD_CS_EN; txq->nb_free = (uint16_t)(txq->nb_free - nb_used); txq->nb_used = (uint16_t)(txq->nb_used + nb_used); } @@ -2075,6 +2077,9 @@ idpf_singleq_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, txq->nb_used = 0; } + if (ol_flags & IDPF_TX_CKSUM_OFFLOAD_MASK) + td_cmd |= IDPF_TX_FLEX_DESC_CMD_CS_EN; + txd->qw1.cmd_dtype |= rte_cpu_to_le_16(td_cmd << IDPF_FLEX_TXD_QW1_CMD_S); } diff --git a/drivers/net/idpf/idpf_rxtx.h b/drivers/net/idpf/idpf_rxtx.h index a98f0285c8..730dc64ebc 100644 --- a/drivers/net/idpf/idpf_rxtx.h +++ b/drivers/net/idpf/idpf_rxtx.h @@ -69,7 +69,15 @@ #define IDPF_MAX_TSO_FRAME_SIZE 262143 #define IDPF_TX_MAX_MTU_SEG 10 -#define IDPF_TX_OFFLOAD_MASK RTE_MBUF_F_TX_TCP_SEG +#define IDPF_TX_CKSUM_OFFLOAD_MASK ( \ + RTE_MBUF_F_TX_IP_CKSUM | \ + RTE_MBUF_F_TX_L4_MASK | \ + RTE_MBUF_F_TX_TCP_SEG) + +#define IDPF_TX_OFFLOAD_MASK ( \ + IDPF_TX_CKSUM_OFFLOAD_MASK | \ + RTE_MBUF_F_TX_IPV4 | \ + RTE_MBUF_F_TX_IPV6) #define IDPF_TX_OFFLOAD_NOTSUP_MASK \ (RTE_MBUF_F_TX_OFFLOAD_MASK ^ IDPF_TX_OFFLOAD_MASK)