From patchwork Wed Nov 9 23:24:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 119674 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 78F6FA0093; Thu, 10 Nov 2022 00:25:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A7B9E42D28; Thu, 10 Nov 2022 00:25:03 +0100 (CET) Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by mails.dpdk.org (Postfix) with ESMTP id 10E3542D21 for ; Thu, 10 Nov 2022 00:25:02 +0100 (CET) Received: by mail-pf1-f170.google.com with SMTP id y203so178510pfb.4 for ; Wed, 09 Nov 2022 15:25:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oxp2qItKxyvIxvIPqZSW9JotSdGmvWXvGA1HWz5sGLE=; b=DPPBFItqspht99oQGvxWZ/c5NvtfHRJJhqAA6iFUH2PexY/XsCAtv8nPr0dRg5Jior iZTXO8RrEzPe/hMUOFQLZWSfcc2IpmzEi7ya9he6Tw4B9rqF+NhVKbC8U11g2woVCjvb hYS2a6qKdfBpqi6+gB4EWMalZt5gamBpQ03NaBigsv7bSpb3O28UQVGGYIJc079ZaXQh 204x5jCJtvaW1pc0H+STHkCdrYUUh3XOBW2bSayw3cVAe47YDdBEjd2Rm6K2pDtJzGwc We4xVv/XFtOay1pOVUo4+e+6mDWXtErK0aszTgOuNpGr8s2i8fhSGacvTGpyoazvsZca dGHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oxp2qItKxyvIxvIPqZSW9JotSdGmvWXvGA1HWz5sGLE=; b=GxoQDgBPPWCskWx+/fssL0QcxrMe2KxEg8SLtiJi0PozGWYGg3rICD7TITkv7BHsxo CLS0Bkg5c1ZAW9qZnfz+xXS3Bl37cRL17rn++f9cJbQMxIr65ffB6vKqfxXydCNd451+ vt3Tfotb02UuW/oEbPyi44ulutUoPCSMWeoirHhlM8gPwaV4YF6jY7XL+FkMpVHWqE9v 0g6ARKtGRLRO7zoIJWPRf1KrdBXwKjgN2FlieNnbN+5b19JFrKyD5PhHmOIggGb+MbrA jRWU52PqlpYlDOmFV+e5ixT589151fG/T1nnYBbDtcJoUYjqKhCKNEcZkAajin2Ks28G BzPA== X-Gm-Message-State: ACrzQf0drhSixng16ZiZDoWxqwSg2beu1sWB+2iwwm3mk7aUWjRxxbCS xA366a0jWGUvSnZ3aWejDSSXF6sTMTMrmQ== X-Google-Smtp-Source: AMsMyM7D3g5fEzwv2tEmKPe3BeKOmursidhKjDy3vCmjhKbU93ot3fM4ZNg22SOTDvv4gvD7jsB+ow== X-Received: by 2002:a62:e20e:0:b0:56c:6ec1:1f1e with SMTP id a14-20020a62e20e000000b0056c6ec11f1emr1345316pfi.7.1668036300896; Wed, 09 Nov 2022 15:25:00 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id y28-20020aa79e1c000000b0056e15b7138esm8798645pfq.157.2022.11.09.15.24.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 15:25:00 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Aman Singh , Yuying Zhang Subject: [PATCH v3 05/14] testpmd: fix whitespace Date: Wed, 9 Nov 2022 15:24:42 -0800 Message-Id: <20221109232451.265059-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221109232451.265059-1-stephen@networkplumber.org> References: <20221109191445.140320-1-stephen@networkplumber.org> <20221109232451.265059-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add space after keywords. Signed-off-by: Stephen Hemminger Reviewed-by: Yuying Zhang --- app/test-pmd/cmdline.c | 31 ++++++++++++++++--------------- app/test-pmd/parameters.c | 10 ++++++---- app/test-pmd/testpmd.c | 2 +- 3 files changed, 23 insertions(+), 20 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 8dc60e938830..7721006cc310 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -2730,11 +2730,12 @@ parse_reta_config(const char *str, while ((p = strchr(p0,'(')) != NULL) { ++p; - if((p0 = strchr(p,')')) == NULL) + p0 = strchr(p, ')'); + if (p0 == NULL) return -1; size = p0 - p; - if(size >= sizeof(s)) + if (size >= sizeof(s)) return -1; snprintf(s, sizeof(s), "%.*s", size, p); @@ -3242,15 +3243,15 @@ cmd_config_thresh_parsed(void *parsed_result, if (!strcmp(res->name, "txpt")) tx_pthresh = res->value; - else if(!strcmp(res->name, "txht")) + else if (!strcmp(res->name, "txht")) tx_hthresh = res->value; - else if(!strcmp(res->name, "txwt")) + else if (!strcmp(res->name, "txwt")) tx_wthresh = res->value; - else if(!strcmp(res->name, "rxpt")) + else if (!strcmp(res->name, "rxpt")) rx_pthresh = res->value; - else if(!strcmp(res->name, "rxht")) + else if (!strcmp(res->name, "rxht")) rx_hthresh = res->value; - else if(!strcmp(res->name, "rxwt")) + else if (!strcmp(res->name, "rxwt")) rx_wthresh = res->value; else { fprintf(stderr, "Unknown parameter\n"); @@ -4088,8 +4089,8 @@ cmd_vlan_offload_parsed(void *parsed_result, len = strnlen(str, STR_TOKEN_SIZE); i = 0; /* Get port_id first */ - while(i < len){ - if(str[i] == ',') + while (i < len) { + if (str[i] == ',') break; i++; @@ -4097,7 +4098,7 @@ cmd_vlan_offload_parsed(void *parsed_result, str[i]='\0'; tmp = strtoul(str, NULL, 0); /* If port_id greater that what portid_t can represent, return */ - if(tmp >= RTE_MAX_ETHPORTS) + if (tmp >= RTE_MAX_ETHPORTS) return; port_id = (portid_t)tmp; @@ -4108,17 +4109,17 @@ cmd_vlan_offload_parsed(void *parsed_result, if (!strcmp(res->what, "strip")) rx_vlan_strip_set(port_id, on); - else if(!strcmp(res->what, "stripq")){ + else if (!strcmp(res->what, "stripq")) { uint16_t queue_id = 0; /* No queue_id, return */ - if(i + 1 >= len) { + if (i + 1 >= len) { fprintf(stderr, "must specify (port,queue_id)\n"); return; } tmp = strtoul(str + i + 1, NULL, 0); /* If queue_id greater that what 16-bits can represent, return */ - if(tmp > 0xffff) + if (tmp > 0xffff) return; queue_id = (uint16_t)tmp; @@ -7207,7 +7208,7 @@ static void cmd_mac_addr_parsed(void *parsed_result, ret = rte_eth_dev_mac_addr_remove(res->port_num, &res->address); /* check the return value and print it if is < 0 */ - if(ret < 0) + if (ret < 0) fprintf(stderr, "mac_addr_cmd error: (%s)\n", strerror(-ret)); } @@ -7780,7 +7781,7 @@ static void cmd_vf_mac_addr_parsed(void *parsed_result, res->vf_num); #endif - if(ret < 0) + if (ret < 0) fprintf(stderr, "vf_mac_addr_cmd error: (%s)\n", strerror(-ret)); } diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index aed4cdcb8485..7fc6d91f0210 100644 --- a/app/test-pmd/parameters.c +++ b/app/test-pmd/parameters.c @@ -306,11 +306,12 @@ parse_portnuma_config(const char *q_arg) /* reset from value set at definition */ while ((p = strchr(p0,'(')) != NULL) { ++p; - if((p0 = strchr(p,')')) == NULL) + p0 = strchr(p, ')'); + if (p0 == NULL) return -1; size = p0 - p; - if(size >= sizeof(s)) + if (size >= sizeof(s)) return -1; snprintf(s, sizeof(s), "%.*s", size, p); @@ -366,11 +367,12 @@ parse_ringnuma_config(const char *q_arg) /* reset from value set at definition */ while ((p = strchr(p0,'(')) != NULL) { ++p; - if((p0 = strchr(p,')')) == NULL) + p0 = strchr(p, ')'); + if (p0 == NULL) return -1; size = p0 - p; - if(size >= sizeof(s)) + if (size >= sizeof(s)) return -1; snprintf(s, sizeof(s), "%.*s", size, p); diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index aa7ea29f15ba..04b078a2938b 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2406,7 +2406,7 @@ start_packet_forwarding(int with_tx_first) test_done = 0; - if(!no_flush_rx) + if (!no_flush_rx) flush_fwd_rx_queues(); rxtx_config_display();