[v2] crypto/ccp: bug fixes for ccp device probe flow
Checks
Commit Message
- Rebasing patch([v1] crypto/ccp: bug fixes for ccp device probe flow)
Signed-off-by: Sunil Uttarwar <sunilprakashrao.uttarwar@amd.com>
---
drivers/crypto/ccp/rte_ccp_pmd.c | 8 --------
1 file changed, 8 deletions(-)
Comments
> Subject: [EXT] [PATCH v2] crypto/ccp: bug fixes for ccp device probe flow
> - Rebasing patch([v1] crypto/ccp: bug fixes for ccp device probe flow)
Please write a meaningful patch title and description
Also add fixes tag.
Add Cc stable@dpdk.org so that fix can be backported.
>
> Signed-off-by: Sunil Uttarwar <sunilprakashrao.uttarwar@amd.com>
> ---
> drivers/crypto/ccp/rte_ccp_pmd.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/crypto/ccp/rte_ccp_pmd.c
> b/drivers/crypto/ccp/rte_ccp_pmd.c
> index a5271d7227..5d1a4445de 100644
> --- a/drivers/crypto/ccp/rte_ccp_pmd.c
> +++ b/drivers/crypto/ccp/rte_ccp_pmd.c
> @@ -19,7 +19,6 @@
> /**
> * Global static parameter used to find if CCP device is already initialized.
> */
> -static unsigned int ccp_pmd_init_done;
> uint8_t ccp_cryptodev_driver_id;
> uint8_t cryptodev_cnt;
>
> @@ -192,8 +191,6 @@ cryptodev_ccp_remove(struct rte_pci_device *pci_dev)
> if (dev == NULL)
> return -ENODEV;
>
> - ccp_pmd_init_done = 0;
> -
> RTE_LOG(INFO, PMD, "Closing ccp device %s on numa socket %u\n",
> name, rte_socket_id());
>
> @@ -278,10 +275,6 @@ cryptodev_ccp_probe(struct rte_pci_driver *pci_drv
> __rte_unused,
> .auth_opt = CCP_PMD_AUTH_OPT_CCP,
> };
>
> - if (ccp_pmd_init_done) {
> - RTE_LOG(INFO, PMD, "CCP PMD already initialized\n");
> - return -EFAULT;
> - }
> rte_pci_device_name(&pci_dev->addr, name, sizeof(name));
> if (name[0] == '\0')
> return -EINVAL;
> @@ -300,7 +293,6 @@ cryptodev_ccp_probe(struct rte_pci_driver *pci_drv
> __rte_unused,
> rc = cryptodev_ccp_create(name, pci_dev, &init_params, pci_drv);
> if (rc)
> return rc;
> - ccp_pmd_init_done = 1;
> return 0;
> }
>
> --
> 2.25.1
> Subject: RE: [EXT] [PATCH v2] crypto/ccp: bug fixes for ccp device probe flow
>
> > Subject: [EXT] [PATCH v2] crypto/ccp: bug fixes for ccp device probe flow
> > - Rebasing patch([v1] crypto/ccp: bug fixes for ccp device probe flow)
>
> Please write a meaningful patch title and description
> Also add fixes tag.
> Add Cc stable@dpdk.org so that fix can be backported.
Can you send the next version, need to close tree for RC3
@@ -19,7 +19,6 @@
/**
* Global static parameter used to find if CCP device is already initialized.
*/
-static unsigned int ccp_pmd_init_done;
uint8_t ccp_cryptodev_driver_id;
uint8_t cryptodev_cnt;
@@ -192,8 +191,6 @@ cryptodev_ccp_remove(struct rte_pci_device *pci_dev)
if (dev == NULL)
return -ENODEV;
- ccp_pmd_init_done = 0;
-
RTE_LOG(INFO, PMD, "Closing ccp device %s on numa socket %u\n",
name, rte_socket_id());
@@ -278,10 +275,6 @@ cryptodev_ccp_probe(struct rte_pci_driver *pci_drv __rte_unused,
.auth_opt = CCP_PMD_AUTH_OPT_CCP,
};
- if (ccp_pmd_init_done) {
- RTE_LOG(INFO, PMD, "CCP PMD already initialized\n");
- return -EFAULT;
- }
rte_pci_device_name(&pci_dev->addr, name, sizeof(name));
if (name[0] == '\0')
return -EINVAL;
@@ -300,7 +293,6 @@ cryptodev_ccp_probe(struct rte_pci_driver *pci_drv __rte_unused,
rc = cryptodev_ccp_create(name, pci_dev, &init_params, pci_drv);
if (rc)
return rc;
- ccp_pmd_init_done = 1;
return 0;
}