From patchwork Fri Mar 10 08:57:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 124986 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6E4F41E0F; Fri, 10 Mar 2023 09:57:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C59E440ED9; Fri, 10 Mar 2023 09:57:19 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id BB26D40685 for ; Fri, 10 Mar 2023 09:57:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678438638; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=b6iJ2OuyeTywZEEfWaP6wosNuI2fjepKktHTxMxYE6U=; b=QVDXazVRp7P3AFAR5KjTygHa7myBN+fYhOAOfdx8FNpbBLdqFtchLnzQtQYY4CRoHa496q biT0lTJxUGe9lSYe1BFu4heH6uER9VF2nLhP6sU+c2pHhFUGmWkImTXs+utKAsehVBTniw ClOvYi0JKTWtAjA023GnIKzXhahpVXw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-479-WsAfyMjtNUCvRrRLeE4iDg-1; Fri, 10 Mar 2023 03:57:15 -0500 X-MC-Unique: WsAfyMjtNUCvRrRLeE4iDg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BCDD6800B23; Fri, 10 Mar 2023 08:57:14 +0000 (UTC) Received: from dmarchan.redhat.com (unknown [10.45.224.63]) by smtp.corp.redhat.com (Postfix) with ESMTP id EA4F8C15BA0; Fri, 10 Mar 2023 08:57:13 +0000 (UTC) From: David Marchand To: dev@dpdk.org, thomas@monjalon.net Cc: Srikanth Yalavarthi Subject: [PATCH] mldev: fix build for aarch32 Date: Fri, 10 Mar 2023 09:57:11 +0100 Message-Id: <20230310085711.1366455-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Caught by UNH lab, cross compiling for aarch32: ../lib/mldev/mldev_utils_neon.c: In function '__float32_to_int8_neon_s8x8': ../lib/mldev/mldev_utils_neon.c:34:10: error: implicit declaration of function 'vcvtaq_s32_f32'; did you mean 'vcvtq_s32_f32'? [-Werror=implicit-function-declaration] 34 | s32x4 = vcvtaq_s32_f32(f32x4); | ^~~~~~~~~~~~~~ | vcvtq_s32_f32 ../lib/mldev/mldev_utils_neon.c:34:10: error: nested extern declaration of 'vcvtaq_s32_f32' [-Werror=nested-externs] ../lib/mldev/mldev_utils_neon.c:34:10: error: incompatible types when assigning to type 'int32x4_t' from type 'int' ../lib/mldev/mldev_utils_neon.c:42:10: error: incompatible types when assigning to type 'int32x4_t' from type 'int' 42 | s32x4 = vcvtaq_s32_f32(f32x4); | ^~~~~~~~~~~~~~ Only compile NEON optimisation for aarch64. Fixes: fc54766b1612 ("mldev: add Arm NEON type conversion") Signed-off-by: David Marchand --- lib/mldev/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/mldev/meson.build b/lib/mldev/meson.build index 05694b0839..23d108617d 100644 --- a/lib/mldev/meson.build +++ b/lib/mldev/meson.build @@ -8,7 +8,7 @@ sources = files( 'mldev_utils_scalar.c', ) -if arch_subdir == 'arm' +if dpdk_conf.has('RTE_ARCH_ARM64') sources += files('mldev_utils_neon.c') endif