Message ID | 20230418082529.544777-2-sivaprasad.tummala@amd.com (mailing list archive) |
---|---|
State | Deferred, archived |
Delegated to: | David Marchand |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C9674297B; Tue, 18 Apr 2023 10:26:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 03DA542D1D; Tue, 18 Apr 2023 10:26:03 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by mails.dpdk.org (Postfix) with ESMTP id 3FBAA41144 for <dev@dpdk.org>; Tue, 18 Apr 2023 10:25:59 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hsr1AJImO1TfbP4Mhn4TcBoQ+8EZj+yuFZdWKTdkd59x75FpzjOgWB1F6GjUq5aZFRtXNvIixXFPpOUO77b9MKWBTAzhzRCbwdV3aQOYk/ZuCCjp83hMJwTfhCrfWE24jJB3Of68Uu/HD55E0UTR03csdl0YLFvP2dqguqtxEuaRo1msrXDkXO+RCTQDv34IGkXQ7PSuw0h+P7O+ok9nf0u3Fvqhv3TcndKR2QO0sHubbmoLuEc+n1rOiCYqtT2+tAOvbdKKAJ87N1ngZ5guu1XfJ2R/W3LEKeEcqjEnUpH5mlsK/q/0fA/43MWuWJyTC+dMMmkJzCnHTiRMeODQxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iXfbbUwYLji8ewfVcgq+kPKrTKgAjpQrVEO056AAvls=; b=NsBCMdWnCnXOfOksxvHritJ20cs1CEK2N9ysk+nb4b/cgBk6dshBSDt3goN3nVU4jrtNOxLn/Mpfn/MzhsT9MaVN++xg5TVUXEwfIFZHfnoSPad567LTY8u0SxbHVaq29w91qf2FG3JKNs3CkFTJfVmmgHneVE4BLQrKadMEVYRftxBFDLEVH68hgeOMJfBRRh4MY+bd6QGRtpTvL+4tIfl/Zxlqv7TDBVFaoBkgvfoQO+fsfA0p1ijSZCQipN9FiepKzJQkdl02QCjn/qX5iYzP16fq/ZuRXjlS3P+rt3Hu1hl4fzwqxB0BEYaoQoA+W8g4fVqVS2V4Ef3Fmg06cA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iXfbbUwYLji8ewfVcgq+kPKrTKgAjpQrVEO056AAvls=; b=Ne8R+a8iu4yPSAOAXvJJZcxF0Je2/f94aIIh4CR3HU9X0QdDHRCjycybO31GuED66Rg3d6TlGCK2LZsXHDwp9YFqMYgVBPX6g8VZo9K1d+ydTr1Vdfo3Do+xMPA4SEZQrLndPUky/K7ivAVz1RxC+HNntfA2Bt2x8Wzv/xy8zl8= Received: from BN9PR03CA0422.namprd03.prod.outlook.com (2603:10b6:408:113::7) by SJ0PR12MB5612.namprd12.prod.outlook.com (2603:10b6:a03:427::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.45; Tue, 18 Apr 2023 08:25:56 +0000 Received: from BN8NAM11FT067.eop-nam11.prod.protection.outlook.com (2603:10b6:408:113:cafe::81) by BN9PR03CA0422.outlook.office365.com (2603:10b6:408:113::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.47 via Frontend Transport; Tue, 18 Apr 2023 08:25:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT067.mail.protection.outlook.com (10.13.177.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6319.20 via Frontend Transport; Tue, 18 Apr 2023 08:25:55 +0000 Received: from telco-siena.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 18 Apr 2023 03:25:51 -0500 From: Sivaprasad Tummala <sivaprasad.tummala@amd.com> To: <david.hunt@intel.com> CC: <dev@dpdk.org>, <david.marchand@redhat.com>, <ferruh.yigit@amd.com> Subject: [PATCH v4 1/4] doc: announce new cpu flag added to rte_cpu_flag_t Date: Tue, 18 Apr 2023 01:25:26 -0700 Message-ID: <20230418082529.544777-2-sivaprasad.tummala@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230418082529.544777-1-sivaprasad.tummala@amd.com> References: <20230417043136.470110-1-sivaprasad.tummala@amd.com> <20230418082529.544777-1-sivaprasad.tummala@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT067:EE_|SJ0PR12MB5612:EE_ X-MS-Office365-Filtering-Correlation-Id: d1467d7f-2c4d-4dc4-d1b1-08db3fe687dc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VxBEaUf66XyozUHvNy0hzTsSW0Ia8HK9K/94gLwVA9+F4u8U8F7QrQzRzowoCsfxgOIfY0bvs64HZbtUzHMrv6E1t5Z/tJFOdMMXaiTvSwXf7E9GDYUk/hdigyiivgcsFYGSARlqxUh60sY+Uz7XI2Ulq50Yxgw5WYJJ0smB7MNeeUg3hZEMw2Uc0Jc+Ms6jmC2W/b+ZgzzwETG7JDbnTVowea299kmJUE3g4LM/lYcvivBHb7HIMHvTuGeLwQnuM8SWRaiJGrEzskcT6kkdhHwWZLXPf7NxApPFhYgM0aJMzys8JLuriMXhGWdQuhQJEFLNoV6YlYxWGDyKbx0fKkIn7zieAnQJ3a1ttkDtYi2Jpyc9rxNGcC9rbbFQg3oJz8RYVKblgI7/OQd9bqwbFpBZcKlxPBydvFArNkyGwOfDxwRiO077G2//gDlJyJfVsF2AWXGNm5WqQk4feG8j2EDZa6jHWBmZ3g0/AHbJGth56aMr1UuvLA6F6A1Go266sa48OxZ6T1oTXbFA1vrKWLkFCGMV/PgLfZxN5nl26TKdHFX/A8i6GnPdzWifpsbiC/DhFsROSwBF6EuQQ/g2wUeO0sQ8LofEFOZBpvaiqUGEFp+TcVobaw0SJdkBp4x8NBLMELONwccmMZk2LyQJbmDvuGQI3ENKBuSPVvFtLnrp8oZMyl54Tbi9MpG+3q2ZGUHoUcWSPz8XOStciTJaZjrLZIoysMDADb1+BpJxpsw= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230028)(4636009)(396003)(39860400002)(136003)(376002)(346002)(451199021)(46966006)(36840700001)(40470700004)(478600001)(6666004)(8936002)(8676002)(316002)(41300700001)(82740400003)(6916009)(4326008)(70586007)(70206006)(40480700001)(81166007)(54906003)(356005)(40460700003)(16526019)(186003)(4744005)(2906002)(1076003)(336012)(426003)(26005)(86362001)(83380400001)(36756003)(47076005)(82310400005)(2616005)(36860700001)(5660300002)(7696005)(44832011)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2023 08:25:55.7012 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d1467d7f-2c4d-4dc4-d1b1-08db3fe687dc X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT067.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5612 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
[v4,1/4] doc: announce new cpu flag added to rte_cpu_flag_t
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/iol-testing | warning | apply patch failure |
Commit Message
Sivaprasad Tummala
April 18, 2023, 8:25 a.m. UTC
A new flag RTE_CPUFLAG_MONITORX is added to rte_cpu_flag_t in
DPDK 23.07 release to support monitorx instruction on EPYC processors.
This results in ABI breakage for legacy apps.
Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
---
doc/guides/rel_notes/deprecation.rst | 3 +++
1 file changed, 3 insertions(+)
Comments
On 4/18/2023 9:25 AM, Sivaprasad Tummala wrote: > A new flag RTE_CPUFLAG_MONITORX is added to rte_cpu_flag_t in > DPDK 23.07 release to support monitorx instruction on EPYC processors. > This results in ABI breakage for legacy apps. > > Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com> > --- > doc/guides/rel_notes/deprecation.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index dcc1ca1696..831713983f 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -163,3 +163,6 @@ Deprecation Notices > The new port library API (functions rte_swx_port_*) > will gradually transition from experimental to stable status > starting with DPDK 23.07 release. > + > +* eal/x86: The enum ``rte_cpu_flag_t`` will be extended with a new cpu flag > + ``RTE_CPUFLAG_MONITORX`` to support monitorx instruction on EPYC processors. OK to add new CPU flag, Acked-by: Ferruh Yigit <ferruh.yigit@amd.com> But @David, @Bruce, is it OK to break ABI whenever a new CPU flag is added, should we hide CPU flags better? Or other option can be drop the 'RTE_CPUFLAG_NUMFLAGS' and allow appending new flags to the end although this may lead enum become more messy by time.
On Tue, Apr 18, 2023 at 09:52:49AM +0100, Ferruh Yigit wrote: > On 4/18/2023 9:25 AM, Sivaprasad Tummala wrote: > > A new flag RTE_CPUFLAG_MONITORX is added to rte_cpu_flag_t in > > DPDK 23.07 release to support monitorx instruction on EPYC processors. > > This results in ABI breakage for legacy apps. > > > > Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com> > > --- > > doc/guides/rel_notes/deprecation.rst | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > > index dcc1ca1696..831713983f 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -163,3 +163,6 @@ Deprecation Notices > > The new port library API (functions rte_swx_port_*) > > will gradually transition from experimental to stable status > > starting with DPDK 23.07 release. > > + > > +* eal/x86: The enum ``rte_cpu_flag_t`` will be extended with a new cpu flag > > + ``RTE_CPUFLAG_MONITORX`` to support monitorx instruction on EPYC processors. > > > OK to add new CPU flag, > Acked-by: Ferruh Yigit <ferruh.yigit@amd.com> > > > But @David, @Bruce, is it OK to break ABI whenever a new CPU flag is > added, should we hide CPU flags better? > > Or other option can be drop the 'RTE_CPUFLAG_NUMFLAGS' and allow > appending new flags to the end although this may lead enum become more > messy by time. +1 top drop the NUMFLAGS value. We should not break ABI each time we need a new flag.
On Tue, Apr 18, 2023 at 11:22 AM Bruce Richardson <bruce.richardson@intel.com> wrote: > > On Tue, Apr 18, 2023 at 09:52:49AM +0100, Ferruh Yigit wrote: > > On 4/18/2023 9:25 AM, Sivaprasad Tummala wrote: > > > A new flag RTE_CPUFLAG_MONITORX is added to rte_cpu_flag_t in > > > DPDK 23.07 release to support monitorx instruction on EPYC processors. > > > This results in ABI breakage for legacy apps. > > > > > > Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com> > > > --- > > > doc/guides/rel_notes/deprecation.rst | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > > > index dcc1ca1696..831713983f 100644 > > > --- a/doc/guides/rel_notes/deprecation.rst > > > +++ b/doc/guides/rel_notes/deprecation.rst > > > @@ -163,3 +163,6 @@ Deprecation Notices > > > The new port library API (functions rte_swx_port_*) > > > will gradually transition from experimental to stable status > > > starting with DPDK 23.07 release. > > > + > > > +* eal/x86: The enum ``rte_cpu_flag_t`` will be extended with a new cpu flag > > > + ``RTE_CPUFLAG_MONITORX`` to support monitorx instruction on EPYC processors. There is no need for announcing an addition. The problem is moving/removing other elements of an enum. > > > > > > OK to add new CPU flag, > > Acked-by: Ferruh Yigit <ferruh.yigit@amd.com> > > > > > > But @David, @Bruce, is it OK to break ABI whenever a new CPU flag is > > added, should we hide CPU flags better? > > > > Or other option can be drop the 'RTE_CPUFLAG_NUMFLAGS' and allow > > appending new flags to the end although this may lead enum become more > > messy by time. > > +1 top drop the NUMFLAGS value. We should not break ABI each time we need a > new flag. +1. So in 23.07 we need an announce for this removal to happen in 23.11.
18/04/2023 09:25, Sivaprasad Tummala пишет: > A new flag RTE_CPUFLAG_MONITORX is added to rte_cpu_flag_t in > DPDK 23.07 release to support monitorx instruction on EPYC processors. > This results in ABI breakage for legacy apps. > > Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com> > --- > doc/guides/rel_notes/deprecation.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index dcc1ca1696..831713983f 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -163,3 +163,6 @@ Deprecation Notices > The new port library API (functions rte_swx_port_*) > will gradually transition from experimental to stable status > starting with DPDK 23.07 release. > + > +* eal/x86: The enum ``rte_cpu_flag_t`` will be extended with a new cpu flag > + ``RTE_CPUFLAG_MONITORX`` to support monitorx instruction on EPYC processors. Acked-by: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index dcc1ca1696..831713983f 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -163,3 +163,6 @@ Deprecation Notices The new port library API (functions rte_swx_port_*) will gradually transition from experimental to stable status starting with DPDK 23.07 release. + +* eal/x86: The enum ``rte_cpu_flag_t`` will be extended with a new cpu flag + ``RTE_CPUFLAG_MONITORX`` to support monitorx instruction on EPYC processors.