From patchwork Fri Apr 28 14:46:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tejasree Kondoj X-Patchwork-Id: 126628 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8048D42A12; Fri, 28 Apr 2023 16:47:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A987942DBF; Fri, 28 Apr 2023 16:47:00 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 9538942DBC for ; Fri, 28 Apr 2023 16:46:59 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33SEOFeP007059 for ; Fri, 28 Apr 2023 07:46:59 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=rpxoT73iKnsrZr/p16f2v7/5jLU0cTjMXi3m+VES8sw=; b=c/wVx9e/Vv6nPHnPbwQQzRM2HVXZrGZI5dG0ZK/PzxeuUOtfS5PRyDpR1PwKqpMaHKmT VvW17Mlk215WOdLkccCvvIFEpu3o4Qvxy6P6ZR8SfM4pTaO+tIZgWfRakQqhT7wJ0wen j08e+8S3eQM7BSIUTrcmqlBL/eeDlL6h3C9OIg2wPxGYLqOwyybOzTG3cBcQTQFp3s1i hRNVyYA/Gc3cpXYsKprSHzZ6mzEVyMmeXaB/as4wR2bn/TxEIyGKDSzYCLUlc7YY9h4Y uydH8KeIgvlutWR+KzOJNUZpcZ23nTWEzWkCa2Qdu8QM/16WUHg7rl1gOEkKL+4nUlGL 7w== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3q781hydx3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Fri, 28 Apr 2023 07:46:58 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Fri, 28 Apr 2023 07:46:56 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Fri, 28 Apr 2023 07:46:56 -0700 Received: from HY-LT1085.marvell.com (unknown [10.193.84.114]) by maili.marvell.com (Postfix) with ESMTP id CAAE15B6930; Fri, 28 Apr 2023 07:46:53 -0700 (PDT) From: Tejasree Kondoj To: Akhil Goyal CC: Anoob Joseph , Jerin Jacob , Aakash Sasidharan , Gowrishankar Muthukrishnan , Vidya Sagar Velumuri , Subject: [PATCH 1/7] crypto/cnxk: return error for unsupported paths Date: Fri, 28 Apr 2023 20:16:41 +0530 Message-ID: <20230428144647.1072-2-ktejasree@marvell.com> X-Mailer: git-send-email 2.40.1.windows.1 In-Reply-To: <20230428144647.1072-1-ktejasree@marvell.com> References: <20230428144647.1072-1-ktejasree@marvell.com> MIME-Version: 1.0 X-Proofpoint-GUID: -Y9fAl07OGLn-QncfTuhob47PF_boysD X-Proofpoint-ORIG-GUID: -Y9fAl07OGLn-QncfTuhob47PF_boysD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-28_04,2023-04-27_01,2023-02-09_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Returning error in control path for unsupported algorithm combinations. Signed-off-by: Tejasree Kondoj --- drivers/common/cnxk/roc_se.c | 12 +++++++++--- drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 5 +++++ 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/common/cnxk/roc_se.c b/drivers/common/cnxk/roc_se.c index 5a894013a6..aad2b513c7 100644 --- a/drivers/common/cnxk/roc_se.c +++ b/drivers/common/cnxk/roc_se.c @@ -329,6 +329,11 @@ roc_se_auth_key_set(struct roc_se_ctx *se_ctx, roc_se_auth_type type, if (!key_len) return -1; + if (se_ctx->fc_type == ROC_SE_FC_GEN) { + plt_err("Cipher and Auth algorithm combination is not supported"); + return -1; + } + if (roc_model_is_cn9k()) { ci_key = zs_ctx->zuc.onk_ctx.ci_key; zuc_const = zs_ctx->zuc.onk_ctx.zuc_const; @@ -454,12 +459,13 @@ roc_se_auth_key_set(struct roc_se_ctx *se_ctx, roc_se_auth_type type, return 0; } - if (!se_ctx->fc_type || - (type && type != ROC_SE_GMAC_TYPE && !se_ctx->enc_cipher)) + if (!se_ctx->fc_type || (type && type != ROC_SE_GMAC_TYPE && !se_ctx->enc_cipher)) se_ctx->fc_type = ROC_SE_HASH_HMAC; - if (se_ctx->fc_type == ROC_SE_FC_GEN && key_len > 64) + if (se_ctx->fc_type == ROC_SE_FC_GEN && key_len > 64) { + plt_err("Maximum auth key length supported is 64"); return -1; + } /* For GMAC auth, cipher must be NULL */ if (type == ROC_SE_GMAC_TYPE) { diff --git a/drivers/crypto/cnxk/cnxk_cryptodev_ops.c b/drivers/crypto/cnxk/cnxk_cryptodev_ops.c index 86efe75cc3..0f59a6c99c 100644 --- a/drivers/crypto/cnxk/cnxk_cryptodev_ops.c +++ b/drivers/crypto/cnxk/cnxk_cryptodev_ops.c @@ -551,6 +551,11 @@ cnxk_sess_fill(struct roc_cpt *roc_cpt, struct rte_crypto_sym_xform *xform, return -EINVAL; } + if (c_xfrm->cipher.algo == RTE_CRYPTO_CIPHER_AES_XTS) { + plt_err("AES XTS with auth algorithm is not supported"); + return -ENOTSUP; + } + if (c_xfrm->cipher.algo == RTE_CRYPTO_CIPHER_3DES_CBC && a_xfrm->auth.algo == RTE_CRYPTO_AUTH_SHA1) { plt_dp_err("3DES-CBC + SHA1 is not supported");