From patchwork Fri May 19 17:45:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 127118 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 546CE42B4B; Fri, 19 May 2023 19:46:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 964EF42D59; Fri, 19 May 2023 19:46:23 +0200 (CEST) Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by mails.dpdk.org (Postfix) with ESMTP id 7A0E042D46 for ; Fri, 19 May 2023 19:46:21 +0200 (CEST) Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-24e147c2012so854921a91.1 for ; Fri, 19 May 2023 10:46:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1684518380; x=1687110380; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mQOZXysbMxBdYXC4hBo8txdRgrIlJ+FKZjItfbewRrU=; b=tc1qDCKUFMFXsBD1A9rcsmM9eESM3s4qnvJF/OsBvUjLbXD7es0WijJzGjiKdsCWv1 sTiM+vhjFG24EJeo2DURhqVAXIdmAcoeN+h8yU3duMSdPuRU9DY4UsO5eWpFNKFEvhF0 JyHInM8VZOwwxqiYjMaelPsDgHv/+SI2mWpFhjLrczx/OEL5C/BiRcAoKPIyKbn6Di4r O8PX8UgiNisRPkO9MWbLIolVoDXLi+0nS+Nk/+NEOKYovI0M0e5KmrExWQTkqvcwTksS NdquQtzCvPfugKtk33OJLBU3x/Ud6A+Ut9mCoMe9LP2jTfIvWFZIBx2E46+2sb2cVkAx GlGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684518380; x=1687110380; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mQOZXysbMxBdYXC4hBo8txdRgrIlJ+FKZjItfbewRrU=; b=LvXSxwQf4RtliGm5G1UFwUTQ74FHra2Un2SHfTxfavRefkxRVDeIYOEYW3E513F4tT 4kgaqkFtBEHEikNTu5ByNZUriVG5f8ke+mzaNyEja8K5vSjBpOLv0Wy8UcigxctKGTqU mUXEXyDchcfT3mnDmdJCxz3E3Q37H2v+qkxR3ALU+Kr6FkUOvNhGLtDQAV9cnYFe1KdB +keYrNa8sLMgngkt5KVlT+joIKSaYdrl1doY+pmp+9NHnsBt3VbsT7jorp6e0y5z07vQ uUSDYAM4aOPgPuQZubW7eWrIc9QjMfK/xr2Z3S+KRXMAd5m7mgDZa8bDraBiYPNQH041 Wfow== X-Gm-Message-State: AC+VfDyQGXXEJ1ftXlmFNhdgQ2W34MwlRx+xB+mxbzslrnIl0Oxvf7es UsrTh7fCVsrxYlAWOxyBdaeVTaKyztam/QttiGiBQw== X-Google-Smtp-Source: ACHHUZ6p/2hLEOUmwMK9KspPqt5OJWp6sW/mlgi3yCwHozbhg29pmtWKVW8ndwMiDJrPOl4gJT0Ldw== X-Received: by 2002:a17:90a:6e03:b0:252:b345:7953 with SMTP id b3-20020a17090a6e0300b00252b3457953mr6709452pjk.24.1684518380385; Fri, 19 May 2023 10:46:20 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id e3-20020a170902744300b001aaf2e7b06csm3713101plt.132.2023.05.19.10.46.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 May 2023 10:46:20 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jerin Jacob , Kiran Kumar K , Nithin Dabilpuram , Reshma Pattan Subject: [PATCH v3 05/19] lib: replace use of sanity check in comments and messages Date: Fri, 19 May 2023 10:45:57 -0700 Message-Id: <20230519174611.11232-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230519174611.11232-1-stephen@networkplumber.org> References: <20230517161603.117728-1-stephen@networkplumber.org> <20230519174611.11232-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sanity check is on the Tier 2 non-inclusive list. Replace or remove it. Signed-off-by: Stephen Hemminger --- lib/graph/graph.c | 2 +- lib/graph/graph_stats.c | 2 +- lib/graph/node.c | 2 +- lib/jobstats/rte_jobstats.c | 6 +++--- lib/metrics/rte_metrics.c | 2 +- lib/pcapng/rte_pcapng.c | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/graph/graph.c b/lib/graph/graph.c index 5582631b5301..597e9e7aa28e 100644 --- a/lib/graph/graph.c +++ b/lib/graph/graph.c @@ -283,7 +283,7 @@ rte_graph_create(const char *name, struct rte_graph_param *prm) graph_spinlock_lock(); - /* Check arguments sanity */ + /* Check argument validity */ if (prm == NULL) SET_ERR_JMP(EINVAL, fail, "Param should not be NULL"); diff --git a/lib/graph/graph_stats.c b/lib/graph/graph_stats.c index c0140ba92212..28d5728e5e61 100644 --- a/lib/graph/graph_stats.c +++ b/lib/graph/graph_stats.c @@ -271,7 +271,7 @@ rte_graph_cluster_stats_create(const struct rte_graph_cluster_stats_param *prm) const char *pattern; rte_graph_t i; - /* Sanity checks */ + /* Validate arguments */ if (!rte_graph_has_stats_feature()) SET_ERR_JMP(EINVAL, fail, "Stats feature is not enabled"); diff --git a/lib/graph/node.c b/lib/graph/node.c index 149414dcd94c..3f0ae0c395db 100644 --- a/lib/graph/node.c +++ b/lib/graph/node.c @@ -68,7 +68,7 @@ __rte_node_register(const struct rte_node_register *reg) graph_spinlock_lock(); - /* Check sanity */ + /* Check argument validity */ if (reg == NULL || reg->process == NULL) { rte_errno = EINVAL; goto fail; diff --git a/lib/jobstats/rte_jobstats.c b/lib/jobstats/rte_jobstats.c index af565a14eaf3..1c4b280c952a 100644 --- a/lib/jobstats/rte_jobstats.c +++ b/lib/jobstats/rte_jobstats.c @@ -124,7 +124,7 @@ rte_jobstats_start(struct rte_jobstats_context *ctx, struct rte_jobstats *job) { uint64_t now; - /* Some sanity check. */ + /* Check validity of arguments. */ if (unlikely(ctx == NULL || job == NULL || job->context != NULL)) return -EINVAL; @@ -144,7 +144,7 @@ rte_jobstats_abort(struct rte_jobstats *job) struct rte_jobstats_context *ctx; uint64_t now, exec_time; - /* Some sanity check. */ + /* Check that arguments are valid */ if (unlikely(job == NULL || job->context == NULL)) return -EINVAL; @@ -165,7 +165,7 @@ rte_jobstats_finish(struct rte_jobstats *job, int64_t job_value) uint64_t now, exec_time; int need_update; - /* Some sanity check. */ + /* Check arguments */ if (unlikely(job == NULL || job->context == NULL)) return -EINVAL; diff --git a/lib/metrics/rte_metrics.c b/lib/metrics/rte_metrics.c index 0ccdbabc04eb..f60d4f3f6e25 100644 --- a/lib/metrics/rte_metrics.c +++ b/lib/metrics/rte_metrics.c @@ -120,7 +120,7 @@ rte_metrics_reg_names(const char * const *names, uint16_t cnt_names) uint16_t idx_name; uint16_t idx_base; - /* Some sanity checks */ + /* Some consistency checks */ if (cnt_names < 1 || names == NULL) return -EINVAL; for (idx_name = 0; idx_name < cnt_names; idx_name++) diff --git a/lib/pcapng/rte_pcapng.c b/lib/pcapng/rte_pcapng.c index 3c91fc77644a..fedf4b5b7f11 100644 --- a/lib/pcapng/rte_pcapng.c +++ b/lib/pcapng/rte_pcapng.c @@ -669,7 +669,7 @@ rte_pcapng_write_packets(rte_pcapng_t *self, struct rte_mbuf *m = pkts[i]; struct pcapng_enhance_packet_block *epb; - /* sanity check that is really a pcapng mbuf */ + /* Check that is really a pcapng mbuf */ epb = rte_pktmbuf_mtod(m, struct pcapng_enhance_packet_block *); if (unlikely(epb->block_type != PCAPNG_ENHANCED_PACKET_BLOCK || epb->block_length != rte_pktmbuf_data_len(m))) {