From patchwork Tue May 23 19:49:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akhil Goyal X-Patchwork-Id: 127247 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D44842B83; Tue, 23 May 2023 21:51:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 29ADE42D40; Tue, 23 May 2023 21:50:43 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id ECA2F42D41 for ; Tue, 23 May 2023 21:50:40 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34NG9H0d021237; Tue, 23 May 2023 12:50:38 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=gpTNqadLwaQDUBute+utB0lopgWYbTl+2Okvlix74Iw=; b=f3vsSOFFHaiDLLls1F8afJZPXuFhaFObcqHVhbT+fzuq03Cu20HyBxVh6whfQHHt8Scp bu5LjZayEl2lAxTAhxeYxyliVrHQNQltJy3rokmIcajH3fXvgdzpOtEEGc6Z59rI8K+T 7bU3u4nI8zOsvmmOaWn8ZrOgiM4wpjYLbr9YYEv8vZog8wURc4kQBDuMFUrkxWFXr/r+ dEXKYQzY7k9oUQTukbY31Aej7mJardW+rox9bJm0emTKjyZEwOKv+/r2pz8YokQccnp2 +P37nNvavRFT4M85jcE/Kzoou8wii7xXhauBJ0EthRA4WNdVP5IBGLJJkE32KzXtiZMA oQ== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3qpwqk30yk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 23 May 2023 12:50:38 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Tue, 23 May 2023 12:50:36 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Tue, 23 May 2023 12:50:36 -0700 Received: from localhost.localdomain (unknown [10.28.36.102]) by maili.marvell.com (Postfix) with ESMTP id 8320B3F70A9; Tue, 23 May 2023 12:50:33 -0700 (PDT) From: Akhil Goyal To: , Akhil Goyal CC: , , , , , , , , Subject: [PATCH 13/13] test/security: remove no MACsec support case Date: Wed, 24 May 2023 01:19:18 +0530 Message-ID: <20230523194918.1940212-14-gakhil@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230523194918.1940212-1-gakhil@marvell.com> References: <20220928124516.93050-5-gakhil@marvell.com> <20230523194918.1940212-1-gakhil@marvell.com> MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: 70zWoJRxLsPUuGT9POm-v9-xD3kkjvHO X-Proofpoint-GUID: 70zWoJRxLsPUuGT9POm-v9-xD3kkjvHO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-05-23_12,2023-05-23_02,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Removed the test_capability_get_no_support_for_macsec case as MACsec is now supported and capability can have valid MACsec support. Signed-off-by: Akhil Goyal --- app/test/test_security.c | 37 ------------------------------------- 1 file changed, 37 deletions(-) diff --git a/app/test/test_security.c b/app/test/test_security.c index e4ddcefe40..4783cd0663 100644 --- a/app/test/test_security.c +++ b/app/test/test_security.c @@ -1828,41 +1828,6 @@ test_capability_get_no_matching_protocol(void) return TEST_SUCCESS; } -/** - * Test execution of rte_security_capability_get when macsec protocol - * is searched and capabilities table contain proper entry. - * However macsec records search is not supported in rte_security. - */ -static int -test_capability_get_no_support_for_macsec(void) -{ - struct security_unittest_params *ut_params = &unittest_params; - struct rte_security_capability_idx idx = { - .action = RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL, - .protocol = RTE_SECURITY_PROTOCOL_MACSEC, - }; - struct rte_security_capability capabilities[] = { - { - .action = RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL, - .protocol = RTE_SECURITY_PROTOCOL_MACSEC, - }, - { - .action = RTE_SECURITY_ACTION_TYPE_NONE, - }, - }; - - mock_capabilities_get_exp.device = NULL; - mock_capabilities_get_exp.ret = capabilities; - - const struct rte_security_capability *ret; - ret = rte_security_capability_get(&ut_params->ctx, &idx); - TEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_capability_get, - ret, NULL, "%p"); - TEST_ASSERT_MOCK_CALLS(mock_capabilities_get_exp, 1); - - return TEST_SUCCESS; -} - /** * Test execution of rte_security_capability_get when capabilities table * does not contain entry with matching ipsec proto field @@ -2319,8 +2284,6 @@ static struct unit_test_suite security_testsuite = { test_capability_get_no_matching_action), TEST_CASE_ST(ut_setup_with_session, ut_teardown, test_capability_get_no_matching_protocol), - TEST_CASE_ST(ut_setup_with_session, ut_teardown, - test_capability_get_no_support_for_macsec), TEST_CASE_ST(ut_setup_with_session, ut_teardown, test_capability_get_ipsec_mismatch_proto), TEST_CASE_ST(ut_setup_with_session, ut_teardown,