From patchwork Tue May 30 09:05:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jie Hai X-Patchwork-Id: 127693 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E467042BE1; Tue, 30 May 2023 11:08:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2871442D39; Tue, 30 May 2023 11:07:46 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 5947C42D0B for ; Tue, 30 May 2023 11:07:42 +0200 (CEST) Received: from kwepemi500020.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4QVmgG1Y04zLnd8; Tue, 30 May 2023 17:04:42 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 30 May 2023 17:07:40 +0800 From: Jie Hai To: Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko CC: , Subject: [PATCH 05/10] ethdev: support telemetry query Tx queue info Date: Tue, 30 May 2023 17:05:05 +0800 Message-ID: <20230530090510.56812-6-haijie1@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20230530090510.56812-1-haijie1@huawei.com> References: <20230530090510.56812-1-haijie1@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.69.192.56] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemi500020.china.huawei.com (7.221.188.8) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patch support querying information of Tx queues. The command is like: --> /ethdev/tx_queue,0,0 { "/ethdev/tx_queue": { "host_threshold": 0, "prefetch_threshold": 0, "writeback_threshold": 0, "rs_threshold": 32, "free_threshold": 928, "deferred_start": "off", "offloads": [ "MBUF_FAST_FREE" ], "queue_state": 1, "nb_desc": 1024, "burst_flags": 0, "burst_mode": "Vector Neon" } } Signed-off-by: Jie Hai --- lib/ethdev/rte_ethdev.c | 50 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index 35c13df1c110..315334321cb3 100644 --- a/lib/ethdev/rte_ethdev.c +++ b/lib/ethdev/rte_ethdev.c @@ -7295,6 +7295,54 @@ eth_dev_handle_port_rxq(const char *cmd __rte_unused, return ret; } +static int +eth_dev_handle_port_txq(const char *cmd __rte_unused, + const char *params, + struct rte_tel_data *d) +{ + struct rte_eth_thresh *tx_thresh; + unsigned long port_id, queue_id; + struct rte_eth_txconf *txconf; + struct rte_eth_txq_info qinfo; + struct rte_tel_data *offload; + int ret; + + ret = parse_queue_params(params, false, &port_id, &queue_id); + if (ret != 0) + return ret; + + ret = rte_eth_tx_queue_info_get(port_id, queue_id, &qinfo); + if (ret != 0) + return ret; + + rte_tel_data_start_dict(d); + tx_thresh = &qinfo.conf.tx_thresh; + txconf = &qinfo.conf; + rte_tel_data_add_dict_uint(d, "host_threshold", tx_thresh->hthresh); + rte_tel_data_add_dict_uint(d, "prefetch_threshold", tx_thresh->pthresh); + rte_tel_data_add_dict_uint(d, "writeback_threshold", tx_thresh->wthresh); + rte_tel_data_add_dict_uint(d, "rs_threshold", txconf->tx_rs_thresh); + rte_tel_data_add_dict_uint(d, "free_threshold", txconf->tx_free_thresh); + rte_tel_data_add_dict_string(d, "deferred_start", + txconf->tx_deferred_start == 0 ? "off" : "on"); + + offload = rte_tel_data_alloc(); + if (offload == NULL) + return -ENOMEM; + + eth_dev_parse_tx_offloads(txconf->offloads, offload); + rte_tel_data_add_dict_container(d, "offloads", offload, 0); + + rte_tel_data_add_dict_uint(d, "queue_state", qinfo.queue_state); + rte_tel_data_add_dict_uint(d, "nb_desc", qinfo.nb_desc); + + ret = eth_dev_add_burst_mode(port_id, queue_id, false, d); + if (ret != 0) + rte_tel_data_free(offload); + + return 0; +} + RTE_LOG_REGISTER_DEFAULT(rte_eth_dev_logtype, INFO); RTE_INIT(ethdev_init_telemetry) @@ -7322,4 +7370,6 @@ RTE_INIT(ethdev_init_telemetry) "Returns flow ctrl info for a port. Parameters: unsigned port_id"); rte_telemetry_register_cmd("/ethdev/rx_queue", eth_dev_handle_port_rxq, "Returns Rx queue info for a port. Parameters: unsigned port_id, unsigned queue_id (Optional if only one queue)"); + rte_telemetry_register_cmd("/ethdev/tx_queue", eth_dev_handle_port_txq, + "Returns Tx queue info for a port. Parameters: unsigned port_id, unsigned queue_id (Optional if only one queue)"); }