From patchwork Tue Sep 19 14:04:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 131637 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3DC8E42609; Tue, 19 Sep 2023 16:05:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BD33840E40; Tue, 19 Sep 2023 16:05:03 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id C92B840A8B for ; Tue, 19 Sep 2023 16:05:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695132301; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Jx+4pQxWhq2BYbGx34pIPLPxxMd68TmyihU805lInEY=; b=Bg+90PCsSH+eiLIAGwmrJUBCH2Eotw94NBg324OG9eq2+hcMnTIRKBkQ5aI8jHSQ76V6iM 2+ezhSoRmt1bbojtYuD3pWzr5Trr4ghywIYMjyusmKdk73io2dmjvxD99sak2wgAGeovqY 8vYZBN1UO54xX5Rl6uuCMnFzfNBAnMQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-502-QbAvwb7eMUqDJVKCx3OlrQ-1; Tue, 19 Sep 2023 10:04:52 -0400 X-MC-Unique: QbAvwb7eMUqDJVKCx3OlrQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F137A800888; Tue, 19 Sep 2023 14:04:46 +0000 (UTC) Received: from dmarchan.redhat.com (unknown [10.45.225.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id CB15E10F1BE7; Tue, 19 Sep 2023 14:04:39 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: ktraynor@redhat.com, mkp@redhat.com, dexia.li@jaguarmicro.com, stable@dpdk.org, Jingjing Wu , Beilei Xing , Kevin Liu , Qi Zhang Subject: [PATCH 1/2] net/iavf: fix TSO with big segments Date: Tue, 19 Sep 2023 16:04:29 +0200 Message-ID: <20230919140430.3251493-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Packets to be segmented with TSO are usually larger than MTU. Plus, a single segment for the whole packet may be used: in OVS case, an external rte_malloc'd buffer is used for packets received from vhost-user ports. Before this fix, TSO packets were dropped by net/iavf with the following message: 2023-09-18T14:08:52.739Z|00610|dpdk(pmd-c31/id:11)|ERR|iavf_prep_pkts(): INVALID mbuf: bad data_len=[2962] Remove the check on data_len. Besides, logging an error level message in a datapath function may slow down the whole application. It is better not to log anything. Fixes: 19ee91c6bd9a ("net/iavf: check illegal packet sizes") Cc: stable@dpdk.org Signed-off-by: David Marchand --- drivers/net/iavf/iavf_rxtx.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c index f7df4665d1..0396099708 100644 --- a/drivers/net/iavf/iavf_rxtx.c +++ b/drivers/net/iavf/iavf_rxtx.c @@ -3611,7 +3611,6 @@ iavf_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, struct rte_mbuf *m; struct iavf_tx_queue *txq = tx_queue; struct rte_eth_dev *dev = &rte_eth_devices[txq->port_id]; - uint16_t max_frame_size = dev->data->mtu + IAVF_ETH_OVERHEAD; struct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(dev->data->dev_private); struct iavf_adapter *adapter = IAVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private); @@ -3640,11 +3639,8 @@ iavf_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, return i; } - /* check the data_len in mbuf */ - if (m->data_len < IAVF_TX_MIN_PKT_LEN || - m->data_len > max_frame_size) { + if (m->pkt_len < IAVF_TX_MIN_PKT_LEN) { rte_errno = EINVAL; - PMD_DRV_LOG(ERR, "INVALID mbuf: bad data_len=[%hu]", m->data_len); return i; }