From patchwork Wed Sep 27 09:41:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 131988 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5473642651; Wed, 27 Sep 2023 11:42:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 71233402F0; Wed, 27 Sep 2023 11:42:07 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 78EF74026B for ; Wed, 27 Sep 2023 11:42:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695807726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fk7SuYHbU0JmzE0l6Sv1S4vd7afAaTZJBgudb96G0ew=; b=A1KE+3RmGYK3574+pop4gJlpqP6by4/fyc6ta3Xy0cZ2Zg7ns1YWCxaUqggaPYCqEvy3ac XDxMtWVzm2LdGJP/MH9GpAN9I2XzzZ/42BXR+YT2WQ5+gjEaHcAjcaGpt9KewT20wFEP6t N/qyvGURgwfeOaWsiDLRVUAeB1096ys= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-692--w39PrpQO5adjAPBkGYGjg-1; Wed, 27 Sep 2023 05:42:01 -0400 X-MC-Unique: -w39PrpQO5adjAPBkGYGjg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3DAD4101A58B; Wed, 27 Sep 2023 09:42:01 +0000 (UTC) Received: from dmarchan.redhat.com (unknown [10.45.224.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id 16E04C158BA; Wed, 27 Sep 2023 09:41:59 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: stable@dpdk.org, Jingjing Wu , Beilei Xing , Qi Zhang , Kevin Liu Subject: [PATCH v2 1/4] net/iavf: remove log from Tx prepare datapath function Date: Wed, 27 Sep 2023 11:41:45 +0200 Message-ID: <20230927094148.1129330-1-david.marchand@redhat.com> In-Reply-To: <20230919140430.3251493-1-david.marchand@redhat.com> References: <20230919140430.3251493-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org iavf_prep_pkts reports to the application that the packet is invalid (from the driver pov). Having a log message only in this branch is not consistent with all other checks in this function and it may slow down the application if such invalid packets are being sent continuously. Fixes: 19ee91c6bd9a ("net/iavf: check illegal packet sizes") Cc: stable@dpdk.org Signed-off-by: David Marchand --- drivers/net/iavf/iavf_rxtx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c index 0484988d13..21a06b8351 100644 --- a/drivers/net/iavf/iavf_rxtx.c +++ b/drivers/net/iavf/iavf_rxtx.c @@ -3669,7 +3669,6 @@ iavf_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, if (m->data_len < IAVF_TX_MIN_PKT_LEN || m->data_len > max_frame_size) { rte_errno = EINVAL; - PMD_DRV_LOG(ERR, "INVALID mbuf: bad data_len=[%hu]", m->data_len); return i; }