From patchwork Wed Sep 27 09:41:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 131990 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7805342651; Wed, 27 Sep 2023 11:42:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 62E73406B4; Wed, 27 Sep 2023 11:42:14 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 17098402DC for ; Wed, 27 Sep 2023 11:42:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695807731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lmYWmdG7S6Ds1eVyYBI3dZsD7SSFE7hJCX6B4AyKM6g=; b=X3IxKK12Ic2TXmGdyG+8vErLx75clOhiL2LB1188kTce2P/ueqOurtZvpOWzuuxT3QIupX 00WQrRbnmiJlcvaJ6S8sADSrRw1mN2g5b8Y38OcO7/Dv8BfoabwbZW4kt7fttv/j5QmFvd NSJs6jmMwpvgZMYn999z7b8Y0zFJ2bQ= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-594-juEtYCXgP4eF57BMq507fw-1; Wed, 27 Sep 2023 05:42:08 -0400 X-MC-Unique: juEtYCXgP4eF57BMq507fw-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9B0D23821344; Wed, 27 Sep 2023 09:42:07 +0000 (UTC) Received: from dmarchan.redhat.com (unknown [10.45.224.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id 59574492B16; Wed, 27 Sep 2023 09:42:06 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: stable@dpdk.org, Qiming Yang , Qi Zhang , Kevin Liu , Mingjin Ye Subject: [PATCH v2 3/4] net/ice: remove log from Tx prepare datapath function Date: Wed, 27 Sep 2023 11:41:47 +0200 Message-ID: <20230927094148.1129330-3-david.marchand@redhat.com> In-Reply-To: <20230927094148.1129330-1-david.marchand@redhat.com> References: <20230919140430.3251493-1-david.marchand@redhat.com> <20230927094148.1129330-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org ice_prep_pkts reports to the application that the packet is invalid (from the driver pov). Having a log message in those branches is not consistent with all other checks in this function and it may slow down the application if such invalid packets are being sent continuously. Fixes: ccf33dccf7aa ("net/ice: check illegal packet sizes") Fixes: 688cb2f2c61e ("net/ice: fix scalar Tx path segment") Cc: stable@dpdk.org Signed-off-by: David Marchand --- drivers/net/ice/ice_rxtx.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c index e07c6d1f15..d5513e9e93 100644 --- a/drivers/net/ice/ice_rxtx.c +++ b/drivers/net/ice/ice_rxtx.c @@ -3708,7 +3708,6 @@ ice_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, if (m->data_len < ICE_TX_MIN_PKT_LEN || m->data_len > max_frame_size) { rte_errno = EINVAL; - PMD_DRV_LOG(ERR, "INVALID mbuf: bad data_len=[%hu]", m->data_len); return i; } @@ -3727,7 +3726,6 @@ ice_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, if (ice_check_empty_mbuf(m) != 0) { rte_errno = EINVAL; - PMD_DRV_LOG(ERR, "INVALID mbuf: last mbuf data_len=[0]"); return i; } }