From patchwork Mon Oct 23 21:07:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alexander Kozyrev X-Patchwork-Id: 133201 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09E99431E6; Mon, 23 Oct 2023 23:08:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 26C9740DF8; Mon, 23 Oct 2023 23:08:13 +0200 (CEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2043.outbound.protection.outlook.com [40.107.102.43]) by mails.dpdk.org (Postfix) with ESMTP id 19CB0402E7 for ; Mon, 23 Oct 2023 23:08:10 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q+wXqWl9FknD+y+yL4uHnNF0wdQETy1BfO3CQkD3ZRvvc7uCBANe2poXRGOz+r4ugRFPMiaTvJ2h23PXMTvcRz8drEIGTnQLm7CVmZDS81imR5OJSuJ+tYQCbO1/CJr/J99pg9TUKOnXSQsYFYPmuRaCL5dvFE/IoACLqa3fL8Ry3tDCs58fHQTYFYfjhQh84l9b8fYhn+rZWO2iPHDz/2xjS7jDeurbVt4JwF6NrmUjKxfypFctzsPuKm3/Tn08U2PKaN7i6TPpnkZgg3jD5IiwYmZjlzTpQVDPdLnLg1brwdMQwqs1HFlShIYgvoJSFUiOMOqD0E8aDV5ce7azkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kQUF8X4M7+FxEs9vxpyGGh9qHxbmhF3VVk3fkSB/cUM=; b=dmxMrfM/xCv0BvCPxWo7ZCP0ywjR98l13bidHUs6BfQDZCEgRhQojkro500fYm4mNrnjEtZLSvfGb6v+q+mrKVLMM5aXmLOAQtWM/xI0EsdeHf3+0mvR0jVAGtFKgTiOxseRHYX9AG6xbDSjfwx38K407gDXkNCDd40O+i6tZWAQIh+lGfU+bjlQvo2w3QuAS5WVGU9Vw28BSF0HJH1Teg8ABjfHGzXPkbAd1wv/BGTghatw+5IpSNZDn4F+5dEPRwZEr7HOz7w0ySJkWLwXzMNJ/3ew4hZ71pkcdTXtABjyV3sMa+lmthESowwldUqMCJ+SBc2V3RyKvx3wByj0vQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kQUF8X4M7+FxEs9vxpyGGh9qHxbmhF3VVk3fkSB/cUM=; b=fv052hDorVRm/L76E+KjgAYbsY67KbW1dt4VS60aJ8S7zQbcNtbWwm8q/iAjhDkzN3a5Twn7v/pawNe5rFyEfoLzU+pfxQ0E+Yg2Owkb4p6rVMr1bynxPl75LM6PJR49hdXKnE9Zcm8qQvzfe/a9Y952XqoRwhfBV6/1+Sm63HoZRdIQq/swc8LwflihCMzl2QNW2UwxSKcmnlgE3trwEKaJZuLZlqSVKqztfFh3M+mHvFvtVmvaM9MdRhxUCQbeADvY/fPDdbZjPDz3auSSyi/i1KSyz0vsUxPLapPkC/3falQGjxNjvHXnC4yaM7Eab7aOjTeZvKYi7tpGjbtjkw== Received: from CYXPR03CA0011.namprd03.prod.outlook.com (2603:10b6:930:d0::19) by DS0PR12MB8366.namprd12.prod.outlook.com (2603:10b6:8:f9::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.26; Mon, 23 Oct 2023 21:08:08 +0000 Received: from CY4PEPF0000EDD2.namprd03.prod.outlook.com (2603:10b6:930:d0:cafe::5a) by CYXPR03CA0011.outlook.office365.com (2603:10b6:930:d0::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33 via Frontend Transport; Mon, 23 Oct 2023 21:08:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000EDD2.mail.protection.outlook.com (10.167.241.206) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.15 via Frontend Transport; Mon, 23 Oct 2023 21:08:08 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 23 Oct 2023 14:08:07 -0700 Received: from pegasus01.mtr.labs.mlnx (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 23 Oct 2023 14:08:01 -0700 From: Alexander Kozyrev To: CC: , , , , , Subject: [PATCH v2 6/7] net/mlx5/hws: remove csum check from L3 ok check Date: Tue, 24 Oct 2023 00:07:06 +0300 Message-ID: <20231023210707.1344241-7-akozyrev@nvidia.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20231023210707.1344241-1-akozyrev@nvidia.com> References: <20231009163617.3999365-1-akozyrev@nvidia.com> <20231023210707.1344241-1-akozyrev@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EDD2:EE_|DS0PR12MB8366:EE_ X-MS-Office365-Filtering-Correlation-Id: 52cff8e4-51bf-4f40-3877-08dbd40c2828 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JBzlN/TqBgZWx9QKurH9Zvsb8kvVqkt3Bzjim3oPHkNCvn2vFR85kWD4cUKpXSMnsM7v1BO0InkaU8gvSwC8VAmYa0okWW4KRxpC4rAdhlDCNKRiLv4fregwP31e14Z6pWBpk3aakbaQdZKptNZVXgUgCU2DdF8zaRCygYrbFYvefKJDqb7cvtDGy5w0t2XsnP7wl/M16GNLzcYlNFyEzMclT65wJPToIhleX/KC0LKdrYyz+KBznUZmEQnZtw16JeXTgNqjTh4Jcb6gt/doXfMTtN2O0h1oKo4TYvvDDjAc41SGu0jn7c/jygG70JC6Gwo+IGeqAfwtORx33vjZYLo7V9t3ibgR97ohC5kKMK7sCn9gjXXBoKx79MqFYgnpcezyluGL9bNsxP9UyqJ4kHxnward8RohkOdz5KbBYd9W0v9QANG5IxZJWIrCNTTmg9UsRs5u4KgJdLyXJhbrPri03+ixGXruS4hAinj4mCvzBjABXYFmHdwRtb12hquZ6nygF0otjMHDPiR/oEDf56sAaFfkWDVJFNMJc0BLALAwi0Wa/nmlQcnT4kdQkNumfBU1Y0E4wedMw/u5IC1MQ2LzEDSMe4wBnjZU6vZB+71lG3gEE1VeveqbMFGN1d+WGnJ2TpGJVoLTN1j/DqM1CSIIc5HJXIPefJds/C6bSLQ9VMwxWACKiR4eSYSjCAMsOUGlewiSXnfxhZztNhTBhNn5lJZhMJ6ywyrwGdjVnvMc5joXYEVuzHD+y3U6c9ow X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(346002)(396003)(376002)(39860400002)(136003)(230922051799003)(186009)(64100799003)(451199024)(82310400011)(1800799009)(40470700004)(46966006)(36840700001)(40460700003)(86362001)(2906002)(47076005)(83380400001)(7636003)(41300700001)(36860700001)(36756003)(16526019)(1076003)(5660300002)(26005)(82740400003)(40480700001)(336012)(356005)(2616005)(107886003)(426003)(8936002)(8676002)(478600001)(70206006)(70586007)(54906003)(316002)(4326008)(6916009); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2023 21:08:08.0384 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 52cff8e4-51bf-4f40-3877-08dbd40c2828 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EDD2.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8366 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Michael Baum This patch changes the integrity item behavior for HW steering. Old behavior: the "ipv4_csum_ok" checks only IPv4 checksum and "l3_ok" checks everything is ok including IPv4 checksum. New behavior: the "l3_ok" checks everything is ok excluding IPv4 checksum. This change enables matching "l3_ok" in IPv6 packets since for IPv6 packets "ipv4_csum_ok" is always miss. For SW steering the old behavior is kept as same as for L4 ok. Signed-off-by: Michael Baum --- doc/guides/nics/mlx5.rst | 19 ++++++++++++------- drivers/net/mlx5/hws/mlx5dr_definer.c | 6 ++---- 2 files changed, 14 insertions(+), 11 deletions(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index c9e74948cc..5115df12c8 100644 --- a/doc/guides/nics/mlx5.rst +++ b/doc/guides/nics/mlx5.rst @@ -663,18 +663,23 @@ Limitations - Integrity: - - Integrity offload is enabled starting from **ConnectX-6 Dx**. - Verification bits provided by the hardware are ``l3_ok``, ``ipv4_csum_ok``, ``l4_ok``, ``l4_csum_ok``. - ``level`` value 0 references outer headers. - Negative integrity item verification is not supported. - - Multiple integrity items not supported in a single flow rule. - - Flow rule items supplied by application must explicitly specify network headers referred by integrity item. - For example, if integrity item mask sets ``l4_ok`` or ``l4_csum_ok`` bits, reference to L4 network header, - TCP or UDP, must be in the rule pattern as well:: + - With SW steering (``dv_flow_en=1``) + - Integrity offload is enabled starting from **ConnectX-6 Dx**. + - Multiple integrity items not supported in a single flow rule. + - Flow rule items supplied by application must explicitly specify network headers referred by integrity item. + For example, if integrity item mask sets ``l4_ok`` or ``l4_csum_ok`` bits, reference to L4 network header, + TCP or UDP, must be in the rule pattern as well:: - flow create 0 ingress pattern integrity level is 0 value mask l3_ok value spec l3_ok / eth / ipv6 / end … + flow create 0 ingress pattern integrity level is 0 value mask l3_ok value spec l3_ok / eth / ipv6 / end … - flow create 0 ingress pattern integrity level is 0 value mask l4_ok value spec l4_ok / eth / ipv4 proto is udp / end … + flow create 0 ingress pattern integrity level is 0 value mask l4_ok value spec l4_ok / eth / ipv4 proto is udp / end … + + - With HW steering (``dv_flow_en=2``) + - The ``l3_ok`` field represents all L3 checks, but nothing about whether IPv4 checksum ok. + - The ``l4_ok`` field represents all L4 checks including L4 checksum ok. - Connection tracking: diff --git a/drivers/net/mlx5/hws/mlx5dr_definer.c b/drivers/net/mlx5/hws/mlx5dr_definer.c index 0e1035c6bd..c752896ca7 100644 --- a/drivers/net/mlx5/hws/mlx5dr_definer.c +++ b/drivers/net/mlx5/hws/mlx5dr_definer.c @@ -380,10 +380,8 @@ mlx5dr_definer_integrity_set(struct mlx5dr_definer_fc *fc, uint32_t ok1_bits = 0; if (v->l3_ok) - ok1_bits |= inner ? BIT(MLX5DR_DEFINER_OKS1_SECOND_L3_OK) | - BIT(MLX5DR_DEFINER_OKS1_SECOND_IPV4_CSUM_OK) : - BIT(MLX5DR_DEFINER_OKS1_FIRST_L3_OK) | - BIT(MLX5DR_DEFINER_OKS1_FIRST_IPV4_CSUM_OK); + ok1_bits |= inner ? BIT(MLX5DR_DEFINER_OKS1_SECOND_L3_OK) : + BIT(MLX5DR_DEFINER_OKS1_FIRST_L3_OK); if (v->ipv4_csum_ok) ok1_bits |= inner ? BIT(MLX5DR_DEFINER_OKS1_SECOND_IPV4_CSUM_OK) :