From patchwork Mon Nov 27 12:42:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Baum X-Patchwork-Id: 134619 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15452433E4; Mon, 27 Nov 2023 13:43:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA80940273; Mon, 27 Nov 2023 13:43:30 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2068.outbound.protection.outlook.com [40.107.93.68]) by mails.dpdk.org (Postfix) with ESMTP id 5ECE14014F; Mon, 27 Nov 2023 13:43:29 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=exaX2BjZGbP1RtjxMigdFuV+OovO1s5ke0BrlpdJbqrCfMFZHMO+GFl+MUC4r2Px3zNcxtCiYzSWqPn8IfGIy8BRh8A4EPUHVHPQlQRZy1jY3QUgo1RyAMyjctr+1Q+P6bVAgJYkkU/+Ivwa6Gs6xH2Ba0nsrqmImfg1sBXGGYTRQNwvAOsZm83NQmOUlFkHblxLVB2TWZwyrSPd0xtway7MPaGZx/AJWHBrZdSY+7/E5DL/os3+aCQlMn+/cZS9kREkz5CXpLUGbgRlGkuRzbQ6tR6t4ggfHtONLW4bAh0nAX6HQssu1qvd8p5o3vUs1+sT+n9XZOoQ7S0Kmrso1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MlrpyZmINpMxb15UIm4LZfqGJ0zGSMztUDljhCV6DGQ=; b=A2dfru7oDjbzhFNpYmNO5wLW0FeXp/6JkzlgrnoCrrK5SFmD+LnVIHOTR6Y8S+EkiYKyTaq6mxuDKQHW2kxg2sEMZyOekomFtFS0lYBvBX0ovSv2nUUHtZzShBiEjUxCzrZjepapfRhzatGDNtQ6OcpY4w6rf9p7YyO01VJN3vtK8XuiaYeboceyed1rbtQAM+r52NAgRnmJJHwcZN/08XIuyySuRfzOmPfBVqSLzvA+1RmmPHk5FPA/C9j45qkRTjvqdxacuK+qoawJjihK3per9TJJSFysKtT3QhXmdCQDFyQ4ixuk0ClWd3Csrbft+ZgWz069Z+Fjq7H0N1p/kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MlrpyZmINpMxb15UIm4LZfqGJ0zGSMztUDljhCV6DGQ=; b=cqCk+PJquFP67ZiBOa6q1bM8/Bz+CCzX3Lqn2GDuqEu3v4sRNL4K58uX+DdRHE7fsJfYpYWZpXi6WIzh8MQ2XF8Wln/XcLi91jS7ye3A6ePr51e4w/Bxa329qF005b1GhcRIVRKecn2fgWJIQEiOBpaoEYpHfIDfqEAvF8zwAkz805RwegU0OlR6pOG2xWHiY/twHatCGzEGMKTtPhcdiLgXAv4xCYAMvvD6HfpZOKtLAWU3zsAzHV3Pa/7Ds6mI85N6Vcd9Jz7hx83nMDBvmaqfasWHiSHkli07+4oR/Twu1so0dbSZWVwd9wZAil2is0/aEUrQmuCKzuqZY3MUlQ== Received: from BL1PR13CA0304.namprd13.prod.outlook.com (2603:10b6:208:2c1::9) by CH3PR12MB7572.namprd12.prod.outlook.com (2603:10b6:610:144::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.26; Mon, 27 Nov 2023 12:43:24 +0000 Received: from BL6PEPF0001AB57.namprd02.prod.outlook.com (2603:10b6:208:2c1:cafe::d7) by BL1PR13CA0304.outlook.office365.com (2603:10b6:208:2c1::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.19 via Frontend Transport; Mon, 27 Nov 2023 12:43:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL6PEPF0001AB57.mail.protection.outlook.com (10.167.241.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.17 via Frontend Transport; Mon, 27 Nov 2023 12:43:24 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 27 Nov 2023 04:43:05 -0800 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 27 Nov 2023 04:43:05 -0800 Received: from nvidia.com (10.127.8.13) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41 via Frontend Transport; Mon, 27 Nov 2023 04:43:03 -0800 From: Michael Baum To: CC: Matan Azrad , Raslan Darawsheh , Viacheslav Ovsiienko , Ori Kam , Suanming Mou , , Subject: [PATCH v2] net/mlx5: fix jump action validation Date: Mon, 27 Nov 2023 14:42:59 +0200 Message-ID: <20231127124259.441227-1-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231113104342.1102189-1-michaelba@nvidia.com> References: <20231113104342.1102189-1-michaelba@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB57:EE_|CH3PR12MB7572:EE_ X-MS-Office365-Filtering-Correlation-Id: f8b91d4d-03e7-4ab0-f6f7-08dbef467217 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rqXiz69EfQ9Xxj8oQ9QUFh7URJJxpPCsQ6ZVMh3k2FMip3uGVSXBdqXH4wbd8fMRidLnmOZMgJdzyDZ8P0R5R7TM/7GtFq3aSGoIyTyTI+whLsuDGEWFJHBakOSgg+vZXCvHLv6ae1szEwrtUBetKnneEOf2gAHLUiyjRZlcIVr6ldsh+I/o7FlxKN/R2QENfgcHfGYRlSPFiT8dXD0UhCSkXsZkr3zDAVaq3/NG8GVo4vBXINKHHFQueLlueRiyco24fLeJMCNROuypVR+wxlypOkhBAwz4iuhfu4QwBkCTIK0odXE717AFII3WVxLLqPeFIceCltXVXXVnvUptcIjW/9bGwGahfCqN0BH6OtEeqnE1u/LmYeV6uZdI1rmgONGclA/0q8lXHcvPP+3yu+yqNgoivxRurtYH/P+/aARU3vAlvE2XD/FIiw3L3eoWkCYV5CYl5ve3mVOesVP0PcObhXiKKS8HDvJVr7JzmRhl71zzFYi6lKf6z7euV5kVwvQfO5ADkjbJY3wA3pAVrQ6xOc2Scv+tczcq9HSVeV0TnuGvGssi7dWXGTVpviVfD642SI4CrDrz8poe56frCt+S8p8fDuCd/I9qf/m/GL7kr+rQCeTQ3Pp1nBiQ7jmWROAIn82b6ag/+HNz7CRwOXj1g9fCSSAHsTYd75NwDhKnesf8t5ZLsaK3CPC3QPlbzyFy7wxhyc3EED2rnkOWpMWQAGQDJE7nZR+gaErFVDA= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(376002)(136003)(39860400002)(396003)(346002)(230922051799003)(64100799003)(186009)(82310400011)(451199024)(1800799012)(46966006)(36840700001)(40470700004)(316002)(6916009)(54906003)(70206006)(70586007)(478600001)(40460700003)(6666004)(5660300002)(41300700001)(36756003)(2906002)(8936002)(8676002)(4326008)(450100002)(86362001)(426003)(82740400003)(336012)(83380400001)(7636003)(356005)(2616005)(26005)(6286002)(1076003)(36860700001)(55016003)(47076005)(7696005)(40480700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2023 12:43:24.2104 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f8b91d4d-03e7-4ab0-f6f7-08dbef467217 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB57.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7572 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Currently PMD doesn't allow to jump to the same group in order to avoid dead loop. But this also prevent experienced user to create flow with less Hops in order to have better performance. For example, rules in [1] should have better performance then [2]. Furthermore, this protection will not really prevent dead loop, i.e [3]. So just remove this protection and user should take the responsibility to avoid dead loop. This patch enables jumping to the same group. [1]: flow create 0 group 1 priority 1 pattern eth / ipv4 / udp / gtp / end actions raw_decap / raw_encap / jump group 1 / end flow create 0 group 1 priority 0 pattern eth / ipv4 src is 1.0.0.1 / tcp / end actions queues index 1 / end [2]: flow create 0 group 1 priority 0 pattern eth / ipv4 / udp / gtp / end actions raw_decap / raw_encap / jump group 2 / end flow create 0 group 2 priority 0 pattern eth / ipv4 src is 1.0.0.1 / tcp / end actions queues index 1 / end [3]: flow create 0 group 1 pattern eth / end actions jump group 2 / end flow create 0 group 2 pattern eth / end actions jump group 1 / end Fixes: f78f747f41d0 ("net/mlx5: allow jump to group lower than current") Cc: dekelp@mellanox.com Cc: stable@dpdk.org Signed-off-by: Michael Baum Acked-by: Matan Azrad --- V2: change commit message to fix template. drivers/net/mlx5/mlx5_flow_dv.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index 115d730317..5d0cb4278b 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -5484,13 +5484,6 @@ flow_dv_validate_action_jump(struct rte_eth_dev *dev, &grp_info, error); if (ret) return ret; - if (attributes->group == target_group && - !(action_flags & (MLX5_FLOW_ACTION_TUNNEL_SET | - MLX5_FLOW_ACTION_TUNNEL_MATCH))) - return rte_flow_error_set(error, EINVAL, - RTE_FLOW_ERROR_TYPE_ACTION, NULL, - "target group must be other than" - " the current flow group"); if (table == 0) return rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION_CONF,