From patchwork Sun Dec 3 11:25:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Baum X-Patchwork-Id: 134755 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3FF254365F; Sun, 3 Dec 2023 12:27:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 32E6E40A7D; Sun, 3 Dec 2023 12:26:34 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2075.outbound.protection.outlook.com [40.107.223.75]) by mails.dpdk.org (Postfix) with ESMTP id 7796F40A6D for ; Sun, 3 Dec 2023 12:26:32 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VM0038nU6vqUOSW9JlZ3+NnwXeh/zC0lA3MT+SHvu9679EVF6JC5+xggQ3RkHlP4CLHRBBvPBtSKNLzI2SkFIJFFxkAorskYutmnc3xTGUUlZ5UK5XmwEE4epPSm+GUuY3fA5Vs1hxxDmLQwpo92+cFLOFYwbadPOpsq6Z43C0MU1EzSrTj9ecu2gk2Fzi9Pj0Fr0KMIA2Y3jO3+AkQNmJQ4sV1zQEPcZbTK8ZMR4GA/mKEeBM6Xu8z7RREPzTdbETzBrQQ+EHdC+wijkaqZGjz1B5J8lw0HaCNb/bx9l+4I6+BHRNot44Tjrq2KmWIgy7FO7tIvKmdyaSZbdpukHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6pZ/bsAnn5ci2rZuSEJilBi4dODJWgmpCB28j0+i6/M=; b=JYSRQIVaQ8ichwsa5p0b0zdg29/z2RBi+qkSCOQ2x325+hDio1bEi3q4tgXPaOZf8WcKfifQHhFcKpCKYyZUoNT4EP9jyZq9NBkgz25nS+VKPf9cQiftwX0EpkPNOmBRZHrsptKAILyopCPibOsTsPS5qkOCbP/FKaiQLQM/KX+qjMOljmyZmmWG7iSXYJQpIp5qj4A4tEjdoYBvfapdYHY3tpKDcpXRL5hCCa0NHQ8Lt5iaa5XL90SWbN7/dk6bhVIuSsK0dL7xtYkNFNNY5Z1loqm2LLXFxVJLJCkDgmT4655rARDFeqbyXTq9Kxja5vXko22m1XhOObnqWPMCiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6pZ/bsAnn5ci2rZuSEJilBi4dODJWgmpCB28j0+i6/M=; b=e0ZKZ0lqrUKALK8J0p6PsBBsRs+JapAba1pFt9XGNsjtbZbzIS5FNoc5ULJwIi8PXYJRWzJw1HEhMS2CvpZEMWrz4amkoYxwwWjcnlWIImehm3Q4xHVXjcBA8eBphY9kEJrWHotZwGTL3oDd8JE6CKEJE0Um+XnQlkiSclTYbsCCMGAd5jM6PT/mTJyYx3FLLZZJ40G9nzLpim1vQwRGZwOhDw7aZyd+OLmv/d5kOEKglUTAsm2gyJV647TYJXQNeahG0ujkBOSte1oP6Jv/nB4hGH8xGxDe4yng+wY+ikd3Pwp6f7k2HLZ8Kya7GCbrjHwdJEMJsiV96a4MC34sEQ== Received: from MW4P222CA0021.NAMP222.PROD.OUTLOOK.COM (2603:10b6:303:114::26) by PH7PR12MB8105.namprd12.prod.outlook.com (2603:10b6:510:2b7::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.32; Sun, 3 Dec 2023 11:26:28 +0000 Received: from CO1PEPF000042AC.namprd03.prod.outlook.com (2603:10b6:303:114:cafe::4e) by MW4P222CA0021.outlook.office365.com (2603:10b6:303:114::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.32 via Frontend Transport; Sun, 3 Dec 2023 11:26:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1PEPF000042AC.mail.protection.outlook.com (10.167.243.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.20 via Frontend Transport; Sun, 3 Dec 2023 11:26:26 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 3 Dec 2023 03:26:07 -0800 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 3 Dec 2023 03:26:07 -0800 Received: from nvidia.com (10.127.8.13) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41 via Frontend Transport; Sun, 3 Dec 2023 03:26:05 -0800 From: Michael Baum To: CC: Matan Azrad , Raslan Darawsheh , Viacheslav Ovsiienko , Ori Kam , Suanming Mou Subject: [PATCH v1 07/23] common/mlx5: add GENEVE TLV option attribute structure Date: Sun, 3 Dec 2023 13:25:27 +0200 Message-ID: <20231203112543.844014-8-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231203112543.844014-1-michaelba@nvidia.com> References: <20231203112543.844014-1-michaelba@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000042AC:EE_|PH7PR12MB8105:EE_ X-MS-Office365-Filtering-Correlation-Id: 00d16144-79be-4fe4-ed2e-08dbf3f2b051 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xhyDe3OoE415oLOQuextY9cuzmOzELCgUPj3fOlHl+G3baHvl1TC9stZ+4S7TshAKCUAlDrQezl3mFHQ+xoCwEtyAQZZ0kwrDMVwzHMGnNMfxJqluIuc45Lzx9zcPQPcEIHlfhbyhYtYsBEPHYaSzL/emn9DC7sYl2lcoyBoqmFp0u/STT0bPCVCjnCx/8B8oPFoeSeVkxWbpznnwQ/ys0D6tswN5nZOBcsze2XGhXuRnNXnf0odcwtBwAf2F8Ob4U3kXHfROjqUQHFzhALULKeySX7X/5K5XDaqh7Kz1vPXh2WVS5jswVFbj+ug8tHpDM2H2GqwW7wcUfpm9Xlx65Ca66AHGqH/0rgUnRuum7x2Jo5WCGrHArZ5bieFGyF3shLUoiHbB1rGKHSC95pwP77z70Pt3HY8aRpmPMcP1vu+pziWITTY7ID6zLgn2U6HgLl49z10a/DSJrN5VX5caMSwe32lC6jIs8FkUiuFW1/yZe7gu7M+D2zsMVUN0PW4+lnOapRGISH/oSNPsZaoBfAA0Amkdkf2VJTsoH8iudluqxuPCeE/MIc8qiIzYnxTwE3copE1J5nSk1Gk+mpOGrUCUb8Nv+d33O8lqxkKtnJXINkS8AokkiuzC0SO7VOwyOO7ifp7xzp8tLI6F4Q1aIqK3i+SPTqUsO6bul3OghEcZuZPSH2mj/YeTJBBFA2t+zflFek6k4A3qHycKOBOkZcouFEW0TRr5pyVUtbAKreOxVPL7CqrLUX4CyZKmSAP X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(346002)(39860400002)(396003)(376002)(136003)(230922051799003)(186009)(451199024)(64100799003)(1800799012)(82310400011)(46966006)(36840700001)(40470700004)(55016003)(40480700001)(40460700003)(36860700001)(47076005)(7636003)(356005)(2906002)(5660300002)(82740400003)(83380400001)(6666004)(336012)(426003)(26005)(107886003)(7696005)(1076003)(2616005)(6286002)(478600001)(70586007)(70206006)(36756003)(41300700001)(54906003)(6916009)(4326008)(8676002)(86362001)(316002)(8936002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2023 11:26:26.7288 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 00d16144-79be-4fe4-ed2e-08dbf3f2b051 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000042AC.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8105 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add a new structure "mlx5_devx_geneve_tlv_option_attr" to use in GENEVE TLV option creation. Later this structure will be used by GENEVE TLV option query operation as well. Signed-off-by: Michael Baum --- drivers/common/mlx5/mlx5_devx_cmds.c | 28 +++++++++++++--------------- drivers/common/mlx5/mlx5_devx_cmds.h | 11 ++++++++++- drivers/net/mlx5/mlx5_flow_dv.c | 10 +++++++--- 3 files changed, 30 insertions(+), 19 deletions(-) diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c index 74609e7cb2..9855a97bf4 100644 --- a/drivers/common/mlx5/mlx5_devx_cmds.c +++ b/drivers/common/mlx5/mlx5_devx_cmds.c @@ -2855,19 +2855,15 @@ mlx5_devx_cmd_create_conn_track_offload_obj(void *ctx, uint32_t pd, * * @param[in] ctx * Context returned from mlx5 open_device() glue function. - * @param [in] class - * TLV option variable value of class - * @param [in] type - * TLV option variable value of type - * @param [in] len - * TLV option variable value of len + * @param[in] attr + * Pointer to GENEVE TLV option attributes structure. * * @return * The DevX object created, NULL otherwise and rte_errno is set. */ struct mlx5_devx_obj * mlx5_devx_cmd_create_geneve_tlv_option(void *ctx, - uint16_t class, uint8_t type, uint8_t len) + struct mlx5_devx_geneve_tlv_option_attr *attr) { uint32_t in[MLX5_ST_SZ_DW(create_geneve_tlv_option_in)] = {0}; uint32_t out[MLX5_ST_SZ_DW(general_obj_out_cmd_hdr)] = {0}; @@ -2876,25 +2872,27 @@ mlx5_devx_cmd_create_geneve_tlv_option(void *ctx, 0, SOCKET_ID_ANY); if (!geneve_tlv_opt_obj) { - DRV_LOG(ERR, "Failed to allocate geneve tlv option object."); + DRV_LOG(ERR, "Failed to allocate GENEVE TLV option object."); rte_errno = ENOMEM; return NULL; } void *hdr = MLX5_ADDR_OF(create_geneve_tlv_option_in, in, hdr); void *opt = MLX5_ADDR_OF(create_geneve_tlv_option_in, in, - geneve_tlv_opt); + geneve_tlv_opt); MLX5_SET(general_obj_in_cmd_hdr, hdr, opcode, - MLX5_CMD_OP_CREATE_GENERAL_OBJECT); + MLX5_CMD_OP_CREATE_GENERAL_OBJECT); MLX5_SET(general_obj_in_cmd_hdr, hdr, obj_type, MLX5_GENERAL_OBJ_TYPE_GENEVE_TLV_OPT); MLX5_SET(geneve_tlv_option, opt, option_class, - rte_be_to_cpu_16(class)); - MLX5_SET(geneve_tlv_option, opt, option_type, type); - MLX5_SET(geneve_tlv_option, opt, option_data_length, len); + rte_be_to_cpu_16(attr->option_class)); + MLX5_SET(geneve_tlv_option, opt, option_type, attr->option_type); + MLX5_SET(geneve_tlv_option, opt, option_data_length, + attr->option_data_len); geneve_tlv_opt_obj->obj = mlx5_glue->devx_obj_create(ctx, in, - sizeof(in), out, sizeof(out)); + sizeof(in), out, + sizeof(out)); if (!geneve_tlv_opt_obj->obj) { - DEVX_DRV_LOG(ERR, out, "create GENEVE TLV", NULL, 0); + DEVX_DRV_LOG(ERR, out, "create GENEVE TLV option", NULL, 0); mlx5_free(geneve_tlv_opt_obj); return NULL; } diff --git a/drivers/common/mlx5/mlx5_devx_cmds.h b/drivers/common/mlx5/mlx5_devx_cmds.h index 56ed911c2a..78337dff17 100644 --- a/drivers/common/mlx5/mlx5_devx_cmds.h +++ b/drivers/common/mlx5/mlx5_devx_cmds.h @@ -667,6 +667,15 @@ struct mlx5_devx_crypto_login_attr { uint8_t credential[MLX5_CRYPTO_CREDENTIAL_SIZE]; }; +/* + * GENEVE TLV option attributes structure, used by GENEVE TLV option create. + */ +struct mlx5_devx_geneve_tlv_option_attr { + uint32_t option_class:16; + uint32_t option_type:8; + uint32_t option_data_len:5; +}; + /* mlx5_devx_cmds.c */ __rte_internal @@ -777,7 +786,7 @@ int mlx5_devx_cmd_register_write(void *ctx, uint16_t reg_id, __rte_internal struct mlx5_devx_obj * mlx5_devx_cmd_create_geneve_tlv_option(void *ctx, - uint16_t class, uint8_t type, uint8_t len); + struct mlx5_devx_geneve_tlv_option_attr *attr); /** * Create virtio queue counters object DevX API. diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index f8e364dfdb..8894f51f4c 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -9928,11 +9928,15 @@ flow_dev_geneve_tlv_option_resource_register(struct rte_eth_dev *dev, goto exit; } } else { + struct mlx5_devx_geneve_tlv_option_attr attr = { + .option_class = geneve_opt_v->option_class, + .option_type = geneve_opt_v->option_type, + .option_data_len = geneve_opt_v->option_len, + }; + /* Create a GENEVE TLV object and resource. */ obj = mlx5_devx_cmd_create_geneve_tlv_option(sh->cdev->ctx, - geneve_opt_v->option_class, - geneve_opt_v->option_type, - geneve_opt_v->option_len); + &attr); if (!obj) { ret = rte_flow_error_set(error, ENODATA, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,