From patchwork Thu Jun 6 23:31:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 140845 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DCACE44178; Fri, 7 Jun 2024 01:31:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6DEE842D0B; Fri, 7 Jun 2024 01:31:27 +0200 (CEST) Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by mails.dpdk.org (Postfix) with ESMTP id 54ED2427E1 for ; Fri, 7 Jun 2024 01:31:26 +0200 (CEST) Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-2c199abdbcbso1220576a91.3 for ; Thu, 06 Jun 2024 16:31:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1717716685; x=1718321485; darn=dpdk.org; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=snjlTOZy919GX4IRfkVmMfBi8AYwJWNioxokj+O11Bk=; b=h1wWXuT9gqptfLMNUdN6gbmOe4VFxKKzmj7n+gcGUVZqCDMy4D2V4PbSmIN4DXSy5V H59af0prB+79nksS6IAmSP/mBN3pyiiXAGitekDqKDvhHSZ/Qe+JiAfDoEpFock659op n3bYegabqIpBgfYeLxcTwiYlFjekfbggVd4vw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717716685; x=1718321485; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=snjlTOZy919GX4IRfkVmMfBi8AYwJWNioxokj+O11Bk=; b=khA//E7ykoKLNAsk5HBpU+qWGiNU3GBct2YvbGAefhZmaK9xGzdPC3ZOT6rv0d1DgX OAVhwSKYiKiBseLJihMQIGbnO6CARJtnKnnx0NgDz0gkecwSckhKg436q/O/kt4AE3Ku 8ryxhee1VAxDFd5PVUrLnAdUXSqQOPL+NmshoYgkuzN/5otYc4Ecy1pm+iSXg+CeUSEj Rm/kGQ2L7a6oTGglMY+4s/0sJAgw0v+YYfnxOz5kc/p0ynjpUgv7eW+C4xoO2VsF4mrr 74eNJ2k8MTENddxrtRm0ldRoiCe4HihQBVFymEYjOCZ6QuLBN700Hw520t9x+OyzmJ8a pQIg== X-Gm-Message-State: AOJu0YxbB3uOU6qIFUJy2aQm9w8nMn5Jrc6Io3yQ67/l8w9hwtF46RZC hFo7dWJm10Th4s4hU+1VLyr1naze6VTxLoGj4LjK1Rh091Zh2vM3UMocSzVVxusEiOJOdxNgWBu O69n8F3csegOys79gBzTEZPH7dUrW0YCArrS1zmELL2Vi3cUcGIIDUHFXdVAb+0TULHe/Eba2rU /UYFsvHZ9C68eieGBHr3aR3lpFc4fM X-Google-Smtp-Source: AGHT+IHWUnqXRfIGAz4jK6C+bloObvXTaTCj9riqS6sH1xmX4xxoA8ITbjXv5yMRmwC/pL7erFlm7Q== X-Received: by 2002:a17:90a:f40a:b0:2c2:5c21:5975 with SMTP id 98e67ed59e1d1-2c2bcc4cd9amr952236a91.39.1717716684312; Thu, 06 Jun 2024 16:31:24 -0700 (PDT) Received: from localhost.localdomain ([2605:a601:a780:1400:18ae:5c68:8e66:e211]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c29c23fc94sm2262765a91.29.2024.06.06.16.31.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 16:31:23 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Cc: Damodharam Ammepalli , stable@dpdk.org Subject: [PATCH 2/3] net/bnxt: refactor backing store qcaps v2 Date: Thu, 6 Jun 2024 16:31:15 -0700 Message-Id: <20240606233116.38445-3-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20240606233116.38445-1-ajit.khaparde@broadcom.com> References: <20240606233116.38445-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Damodharam Ammepalli During bnxt_hwrm_func_backing_store_types_count driver increments types only for valid type but not in bnxt_hwrm_func_backing_store_cfg_v2. Implement the same logic in store cfg also to prevent ctx types control loop exiting the loop prematurely while firmware still has valid types to return if queried. Fixes: fe2f715ca580 ("net/bnxt: support backing store v2") Cc: stable@dpdk.org Signed-off-by: Damodharam Ammepalli Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 6ea7089a3f..9ea5cc090f 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -6352,11 +6352,14 @@ int bnxt_hwrm_func_backing_store_qcaps_v2(struct bnxt *bp) uint16_t types, type; int rc; - for (types = 0, type = 0; types < bp->ctx->types && type != BNXT_CTX_INV; types++) { - struct bnxt_ctx_mem *ctxm = &bp->ctx->ctx_arr[types]; + types = 0; + type = 0; + do { + struct bnxt_ctx_mem *ctxm; uint8_t init_val, init_off, i; uint32_t *p; uint32_t flags; + bool cnt = true; HWRM_PREP(&req, HWRM_FUNC_BACKING_STORE_QCAPS_V2, BNXT_USE_CHIMP_MB); req.type = rte_cpu_to_le_16(type); @@ -6365,9 +6368,12 @@ int bnxt_hwrm_func_backing_store_qcaps_v2(struct bnxt *bp) flags = rte_le_to_cpu_32(resp->flags); type = rte_le_to_cpu_16(resp->next_valid_type); - if (!(flags & HWRM_FUNC_BACKING_STORE_QCAPS_V2_OUTPUT_FLAGS_TYPE_VALID)) + if (!(flags & HWRM_FUNC_BACKING_STORE_QCAPS_V2_OUTPUT_FLAGS_TYPE_VALID)) { + cnt = false; goto next; + } + ctxm = &bp->ctx->ctx_arr[types]; ctxm->type = rte_le_to_cpu_16(resp->type); ctxm->flags = flags; @@ -6404,8 +6410,10 @@ int bnxt_hwrm_func_backing_store_qcaps_v2(struct bnxt *bp) last_valid_type = ctxm->type; last_valid_idx = types; next: + if (cnt) + types++; HWRM_UNLOCK(); - } + } while (types < bp->ctx->types && type != BNXT_CTX_INV); ctx->ctx_arr[last_valid_idx].last = true; PMD_DRV_LOG(DEBUG, "Last valid type 0x%x\n", last_valid_type);