[v2] devtools: check that maintainers are listed in mailmap
Checks
Commit Message
When a maintainer changes its mail address, check that the associated
entry in .mailmap knows this address, otherwise there is a chance
.mailmap points at an obsolete address.
While at it, fix Zhirun mail address in mailmap and add Jian and Srikanth.
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
Changes since v1:
- merged patch 1,
- added Jian and Srikanth to .mailmap,
---
.mailmap | 4 +++-
devtools/check-maintainers.sh | 18 ++++++++++++++++++
2 files changed, 21 insertions(+), 1 deletion(-)
Comments
On Fri, Jun 28, 2024 at 2:56 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> When a maintainer changes its mail address, check that the associated
> entry in .mailmap knows this address, otherwise there is a chance
> .mailmap points at an obsolete address.
>
> While at it, fix Zhirun mail address in mailmap and add Jian and Srikanth.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Applied.
@@ -645,6 +645,7 @@ Jesper Wramberg <jesper.wramberg@gmail.com>
Jesse Brandeburg <jesse.brandeburg@intel.com>
Jesse Bruni <jesse.bruni@intel.com>
Jia He <justin.he@arm.com> <jia.he@hxt-semitech.com>
+Jian Wang <jianwang@trustnetic.com>
Jianbo Liu <jianbo.liu@arm.com> <jianbo.liu@linaro.org>
Jianfeng Tan <jianfeng.tan@intel.com>
Jiang Yu <yux.jiang@intel.com>
@@ -1378,6 +1379,7 @@ Souvik Dey <sodey@rbbn.com> <sodey@sonusnet.com>
Spike Du <spiked@nvidia.com>
Sridhar Samudrala <sridhar.samudrala@intel.com>
Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
+Srikanth Jampala <jsrikanth@marvell.com>
Srikanth Yalavarthi <syalavarthi@marvell.com>
Srinivas Narayan <srinivas.narayan@att.com>
Srisivasubramanian Srinivasan <srinivasan@marvell.com> <ssrinivasan@caviumnetworks.com>
@@ -1711,7 +1713,7 @@ Zhihong Wang <wangzhihong.wzh@bytedance.com> <zhihong.wang@intel.com>
Zhike Wang <wangzhike@jd.com> <wangzk320@163.com>
Zhimin Huang <zhiminx.huang@intel.com>
Zhipeng Lu <luzhipeng@cestc.cn>
-Zhirun Yan <zhirun.yan@intel.com>
+Zhirun Yan <yanzhirun_163@163.com> <zhirun.yan@intel.com>
Zhiwei He <zhiwei.he@intel.com>
Zhiyong Yang <zhiyong.yang@intel.com>
Zhuobin Huang <zobin1999@gmail.com>
@@ -85,6 +85,18 @@ check_fx () # <index file>
done
}
+# Check that every maintainer mail is known of .mailmap:
+check_mailmap () # <index file> <mailmap file>
+{
+ sed -n -e 's/^M: \(.*<.*\)$/\1/p' $1 | sort -u | while read line; do
+ name=${line%% <*}
+ mail='<'${line##* <}
+ if ! grep -q "^$name <" $2 || ! grep -iq "^$name.*$mail" $2; then
+ echo $name mail address $mail is not in $2
+ fi
+ done
+}
+
# Add a line to a set of lines if it begins with right pattern
add_line_to_if () # <new line> <lines> <head pattern>
{
@@ -129,4 +141,10 @@ echo '# wrong patterns'
echo '##########'
check_fx MAINTAINERS
+echo
+echo '##########'
+echo '# wrong mailmap'
+echo '##########'
+check_mailmap MAINTAINERS .mailmap
+
# TODO: check overlaps