diff mbox series

eal: make dev_sigbus static

Message ID 20240703151734.14458-1-stephen@networkplumber.org (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series eal: make dev_sigbus static |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/intel-Functional success Functional PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-unit-arm64-testing pending Testing pending
ci/iol-sample-apps-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS

Commit Message

Stephen Hemminger July 3, 2024, 3:17 p.m. UTC 
Only used in one file, and not an exported symbol should be static.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/eal/common/eal_private.h | 22 ----------------------
 lib/eal/linux/eal_dev.c      |  4 ++--
 2 files changed, 2 insertions(+), 24 deletions(-)

Comments

David Marchand July 5, 2024, 2:08 p.m. UTC | #1 
On Wed, Jul 3, 2024 at 5:17 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> Only used in one file, and not an exported symbol should be static.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Applied, thanks.
diff mbox series

Patch

diff --git a/lib/eal/common/eal_private.h b/lib/eal/common/eal_private.h
index 71523cfdb8..e63ecd74f8 100644
--- a/lib/eal/common/eal_private.h
+++ b/lib/eal/common/eal_private.h
@@ -529,28 +529,6 @@  int local_dev_remove(struct rte_device *dev);
  */
 int rte_bus_sigbus_handler(const void *failure_addr);
 
-/**
- * @internal
- * Register the sigbus handler.
- *
- * @return
- *   - On success, zero.
- *   - On failure, a negative value.
- */
-int
-dev_sigbus_handler_register(void);
-
-/**
- * @internal
- * Unregister the sigbus handler.
- *
- * @return
- *   - On success, zero.
- *   - On failure, a negative value.
- */
-int
-dev_sigbus_handler_unregister(void);
-
 /**
  * Get OS-specific EAL mapping base address.
  */
diff --git a/lib/eal/linux/eal_dev.c b/lib/eal/linux/eal_dev.c
index fff4e8fa83..e63f24d108 100644
--- a/lib/eal/linux/eal_dev.c
+++ b/lib/eal/linux/eal_dev.c
@@ -393,7 +393,7 @@  rte_dev_event_monitor_stop(void)
 	return ret;
 }
 
-int
+static int
 dev_sigbus_handler_register(void)
 {
 	sigset_t mask;
@@ -414,7 +414,7 @@  dev_sigbus_handler_register(void)
 	return rte_errno;
 }
 
-int
+static int
 dev_sigbus_handler_unregister(void)
 {
 	rte_errno = 0;