diff mbox series

[v3,19/26] app/dumpcap: use separate Rx and Tx queue limits

Message ID	20240814104933.14062-20-bruce.richardson@intel.com (mailing list archive)
State	Changes Requested, archived
Delegated to:	Thomas Monjalon
Headers	From: Bruce Richardson <bruce.richardson@intel.com> To: dev@dpdk.org Cc: ferruh.yigit@amd.com, thomas@monjalon.net, mb@smartsharesystems.com, Bruce Richardson <bruce.richardson@intel.com> Subject: [PATCH v3 19/26] app/dumpcap: use separate Rx and Tx queue limits Date: Wed, 14 Aug 2024 11:49:25 +0100 Message-ID: <20240814104933.14062-20-bruce.richardson@intel.com> In-Reply-To: <20240814104933.14062-1-bruce.richardson@intel.com> References: <20240812132910.162252-1-bruce.richardson@intel.com> <20240814104933.14062-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	add meson config options for queues per port \| [v3,00/26] add meson config options for queues per port [v3,01/26] cryptodev: remove use of ethdev max queues definition [v3,02/26] eventdev: remove use of ethev queues define [v3,03/26] app/test-bbdev: remove use of ethdev queue count value [v3,04/26] config: add separate defines for max Rx and Tx queues [v3,05/26] ethdev: use separate Rx and Tx queue limits [v3,06/26] bpf: use separate Rx and Tx queue limits [v3,07/26] latencystats: use separate Rx and Tx queue limits [v3,08/26] pdump: use separate Rx and Tx queue limits [v3,09/26] power: use separate Rx and Tx queue limits [v3,10/26] net/af_xdp: use separate Rx and Tx queue limits [v3,11/26] net/cnxk: use separate Rx and Tx queue limits [v3,12/26] net/failsafe: use separate Rx and Tx queue limits [v3,13/26] net/hns3: use separate Rx and Tx queue limits [v3,14/26] net/mlx5: use separate Rx and Tx queue limits [v3,15/26] net/null: use separate Rx and Tx queue limits [v3,16/26] net/sfc: use separate Rx and Tx queue limits [v3,17/26] net/thunderx: use separate Rx and Tx queue limits [v3,18/26] net/vhost: use separate Rx and Tx queue limits [v3,19/26] app/dumpcap: use separate Rx and Tx queue limits [v3,20/26] app/test-pmd: use separate Rx and Tx queue limits [v3,21/26] examples/ipsec-secgw: use separate Rx and Tx queue limits [v3,22/26] examples/l3fwd-power: use separate Rx and Tx queue limits [v3,23/26] examples/l3fwd: use separate Rx and Tx queue limits [v3,24/26] examples/vhost: use separate Rx and Tx queue limits [v3,25/26] config: make queues per port a meson config option [v3,26/26] config: add computed max queues define for compatibility

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Bruce Richardson Aug. 14, 2024, 10:49 a.m. UTC

Update app to use the new defines RTE_MAX_ETHPORT_TX_QUEUES and
RTE_MAX_ETHPORT_RX_QUEUES rather than the old define
RTE_MAX_QUEUES_PER_PORT.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
---
 app/dumpcap/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stephen Hemminger Oct. 3, 2024, 11:38 p.m. UTC | #1

On Wed, 14 Aug 2024 11:49:25 +0100
Bruce Richardson <bruce.richardson@intel.com> wrote:

> Update app to use the new defines RTE_MAX_ETHPORT_TX_QUEUES and
> RTE_MAX_ETHPORT_RX_QUEUES rather than the old define
> RTE_MAX_QUEUES_PER_PORT.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
> ---
>  app/dumpcap/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c
> index 6feb8f5672..fbaaa4fe3f 100644
> --- a/app/dumpcap/main.c
> +++ b/app/dumpcap/main.c
> @@ -95,7 +95,7 @@ struct interface {
>  	struct rte_bpf_prm *bpf_prm;
>  	char name[RTE_ETH_NAME_MAX_LEN];
>  
> -	struct rte_rxtx_callback *rx_cb[RTE_MAX_QUEUES_PER_PORT];
> +	struct rte_rxtx_callback *rx_cb[RTE_MAX_ETHPORT_RX_QUEUES];
>  	const char *ifname;
>  	const char *ifdescr;
>  };

Looking closer, this field is defined and never used, it can go.

That structure is used to gather the command line arguments
before applying them.

diff mbox series

Patch

diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c
index 6feb8f5672..fbaaa4fe3f 100644
--- a/app/dumpcap/main.c
+++ b/app/dumpcap/main.c
@@ -95,7 +95,7 @@  struct interface {
 	struct rte_bpf_prm *bpf_prm;
 	char name[RTE_ETH_NAME_MAX_LEN];
 
-	struct rte_rxtx_callback *rx_cb[RTE_MAX_QUEUES_PER_PORT];
+	struct rte_rxtx_callback *rx_cb[RTE_MAX_ETHPORT_RX_QUEUES];
 	const char *ifname;
 	const char *ifdescr;
 };