[v3,04/26] config: add separate defines for max Rx and Tx queues

Message ID 20240814104933.14062-5-bruce.richardson@intel.com (mailing list archive)
State New
Delegated to: Thomas Monjalon
Headers
Series add meson config options for queues per port |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Bruce Richardson Aug. 14, 2024, 10:49 a.m. UTC
Rather than having a single define for maximum queues per ethernet port,
we can set the max values for Rx queues and Tx queue independently. This
allows future memory saving for apps which only need large numbers of Rx
queues or only large numbers of Tx queues.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
---
 config/rte_config.h                    | 2 ++
 doc/guides/rel_notes/release_24_11.rst | 6 ++++++
 2 files changed, 8 insertions(+)
  

Comments

fengchengwen Sept. 10, 2024, 2:54 a.m. UTC | #1
On 2024/8/14 18:49, Bruce Richardson wrote:
> Rather than having a single define for maximum queues per ethernet port,
> we can set the max values for Rx queues and Tx queue independently. This
> allows future memory saving for apps which only need large numbers of Rx
> queues or only large numbers of Tx queues.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
> ---
>  config/rte_config.h                    | 2 ++
>  doc/guides/rel_notes/release_24_11.rst | 6 ++++++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/config/rte_config.h b/config/rte_config.h
> index d67ff77c71..2c11b4eeec 100644
> --- a/config/rte_config.h
> +++ b/config/rte_config.h
> @@ -65,6 +65,8 @@
>  
>  /* ether defines */
>  #define RTE_MAX_QUEUES_PER_PORT 1024
> +#define RTE_MAX_ETHPORT_RX_QUEUES 1024
> +#define RTE_MAX_ETHPORT_TX_QUEUES 1024

The Rx Queues != Tx Queues is not a mainstream scenario (at least from most of DPDK user as I know),
rename it (not separate Rx/Tx) with eth meaning and make it as a compile option is enough.

>  #define RTE_ETHDEV_QUEUE_STAT_CNTRS 16 /* max 256 */
>  #define RTE_ETHDEV_RXTX_CALLBACKS 1
>  #define RTE_MAX_MULTI_HOST_CTRLS 4
> diff --git a/doc/guides/rel_notes/release_24_11.rst b/doc/guides/rel_notes/release_24_11.rst
> index 0ff70d9057..3725c056ba 100644
> --- a/doc/guides/rel_notes/release_24_11.rst
> +++ b/doc/guides/rel_notes/release_24_11.rst
> @@ -55,6 +55,12 @@ New Features
>       Also, make sure to start the actual text at the margin.
>       =======================================================
>  
> +* **New configuration settings for Rx and Tx Ethernet Queues.**
> +
> +   New defines have been added to DPDK to allow independent tracking of the maximum number of Rx and Tx queues.
> +   These defines as ``RTE_MAX_ETHPORT_RX_QUEUES`` and ``RTE_MAX_ETHPORT_TX_QUEUES``,
> +   and should be used in place of the older macro ``RTE_MAX_QUEUES_PER_PORT``.
> +
>  
>  Removed Items
>  -------------
>
  

Patch

diff --git a/config/rte_config.h b/config/rte_config.h
index d67ff77c71..2c11b4eeec 100644
--- a/config/rte_config.h
+++ b/config/rte_config.h
@@ -65,6 +65,8 @@ 
 
 /* ether defines */
 #define RTE_MAX_QUEUES_PER_PORT 1024
+#define RTE_MAX_ETHPORT_RX_QUEUES 1024
+#define RTE_MAX_ETHPORT_TX_QUEUES 1024
 #define RTE_ETHDEV_QUEUE_STAT_CNTRS 16 /* max 256 */
 #define RTE_ETHDEV_RXTX_CALLBACKS 1
 #define RTE_MAX_MULTI_HOST_CTRLS 4
diff --git a/doc/guides/rel_notes/release_24_11.rst b/doc/guides/rel_notes/release_24_11.rst
index 0ff70d9057..3725c056ba 100644
--- a/doc/guides/rel_notes/release_24_11.rst
+++ b/doc/guides/rel_notes/release_24_11.rst
@@ -55,6 +55,12 @@  New Features
      Also, make sure to start the actual text at the margin.
      =======================================================
 
+* **New configuration settings for Rx and Tx Ethernet Queues.**
+
+   New defines have been added to DPDK to allow independent tracking of the maximum number of Rx and Tx queues.
+   These defines as ``RTE_MAX_ETHPORT_RX_QUEUES`` and ``RTE_MAX_ETHPORT_TX_QUEUES``,
+   and should be used in place of the older macro ``RTE_MAX_QUEUES_PER_PORT``.
+
 
 Removed Items
 -------------