[v2,12/12] net/ice: add support for FEC auto-detect for E830

Message ID 20240822185346.221885-13-soumyadeep.hore@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Bruce Richardson
Headers
Series Align ICE shared code with Base driver |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/github-robot: build success github build: passed
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS RETEST #1
ci/iol-sample-apps-testing success Testing PASS RETEST #1
ci/iol-marvell-Functional success Functional Testing PASS RETEST #1
ci/iol-broadcom-Functional success Functional Testing PASS RETEST #1
ci/iol-intel-Functional success Functional Testing PASS RETEST #1
ci/iol-intel-Performance success Performance Testing PASS RETEST #1

Commit Message

Soumyadeep Hore Aug. 22, 2024, 6:53 p.m. UTC
Extends the functionality of the function responsible for
checking if the firmware supports FEC (Forward Error Correction)
disable in Auto FEC mode. It now includes an additional check to
determine if the adapter is a E830 model. With this
change, the function will enable FEC auto-detect support for
E830 adapters.

Signed-off-by: Soumyadeep Hore <soumyadeep.hore@intel.com>
---
 drivers/net/ice/base/ice_common.c | 2 ++
 1 file changed, 2 insertions(+)
  

Comments

Patrick Robb Aug. 26, 2024, 3:55 p.m. UTC | #1
Recheck-request: iol-marvell-Functional

On Fri, Aug 23, 2024 at 6:51 AM Soumyadeep Hore
<soumyadeep.hore@intel.com> wrote:
>
> Updating the latest shared code patches to ICE base driver.
>
> ---
> v3:
> - Addressed comments givn by reviewer
> ---
> v2:
> - Addressed comments given by reviewer
> - Corrected errors in Camel Case
> ---
>
> Dan Nowlin (2):
>   net/ice: correct Tx Scheduler AQ command RD bit for E825C
>   net/ice: support optional flags in signature segment header
>
> Fabio Pricoco (1):
>   net/ice: update iteration of TLVs in Preserved Fields Area
>
> Jacob Keller (1):
>   net/ice: avoid reading past end of PFA
>
> Norbert Zulinski (2):
>   net/ice: updates for ptp init in E825C
>   net/ice: update PTP init
>
> Oleg Akhrem (1):
>   net/ice: address compilation errors
>
> Paul Greenwalt (3):
>   net/ice: add new tag definitions
>   net/ice: fix link speed for 200G
>   net/ice: update E830 50G branding strings
>
> Przemyslaw Gierszynski (1):
>   net/ice: add support for FEC auto-detect for E830
>
> Yogesh Bhosale (1):
>   net/ice: use correct format specifiers for unsigned ints
>
>  drivers/net/ice/base/ice_adminq_cmd.h |   2 +-
>  drivers/net/ice/base/ice_cgu_regs.h   |  19 +++++
>  drivers/net/ice/base/ice_common.c     |  66 ++++++++--------
>  drivers/net/ice/base/ice_ddp.c        |  31 +++++++-
>  drivers/net/ice/base/ice_ddp.h        |   5 +-
>  drivers/net/ice/base/ice_devids.h     |  12 +--
>  drivers/net/ice/base/ice_hw_autogen.h |  14 ++++
>  drivers/net/ice/base/ice_nvm.c        |  36 ++++++---
>  drivers/net/ice/base/ice_ptp_consts.h |  75 ++++++++++++++++++
>  drivers/net/ice/base/ice_ptp_hw.c     | 106 +++++++++++++-------------
>  drivers/net/ice/base/ice_ptp_hw.h     |  21 +++++
>  drivers/net/ice/ice_ethdev.c          |   6 +-
>  12 files changed, 285 insertions(+), 108 deletions(-)
>
> --
> 2.43.0
>
  
Bruce Richardson Aug. 28, 2024, 4:42 p.m. UTC | #2
On Fri, Aug 23, 2024 at 09:56:38AM +0000, Soumyadeep Hore wrote:
> Updating the latest shared code patches to ICE base driver.
> 
> ---
> v3:
> - Addressed comments givn by reviewer
> ---
> v2:
> - Addressed comments given by reviewer
> - Corrected errors in Camel Case
> ---
> 
I've performed on apply the few cleanups I highlighted in emails in this
thread. Please review carefully the resulting 11 commits on
dpdk-next-net-intel tree.

Series-acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied to dpdk-next-net-intel

Thanks,
/Bruce
  
Bruce Richardson Sept. 13, 2024, 10:22 a.m. UTC | #3
On Wed, Aug 28, 2024 at 05:42:24PM +0100, Bruce Richardson wrote:
> On Fri, Aug 23, 2024 at 09:56:38AM +0000, Soumyadeep Hore wrote:
> > Updating the latest shared code patches to ICE base driver.
> > 
> > ---
> > v3:
> > - Addressed comments givn by reviewer
> > ---
> > v2:
> > - Addressed comments given by reviewer
> > - Corrected errors in Camel Case
> > ---
> > 
> I've performed on apply the few cleanups I highlighted in emails in this
> thread. Please review carefully the resulting 11 commits on
> dpdk-next-net-intel tree.
> 
> Series-acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> Applied to dpdk-next-net-intel
> 

Hi Soumyadeep,

After merging the patch series for the equivalent updates for ixgbe and
i40e, I realise that this patchset did not update the README file for the
driver. The last update recorded there is from last year.

Can you please do an additional patch for the file
"drivers/net/ice/base/README" to update the snapshot date.

Thanks,
/Bruce
  

Patch

diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c
index 08ba0b45a5..c8047ca59f 100644
--- a/drivers/net/ice/base/ice_common.c
+++ b/drivers/net/ice/base/ice_common.c
@@ -6456,6 +6456,8 @@  u32 ice_get_link_speed(u16 index)
  */
 bool ice_fw_supports_fec_dis_auto(struct ice_hw *hw)
 {
+	if (ice_is_e830(hw))
+		return true;
 	return ice_is_fw_min_ver(hw, ICE_FW_VER_BRANCH_E810,
 				 ICE_FW_FEC_DIS_AUTO_MAJ,
 				 ICE_FW_FEC_DIS_AUTO_MIN,