[v2,1/1] drivers/baseband: device queues initialization

Message ID 20240823145637.202025-2-hernan.vargas@intel.com (mailing list archive)
State Awaiting Upstream
Delegated to: Maxime Coquelin
Headers
Series Device queue initialization |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/github-robot: build success github build: passed
ci/iol-marvell-Functional success Functional Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS

Commit Message

Hernan Vargas Aug. 23, 2024, 2:56 p.m. UTC
Cosmetic change to keep code consistency in PMD for queue
initialization set to zero.
No functional impact.

Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
---
 drivers/baseband/acc/rte_acc100_pmd.c              | 1 +
 drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 2 ++
 drivers/baseband/fpga_lte_fec/fpga_lte_fec.c       | 2 ++
 drivers/baseband/la12xx/bbdev_la12xx.c             | 2 ++
 4 files changed, 7 insertions(+)
  

Comments

Hemant Agrawal Aug. 26, 2024, 5:14 a.m. UTC | #1
On 23-08-2024 20:26, Hernan Vargas wrote:
> Cosmetic change to keep code consistency in PMD for queue
> initialization set to zero.
> No functional impact.
>
> Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
> ---
>   drivers/baseband/acc/rte_acc100_pmd.c              | 1 +
>   drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 2 ++
>   drivers/baseband/fpga_lte_fec/fpga_lte_fec.c       | 2 ++
>   drivers/baseband/la12xx/bbdev_la12xx.c             | 2 ++
>   4 files changed, 7 insertions(+)
>
> diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c
> index ab69350080f0..9b12fa7048c2 100644
> --- a/drivers/baseband/acc/rte_acc100_pmd.c
> +++ b/drivers/baseband/acc/rte_acc100_pmd.c
> @@ -1030,6 +1030,7 @@ acc100_dev_info_get(struct rte_bbdev *dev,
>   	dev_info->num_queues[RTE_BBDEV_OP_LDPC_ENC] = d->acc_conf.q_dl_5g.num_aqs_per_groups *
>   			d->acc_conf.q_dl_5g.num_qgroups;
>   	dev_info->num_queues[RTE_BBDEV_OP_FFT] = 0;
> +	dev_info->num_queues[RTE_BBDEV_OP_MLDTS] = 0;
>   	dev_info->queue_priority[RTE_BBDEV_OP_TURBO_DEC] = d->acc_conf.q_ul_4g.num_qgroups;
>   	dev_info->queue_priority[RTE_BBDEV_OP_TURBO_ENC] = d->acc_conf.q_dl_4g.num_qgroups;
>   	dev_info->queue_priority[RTE_BBDEV_OP_LDPC_DEC] = d->acc_conf.q_ul_5g.num_qgroups;
> diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
> index 9b253cde280d..dad16ad422b5 100644
> --- a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
> +++ b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
> @@ -625,6 +625,8 @@ fpga_5gnr_dev_info_get(struct rte_bbdev *dev, struct rte_bbdev_driver_info *dev_
>   	dev_info->num_queues[RTE_BBDEV_OP_TURBO_ENC] = 0;
>   	dev_info->num_queues[RTE_BBDEV_OP_LDPC_DEC] = dev_info->max_num_queues / 2;
>   	dev_info->num_queues[RTE_BBDEV_OP_LDPC_ENC] = dev_info->max_num_queues / 2;
> +	dev_info->num_queues[RTE_BBDEV_OP_FFT] = 0;
> +	dev_info->num_queues[RTE_BBDEV_OP_MLDTS] = 0;
>   	dev_info->queue_priority[RTE_BBDEV_OP_LDPC_DEC] = 1;
>   	dev_info->queue_priority[RTE_BBDEV_OP_LDPC_ENC] = 1;
>   }
> diff --git a/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c b/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c
> index a4a963f74dbf..c6a3c3805a04 100644
> --- a/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c
> +++ b/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c
> @@ -659,6 +659,8 @@ fpga_dev_info_get(struct rte_bbdev *dev,
>   	dev_info->num_queues[RTE_BBDEV_OP_TURBO_ENC] = dev_info->max_num_queues / 2;
>   	dev_info->num_queues[RTE_BBDEV_OP_LDPC_DEC] = 0;
>   	dev_info->num_queues[RTE_BBDEV_OP_LDPC_ENC] = 0;
> +	dev_info->num_queues[RTE_BBDEV_OP_FFT] = 0;
> +	dev_info->num_queues[RTE_BBDEV_OP_MLDTS] = 0;
>   	dev_info->queue_priority[RTE_BBDEV_OP_TURBO_DEC] = 1;
>   	dev_info->queue_priority[RTE_BBDEV_OP_TURBO_ENC] = 1;
>   }
> diff --git a/drivers/baseband/la12xx/bbdev_la12xx.c b/drivers/baseband/la12xx/bbdev_la12xx.c
> index 1a56e73abdab..c13eabbf4b6e 100644
> --- a/drivers/baseband/la12xx/bbdev_la12xx.c
> +++ b/drivers/baseband/la12xx/bbdev_la12xx.c
> @@ -108,6 +108,8 @@ la12xx_info_get(struct rte_bbdev *dev __rte_unused,
>   	dev_info->num_queues[RTE_BBDEV_OP_TURBO_ENC] = 0;
>   	dev_info->num_queues[RTE_BBDEV_OP_LDPC_DEC] = LA12XX_MAX_QUEUES / 2;
>   	dev_info->num_queues[RTE_BBDEV_OP_LDPC_ENC] = LA12XX_MAX_QUEUES / 2;
> +	dev_info->num_queues[RTE_BBDEV_OP_FFT] = 0;
> +	dev_info->num_queues[RTE_BBDEV_OP_MLDTS] = 0;
>   	dev_info->queue_priority[RTE_BBDEV_OP_LDPC_DEC] = 1;
>   	dev_info->queue_priority[RTE_BBDEV_OP_LDPC_ENC] = 1;
>   	rte_bbdev_log_debug("got device info from %u", dev->data->dev_id);
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
  
Maxime Coquelin Sept. 10, 2024, 3:34 p.m. UTC | #2
On 8/23/24 16:56, Hernan Vargas wrote:
> Cosmetic change to keep code consistency in PMD for queue
> initialization set to zero.
> No functional impact.
> 
> Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
> ---
>   drivers/baseband/acc/rte_acc100_pmd.c              | 1 +
>   drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 2 ++
>   drivers/baseband/fpga_lte_fec/fpga_lte_fec.c       | 2 ++
>   drivers/baseband/la12xx/bbdev_la12xx.c             | 2 ++
>   4 files changed, 7 insertions(+)
> 
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime
  
Maxime Coquelin Sept. 13, 2024, 1:50 p.m. UTC | #3
On 8/23/24 16:56, Hernan Vargas wrote:
> Cosmetic change to keep code consistency in PMD for queue
> initialization set to zero.
> No functional impact.
> 
> Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
> ---
>   drivers/baseband/acc/rte_acc100_pmd.c              | 1 +
>   drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 2 ++
>   drivers/baseband/fpga_lte_fec/fpga_lte_fec.c       | 2 ++
>   drivers/baseband/la12xx/bbdev_la12xx.c             | 2 ++
>   4 files changed, 7 insertions(+)
> 

Applied to dpdk-next-baseband/for-main

Thanks,
Maxime
  

Patch

diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c
index ab69350080f0..9b12fa7048c2 100644
--- a/drivers/baseband/acc/rte_acc100_pmd.c
+++ b/drivers/baseband/acc/rte_acc100_pmd.c
@@ -1030,6 +1030,7 @@  acc100_dev_info_get(struct rte_bbdev *dev,
 	dev_info->num_queues[RTE_BBDEV_OP_LDPC_ENC] = d->acc_conf.q_dl_5g.num_aqs_per_groups *
 			d->acc_conf.q_dl_5g.num_qgroups;
 	dev_info->num_queues[RTE_BBDEV_OP_FFT] = 0;
+	dev_info->num_queues[RTE_BBDEV_OP_MLDTS] = 0;
 	dev_info->queue_priority[RTE_BBDEV_OP_TURBO_DEC] = d->acc_conf.q_ul_4g.num_qgroups;
 	dev_info->queue_priority[RTE_BBDEV_OP_TURBO_ENC] = d->acc_conf.q_dl_4g.num_qgroups;
 	dev_info->queue_priority[RTE_BBDEV_OP_LDPC_DEC] = d->acc_conf.q_ul_5g.num_qgroups;
diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
index 9b253cde280d..dad16ad422b5 100644
--- a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
+++ b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
@@ -625,6 +625,8 @@  fpga_5gnr_dev_info_get(struct rte_bbdev *dev, struct rte_bbdev_driver_info *dev_
 	dev_info->num_queues[RTE_BBDEV_OP_TURBO_ENC] = 0;
 	dev_info->num_queues[RTE_BBDEV_OP_LDPC_DEC] = dev_info->max_num_queues / 2;
 	dev_info->num_queues[RTE_BBDEV_OP_LDPC_ENC] = dev_info->max_num_queues / 2;
+	dev_info->num_queues[RTE_BBDEV_OP_FFT] = 0;
+	dev_info->num_queues[RTE_BBDEV_OP_MLDTS] = 0;
 	dev_info->queue_priority[RTE_BBDEV_OP_LDPC_DEC] = 1;
 	dev_info->queue_priority[RTE_BBDEV_OP_LDPC_ENC] = 1;
 }
diff --git a/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c b/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c
index a4a963f74dbf..c6a3c3805a04 100644
--- a/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c
+++ b/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c
@@ -659,6 +659,8 @@  fpga_dev_info_get(struct rte_bbdev *dev,
 	dev_info->num_queues[RTE_BBDEV_OP_TURBO_ENC] = dev_info->max_num_queues / 2;
 	dev_info->num_queues[RTE_BBDEV_OP_LDPC_DEC] = 0;
 	dev_info->num_queues[RTE_BBDEV_OP_LDPC_ENC] = 0;
+	dev_info->num_queues[RTE_BBDEV_OP_FFT] = 0;
+	dev_info->num_queues[RTE_BBDEV_OP_MLDTS] = 0;
 	dev_info->queue_priority[RTE_BBDEV_OP_TURBO_DEC] = 1;
 	dev_info->queue_priority[RTE_BBDEV_OP_TURBO_ENC] = 1;
 }
diff --git a/drivers/baseband/la12xx/bbdev_la12xx.c b/drivers/baseband/la12xx/bbdev_la12xx.c
index 1a56e73abdab..c13eabbf4b6e 100644
--- a/drivers/baseband/la12xx/bbdev_la12xx.c
+++ b/drivers/baseband/la12xx/bbdev_la12xx.c
@@ -108,6 +108,8 @@  la12xx_info_get(struct rte_bbdev *dev __rte_unused,
 	dev_info->num_queues[RTE_BBDEV_OP_TURBO_ENC] = 0;
 	dev_info->num_queues[RTE_BBDEV_OP_LDPC_DEC] = LA12XX_MAX_QUEUES / 2;
 	dev_info->num_queues[RTE_BBDEV_OP_LDPC_ENC] = LA12XX_MAX_QUEUES / 2;
+	dev_info->num_queues[RTE_BBDEV_OP_FFT] = 0;
+	dev_info->num_queues[RTE_BBDEV_OP_MLDTS] = 0;
 	dev_info->queue_priority[RTE_BBDEV_OP_LDPC_DEC] = 1;
 	dev_info->queue_priority[RTE_BBDEV_OP_LDPC_ENC] = 1;
 	rte_bbdev_log_debug("got device info from %u", dev->data->dev_id);